[Xen-devel] [PATCH v3] xen/arm: gicv2: Export GICv2m register frames to Dom0 by device tree

2016-04-27 Thread Wei Chen
This patch adds v2m extension support in GIC-v2 driver. The GICv2 driver detects the MSI frames from device tree and creates corresponding device tree nodes in dom0's DTB. It also provides one hw_ops callback to map v2m MMIO regions to dom0 and route v2m SPIs to dom0. With this GICv2m extension su

Re: [Xen-devel] [PATCH v9 08/27] arm/x86/vmap: Add v[z|m]alloc_xen and vm_init_type

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 04:38, wrote: >> With vm_alloc() getting removed, vm_free() should get removed >> here too. And with that, vm_alloc_type() and vm_free_type() can >> then just become vm_alloc() and vm_free() respectively (as static >> internal functions). > > Please take a look at this inline

Re: [Xen-devel] [for-4.7] x86/emulate: synchronize LOCKed instruction emulation

2016-04-27 Thread Razvan Cojocaru
On 04/27/2016 09:22 AM, Jan Beulich wrote: On 26.04.16 at 19:23, wrote: >> On 04/26/16 19:03, George Dunlap wrote: >>> On 19/04/16 17:35, Jan Beulich wrote: >>> Razvan Cojocaru 04/19/16 1:01 PM >>> > I think this might be because the LOCK prefix should guarantee that the > instru

Re: [Xen-devel] [edk2] OVMF broken under Xen (in PCI initialisation)

2016-04-27 Thread Ni, Ruiyu
Gary, In PciEnumeratorLight(), please directly assign 0 to MinBus when Configuration() returns error, instead of calling PciGetBusRange() to extract MinBus from the descriptors returned from Configuration(). Regards, Ray >-Original Message- >From: Gary Lin [mailto:g...@suse.com] >Sent: We

Re: [Xen-devel] [PATCH V5] vm_event: Allow subscribing to write events for specific MSR-s

2016-04-27 Thread Razvan Cojocaru
On 04/26/2016 06:28 PM, Tamas K Lengyel wrote: > > > @@ -55,6 +61,9 @@ void vm_event_cleanup_domain(struct domain *d) > > v->arch.vm_event = NULL; > > } > > > > +xfree(d->arch.monitor_msr_bitmap); > > +d->arch.monitor_msr_bitmap = NULL; > > + >

Re: [Xen-devel] [PATCH v9 10/27] xsplice: Add helper elf routines

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 03:59, wrote: >> > +static int xsplice_header_check(const struct xsplice_elf *elf) >> > +{ >> > +const Elf_Ehdr *hdr = elf->hdr; >> > + >> > +if ( sizeof(*elf->hdr) > elf->len ) >> > +{ >> > +dprintk(XENLOG_ERR, XSPLICE "%s: Section header is bigger than > p

Re: [Xen-devel] [for-4.7] x86/emulate: synchronize LOCKed instruction emulation

2016-04-27 Thread Andrew Cooper
On 27/04/2016 07:25, Jan Beulich wrote: On 26.04.16 at 19:39, wrote: >> On 26/04/16 18:23, Razvan Cojocaru wrote: >>> Regarding this version of the patch, Jan has asked for more information >>> on the performance impact, but I'm not sure how to obtain it in a >>> rigorous manner. If it is dec

Re: [Xen-devel] [PATCH] libxl: don't add cache mode for empty drives

2016-04-27 Thread Roger Pau Monné
On Tue, Apr 26, 2016 at 10:35:31PM -0600, Jim Fehlig wrote: > qemu commit 91a097e7 forbids specifying the cache mode for empty > drives. Attempting to create a domain with an empty qdisk cdrom > results in > > qemu-system-x86_64: -drive if=ide,index=1,readonly=on,media=cdrom, >cache=writeback,

[Xen-devel] [PATCH V6] vm_event: Allow subscribing to write events for specific MSR-s

2016-04-27 Thread Razvan Cojocaru
Previously, subscribing to MSR write events was an all-or-none approach, with special cases for introspection MSR-s. This patch allows the vm_event consumer to specify exactly what MSR-s it is interested in, and as a side-effect gets rid of the vmx_introspection_force_enabled_msrs[] special case. T

Re: [Xen-devel] [PATCH v9 10/27] xsplice: Add helper elf routines

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 06:06, wrote: >> > +static int xsplice_header_check(const struct xsplice_elf *elf) >> > +{ > ..snip.. >> > +if ( elf->hdr->e_shnum > 64 ) >> > +{ >> > +dprintk(XENLOG_ERR, XSPLICE "%s: Too many (%u) sections!\n", >> > +elf->name, elf->hdr->e_shnu

Re: [Xen-devel] [PATCH v9 11/27] xsplice: Implement payload loading

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 03:47, wrote: >> > +static int move_payload(struct payload *payload, struct xsplice_elf *elf) >> > +{ > .. snip.. >> > +/* Compute size of different regions. */ >> > +for ( i = 1; i < elf->hdr->e_shnum; i++ ) >> > +{ >> > +if ( (elf->sec[i].sec->sh_flags & (S

Re: [Xen-devel] [edk2] OVMF broken under Xen (in PCI initialisation)

2016-04-27 Thread Gary Lin
On Wed, Apr 27, 2016 at 07:18:21AM +, Ni, Ruiyu wrote: > Gary, > In PciEnumeratorLight(), please directly assign 0 to MinBus when > Configuration() returns error, instead of calling PciGetBusRange() to > extract MinBus from the descriptors returned from Configuration(). > OK, I ignored PciGetB

Re: [Xen-devel] [PATCH v9 11/27] xsplice: Implement payload loading

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 05:28, wrote: >> > +static int move_payload(struct payload *payload, struct xsplice_elf *elf) >> > +{ > ..snip.. >> > +for ( i = 1; i < elf->hdr->e_shnum; i++ ) >> > +{ >> > +if ( elf->sec[i].sec->sh_flags & SHF_ALLOC ) >> > +{ >> > +uint8_t *

Re: [Xen-devel] [PATCH v9 12/27] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 05:39, wrote: > +static int check_special_sections(const struct xsplice_elf *elf) > +{ > +unsigned int i; > +static const char *const names[] = { ELF_XSPLICE_FUNC }; > +DECLARE_BITMAP(count, ARRAY_SIZE(names)) = { 0 }; Perhaps better "seen" or "found" or some such,

Re: [Xen-devel] [PATCH v9 16/27] x86, xsplice: Print payload's symbol name and payload name in backtraces

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 05:31, wrote: > From affca85da4d57c466cc3a603afa4d57fea7ed092 Mon Sep 17 00:00:00 2001 > From: Ross Lagerwall > Date: Fri, 22 Apr 2016 11:16:36 -0400 > Subject: [PATCH] x86, xsplice: Print payload's symbol name and payload name in > backtraces > > Naturally the backtrace is p

Re: [Xen-devel] [PATCH v2 03/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping

2016-04-27 Thread Xu, Quan
On April 25, 2016 5:51 PM, Jan Beulich wrote: > >>> On 18.04.16 at 16:00, wrote: > > --- a/xen/arch/x86/mm.c > > +++ b/xen/arch/x86/mm.c > > @@ -2467,7 +2467,7 @@ static int __get_page_type(struct page_info > *page, unsigned long type, > > int preemptible) { > >

Re: [Xen-devel] [PATCH v2 for-4.7 07/14] libxc: fix uninitialized variable

2016-04-27 Thread Roger Pau Monne
On Tue, Apr 26, 2016 at 04:16:51PM +0100, Wei Liu wrote: > On Tue, Apr 26, 2016 at 04:52:16PM +0200, Roger Pau Monne wrote: > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Ian Jackson > > Cc: Wei Liu > > --- > > tools/libxc/xc_dom_bzimageloader.c | 2 +- > > 1 file changed, 1 insertion(+), 1

Re: [Xen-devel] [PATCH v9 19/27] xsplice: Add support for alternatives

2016-04-27 Thread Jan Beulich
>>> On 25.04.16 at 17:35, wrote: > From: Ross Lagerwall > > Add support for applying alternative sections within xsplice payload. > At payload load time, apply an alternative sections that are found. > > Also we add an test-case exercising a rather useless alternative > (patching a NOP with a N

Re: [Xen-devel] [PATCH v2 for-4.7 07/14] libxc: fix uninitialized variable

2016-04-27 Thread Andrew Cooper
On 27/04/16 09:57, Roger Pau Monne wrote: > On Tue, Apr 26, 2016 at 04:16:51PM +0100, Wei Liu wrote: >> On Tue, Apr 26, 2016 at 04:52:16PM +0200, Roger Pau Monne wrote: >>> Signed-off-by: Roger Pau Monné >>> --- >>> Cc: Ian Jackson >>> Cc: Wei Liu >>> --- >>> tools/libxc/xc_dom_bzimageloader.c

Re: [Xen-devel] [PATCH v2 07/11] IOMMU/MMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} (top level ones).

2016-04-27 Thread Xu, Quan
On April 27, 2016 2:32 PM, Jan Beulich wrote: > >>> On 27.04.16 at 08:21, wrote: > > On April 26, 2016 8:49 PM, Jan Beulich wrote: > >> Hmm, the "positive" here has nothing to do with the "positive" in patch 1. > >> Please just have a look at xenmem_add_to_physmap() as a whole. > >> > > > > Than

Re: [Xen-devel] [PATCH v3 2/3] x86/ioreq server: Add new functions to get/set memory types.

2016-04-27 Thread Yu, Zhang
On 4/26/2016 6:53 PM, Wei Liu wrote: Hi Yu On Mon, Apr 25, 2016 at 06:35:39PM +0800, Yu Zhang wrote: For clarity this patch breaks the code to set/get memory types out of do_hvm_op() into dedicated functions: hvmop_set/get_mem_type(). Also, for clarity, checks for whether a memory type change

Re: [Xen-devel] [PATCH v9 24/27] xsplice: Stacking build-id dependency checking.

2016-04-27 Thread Jan Beulich
>>> On 25.04.16 at 17:35, wrote: > @@ -25,7 +28,7 @@ clean:: > .PHONY: config.h > config.h: OLD_CODE_SZ=$(call CODE_SZ,$(BASEDIR)/xen-syms,xen_extra_version) > config.h: NEW_CODE_SZ=$(call CODE_SZ,$<,xen_hello_world) > -config.h: xen_hello_world_func.o > +config.h: xen_hello_world_func.o xen_by

Re: [Xen-devel] [PATCH v9 26/27] xsplice: Prevent duplicate payloads from being loaded.

2016-04-27 Thread Jan Beulich
>>> On 25.04.16 at 17:35, wrote: > From: Ross Lagerwall > > Signed-off-by: Ross Lagerwall > Signed-off-by: Konrad Rzeszutek Wilk > Reviewed-by: Andrew Cooper > > --- > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Keir Fraser > Cc: Tim Deegan > > v6: Drop recursive lock - also now the caller

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread David Vrabel
On 27/04/16 06:02, Juergen Gross wrote: > On 21/04/16 11:30, Stefano Stabellini wrote: >> On Thu, 21 Apr 2016, Juergen Gross wrote: >>> On 20/04/16 15:15, Stefano Stabellini wrote: b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of legacy interrupts when actually

Re: [Xen-devel] [PATCH v2 03/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 10:49, wrote: > On April 25, 2016 5:51 PM, Jan Beulich wrote: >> >>> On 18.04.16 at 16:00, wrote: >> > --- a/xen/arch/x86/mm.c >> > +++ b/xen/arch/x86/mm.c >> > @@ -2467,7 +2467,7 @@ static int __get_page_type(struct page_info >> *page, unsigned long type, >> >

Re: [Xen-devel] [PATCH v2 07/11] IOMMU/MMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} (top level ones).

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 11:08, wrote: > On April 27, 2016 2:32 PM, Jan Beulich wrote: >> >>> On 27.04.16 at 08:21, wrote: >> > @@ -678,8 +682,15 @@ static int xenmem_add_to_physmap(struct >> domain *d, >> > if ( need_iommu(d) ) >> > { > > Check it again. The 'int ret' declaration should

Re: [Xen-devel] [PATCH v2] xen/arm: gicv2: Export GICv2m register frames to domain0 by device tree

2016-04-27 Thread Julien Grall
On 27/04/2016 07:05, Wei Chen wrote: Hi Julien, Hi Wei, On 26 April 2016 at 18:49, Julien Grall wrote: On 25/04/2016 10:39, Wei Chen wrote: + d->domain_id); +return ret; +} + +/* + * Map all SPIs that are allocated to MSIs for the fra

Re: [Xen-devel] [edk2] OVMF broken under Xen (in PCI initialisation)

2016-04-27 Thread Ni, Ruiyu
Gary, Thanks for the try. I now understand why the issue happens. 1. PciEnumeratorLight() depends on the MinBus returned from PciRootBridgeIo.Configuration(). 2. PciRootBridgeIo.Configuration() returns the resource descriptors initialized by PciHostBridge.NotifyPhase(EfiPciHostBridgeAllocateResour

Re: [Xen-devel] [edk2] OVMF broken under Xen (in PCI initialisation)

2016-04-27 Thread Ni, Ruiyu
Copying Mike. Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Wednesday, April 27, 2016 5:49 PM >To: 'Gary Lin' >Cc: edk2-de...@lists.01.org; Xen Devel ; Laszlo Ersek > >Subject: RE: [edk2] OVMF broken under Xen (in PCI initialisation) > >Gary, >Thanks for the try. > >I now und

Re: [Xen-devel] SMMU, Unhandled context fault

2016-04-27 Thread Julien Grall
Hello Peng, On 27/04/2016 03:02, Peng Fan wrote: On Tue, Apr 26, 2016 at 04:30:03PM +0200, Edgar E. Iglesias wrote: On Tue, Apr 26, 2016 at 09:56:33PM +0800, Peng Fan wrote: You mean the PNU bit(Privileged Not Unprivileged) is 1? I did not met Unhandled context fault each time. Actually during

Re: [Xen-devel] [PATCH v2 for-4.7 07/14] libxc: fix uninitialized variable

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 10:57:17AM +0200, Roger Pau Monne wrote: > On Tue, Apr 26, 2016 at 04:16:51PM +0100, Wei Liu wrote: > > On Tue, Apr 26, 2016 at 04:52:16PM +0200, Roger Pau Monne wrote: > > > Signed-off-by: Roger Pau Monné > > > --- > > > Cc: Ian Jackson > > > Cc: Wei Liu > > > --- > > >

Re: [Xen-devel] [PATCH v2 for-4.7 00/14] Fixes for compiling with clang

2016-04-27 Thread Wei Liu
On Tue, Apr 26, 2016 at 12:20:30PM -0500, Doug Goldstein wrote: > On 4/26/16 11:12 AM, Wei Liu wrote: > > On Tue, Apr 26, 2016 at 04:52:09PM +0200, Roger Pau Monne wrote: > >> Hello, > >> > >> This is a set of bug fixes for compiling both the hypervisor and the > >> toolstack with clang. I've only

Re: [Xen-devel] [for-4.7] xen/arm: Force broadcast of TLB and instruction cache maintenance instructions

2016-04-27 Thread Julien Grall
Hi Stefano, On 26/04/2016 10:45, Stefano Stabellini wrote: On Mon, 25 Apr 2016, Julien Grall wrote: On 25/04/16 11:45, Stefano Stabellini wrote: On Mon, 18 Apr 2016, Julien Grall wrote: UP guest usually uses TLB instruction to flush only on the local CPU. The TLB flush won't be broadcasted ac

[Xen-devel] [xen-4.3-testing test] 92922: trouble: blocked/broken/fail/pass

2016-04-27 Thread osstest service owner
flight 92922 xen-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/92922/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 3 host-install(3) broken REGR. vs. 878

Re: [Xen-devel] [edk2] OVMF broken under Xen (in PCI initialisation)

2016-04-27 Thread Laszlo Ersek
On 04/27/16 11:50, Ni, Ruiyu wrote: > Copying Mike. > > Regards, > Ray > >> -Original Message- >> From: Ni, Ruiyu >> Sent: Wednesday, April 27, 2016 5:49 PM >> To: 'Gary Lin' >> Cc: edk2-de...@lists.01.org; Xen Devel ; Laszlo >> Ersek >> Subject: RE: [edk2] OVMF broken under Xen (in PC

Re: [Xen-devel] [RFC] Minor change to governance document at http://www.xenproject.org/developers/governance.html

2016-04-27 Thread George Dunlap
On 26/04/16 12:48, Lars Kurth wrote: > Hi all, > > following the recent process to elect new maintainers and committers, > I would like to suggest the following minor change to our governance > document. I believe the process we ran recently worked well, so we > should change the governance acc

[Xen-devel] Questions about the new usb hotplug code in libxl and about adding hotplug (with qmp) usbredir tcp channels

2016-04-27 Thread Fabio Fantoni
Hi, I took a look at the new pvusb hotplug code in libxl to try to add also hotplug (with qmp) usbredir tcp channels. Adding usbredir tcp channels at domU start requires for example adding qemu parameters like these: "-chardev socket,id=charredir4,host=192.168.1.35,port=4 -device usb-redir,

[Xen-devel] [PATCH v3 for-4.7 01/16] build: make HOSTCC conditional on the value of clang

2016-04-27 Thread Roger Pau Monne
Previously HOSTCC was always hardcoded to gcc Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper Reviewed-by: Doug Goldstein --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- Changes since v1: - Use ?= instead of = --- Config.mk | 3 ++- 1 file changed, 2 inser

[Xen-devel] [PATCH v3 for-4.7 03/16] build: pass HOST{CC/CXX} value down to Kconfig

2016-04-27 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné Acked-by: Ian Jackson Reviewed-by: Andrew Cooper Reviewed-by: Doug Goldstein --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/Makefile b/xen/Makef

[Xen-devel] [PATCH v3 for-4.7 02/16] build: set HOSTCXX based on clang value for Kconfig xconfig target

2016-04-27 Thread Roger Pau Monne
The xconfig Kconfig target requires a C++ compiler because it uses Qt. Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper Reviewed-by: Doug Goldstein --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- Config.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Xen-devel] [PATCH v3 for-4.7 12/16] libxl: add explicit casts from yajl_gen_status to yajl_status

2016-04-27 Thread Roger Pau Monne
Or else clang complains with: implicit conversion from enumeration type 'yajl_gen_status' to different enumeration type 'yajl_status' [-Werror,-Wenum-conversion] Signed-off-by: Roger Pau Monné Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_json.c | 29 +++

[Xen-devel] [PATCH v3 for-4.7 04/16] build: remove Kconfig forced gcc selection

2016-04-27 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné Acked-by: Doug Goldstein Reviewed-by: Andrew Cooper --- Cc: Doug Goldstein --- xen/tools/kconfig/Makefile.kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/tools/kconfig/Makefile.kconfig b/xen/tools/kconfig/Makefile.kconfig inde

[Xen-devel] [PATCH v3 for-4.7 05/16] tools/headers: prevent adding two __align8__ to uint64_t in ARM headers

2016-04-27 Thread Roger Pau Monne
Due to the fact that on ARM headers types are substituted to uint64_t and then uint64_t is also substituted to contain the aligment, this would lead to some types containing two __align8__ directives. Fix this by first expanding Xen specific types to uint64_t only, and then replacing all the uint64

[Xen-devel] [PATCH v3 for-4.7 11/16] libxl: convert libxl__device_model_xs_path to a macro

2016-04-27 Thread Roger Pau Monne
Since it's unsafe to code it as a function because it would end up passing a non literal string to a printf like function. Signed-off-by: Roger Pau Monné --- Cc: Wei Liu Cc: Ian Jackson --- Changes since v2: - Split the libxl__device_model_xs_path convert to a separate patch. - s/libxl__devic

[Xen-devel] [PATCH v3 for-4.7 00/16] Fixes for compiling with clang

2016-04-27 Thread Roger Pau Monne
Hello, This is a set of bug fixes for compiling both the hypervisor and the toolstack with clang. I've only tested it with clang 3.8.0 from base FreeBSD, so I'm not sure if it's going to work with _all_ clang versions, but should be better than nothing. AFAICT, most of the issues that clang fo

[Xen-devel] [PATCH v3 for-4.7 15/16] tools/python: corrently use LDFLAGS and CFLAGS

2016-04-27 Thread Roger Pau Monne
It is incorrect to add the LDFLAGS to the CFLAGS, and some compilers will error out if linker flags are passed when creating object files. Fix this by properly passing CFLAGS and LDFLAGS, instead of putting everything in CFLAGS. Signed-off-by: Roger Pau Monné Reviewed-by: Doug Goldstein Acked-by

[Xen-devel] [PATCH v3 for-4.7 16/16] tools/pygrub: fix usage of LDFLAGS

2016-04-27 Thread Roger Pau Monne
LDFLAGS cannot be appended to CFLAGS, instead pass them down as env variables. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/pygrub/Makefile | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile index

[Xen-devel] [PATCH v3 for-4.7 07/16] libxc: fix usage of uninitialized variable

2016-04-27 Thread Roger Pau Monne
*size should be used instead, because it contains the size of the buffer in out_buf. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- Changes since v2: - Use *size instead of 0, because it will contain the actual size of the out_buf buffer. --- tools/libxc/xc_dom_bzimagel

[Xen-devel] [PATCH v3 for-4.7 13/16] libxl: fix passing the type argument to xc_psr_*

2016-04-27 Thread Roger Pau Monne
The xc_psr_* functions expect the type to be xc_psr_cat_type instead of libxl_psr_cbm_type, so do the conversion. Signed-off-by: Roger Pau Monné Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_psr.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --g

[Xen-devel] [PATCH v3 for-4.7 08/16] libxl: fix shutdown_reason type in list_domains

2016-04-27 Thread Roger Pau Monne
It should be an enum, not an unsigned. Signed-off-by: Roger Pau Monné Acked-by: Wei Liu Reviewed-by: Doug Goldstein --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/xl_cmdimpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdim

[Xen-devel] [PATCH v3 for-4.7 14/16] oxenstored: fix error when shifting negative value

2016-04-27 Thread Roger Pau Monne
By explicitly casting it to unsigned. Reasoning on why this is needed, provided by Andrew Cooper: "Ocaml stores integers shifted left by one, and with the bottom bit set. Values with the bottom bit clear are pointers into the GC'd heap. Values with the bottom bit set are integers, and need to be

[Xen-devel] [PATCH v3 for-4.7 10/16] libxl: add the printf-like attributes to a couple of functions

2016-04-27 Thread Roger Pau Monne
Or else clang complains with: error: format string is not a string literal Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_internal.h| 4 ++-- tools/libxl/libxl_save_helper.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/l

[Xen-devel] [PATCH v3 for-4.7 09/16] xl: fix usage of libxl_get_scheduler

2016-04-27 Thread Roger Pau Monne
It returns an int, not a libxl_scheduler. Signed-off-by: Roger Pau Monné Reviewed-by: Doug Goldstein --- Cc: Ian Jackson Cc: Wei Liu --- Changes since v2: - s/sched_rc/rc/ --- tools/libxl/xl_cmdimpl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/libxl/xl

[Xen-devel] [PATCH v3 for-4.7 06/16] xen/tools: fix substitution of __align8__ uint64_t inside of headers

2016-04-27 Thread Roger Pau Monne
The current seedery doesn't work with BSD sed, so remove the try to match int64_t also (since there's none at the moment). Also, apply the same treatment to all arch headers, currently this is only done to x86_64 headers. Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper Acked-by: Wei Li

[Xen-devel] [distros-debian-squeeze test] 44367: tolerable trouble: broken/fail/pass

2016-04-27 Thread Platform Team regression test user
flight 44367 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/44367/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-armhf-pvops 3 host-install(3) broken like 44347 build-armhf

Re: [Xen-devel] [PATCH v3 for-4.7 07/16] libxc: fix usage of uninitialized variable

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 01:11:45PM +0200, Roger Pau Monne wrote: > *size should be used instead, because it contains the size of the buffer in > out_buf. > > Signed-off-by: Roger Pau Monné Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.

Re: [Xen-devel] [PATCH v3 for-4.7 09/16] xl: fix usage of libxl_get_scheduler

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 01:11:47PM +0200, Roger Pau Monne wrote: > It returns an int, not a libxl_scheduler. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Doug Goldstein Acked-by: Wei Liu > --- > Cc: Ian Jackson > Cc: Wei Liu > --- > Changes since v2: > - s/sched_rc/rc/ > --- > tools/

[Xen-devel] [for-4.7 v2] xen/arm: Force broadcast of TLB and instruction cache maintenance instructions

2016-04-27 Thread Julien Grall
UP guest may use TLB instructions to flush only on the local CPU. Therefore, TLB flush will not be broadcasted across all the CPUs within the same innershareable domain. When the vCPU is migrated between different CPUs, it may be rescheduled to a previous CPU where the TLB has not been flushed. Th

Re: [Xen-devel] [PATCH v3 for-4.7 11/16] libxl: convert libxl__device_model_xs_path to a macro

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 01:11:49PM +0200, Roger Pau Monne wrote: > Since it's unsafe to code it as a function because it would end up passing a > non literal string to a printf like function. > > Signed-off-by: Roger Pau Monné Acked-by: Wei Liu ___ X

Re: [Xen-devel] [PATCH v3 for-4.7 10/16] libxl: add the printf-like attributes to a couple of functions

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 01:11:48PM +0200, Roger Pau Monne wrote: > Or else clang complains with: > > error: format string is not a string literal > > Signed-off-by: Roger Pau Monné Acked-by: Wei Liu > --- > Cc: Ian Jackson > Cc: Wei Liu > --- > tools/libxl/libxl_internal.h| 4 ++-- > t

Re: [Xen-devel] [PATCH v3 for-4.7 14/16] oxenstored: fix error when shifting negative value

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 01:11:52PM +0200, Roger Pau Monne wrote: > By explicitly casting it to unsigned. > > Reasoning on why this is needed, provided by Andrew Cooper: > > "Ocaml stores integers shifted left by one, and with the bottom bit set. > > Values with the bottom bit clear are pointers

Re: [Xen-devel] [PATCH v3 for-4.7 16/16] tools/pygrub: fix usage of LDFLAGS

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 01:11:54PM +0200, Roger Pau Monne wrote: > LDFLAGS cannot be appended to CFLAGS, instead pass them down as env > variables. > > Signed-off-by: Roger Pau Monné Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.or

Re: [Xen-devel] Questions about the new usb hotplug code in libxl and about adding hotplug (with qmp) usbredir tcp channels

2016-04-27 Thread George Dunlap
On 27/04/16 12:02, Fabio Fantoni wrote: > Hi, I took a look at the new pvusb hotplug code in libxl to try to add > also hotplug (with qmp) usbredir tcp channels. > Adding usbredir tcp channels at domU start requires for example adding > qemu parameters like these: "-chardev > socket,id=charredir4,h

Re: [Xen-devel] [for-4.7 v2] xen/arm: Force broadcast of TLB and instruction cache maintenance instructions

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 12:22:53PM +0100, Julien Grall wrote: > UP guest may use TLB instructions to flush only on the local CPU. > Therefore, TLB flush will not be broadcasted across all the CPUs within > the same innershareable domain. > > When the vCPU is migrated between different CPUs, it may

Re: [Xen-devel] [PATCH] MAINTAINERS: Clarify the meaning of nested maintainership

2016-04-27 Thread George Dunlap
On 26/04/16 17:57, Lars Kurth wrote: > > > On 26/04/2016 17:19, "George Dunlap" wrote: > >> On 21/04/16 17:59, Lars Kurth wrote: >>> >>> >>> On 21/04/2016 17:03, "George Dunlap" wrote: >>> Clarify the meaning of nested maintainership. Signed-off-by: George Dunlap ---

[Xen-devel] [linux-mingo-tip-master test] 92920: regressions - FAIL

2016-04-27 Thread osstest service owner
flight 92920 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/92920/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen6 xen-build fail REGR. vs. 60684 build-amd6

[Xen-devel] [xen-unstable-coverity test] 92952: all pass - PUSHED

2016-04-27 Thread osstest service owner
flight 92952 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/92952/ Perfect :-) All tests in this flight passed version targeted for testing: xen 9772c480a71ad38cc2c342e4c2e78c2475de7268 baseline version: xen e0ec0a717d882ff0c0

Re: [Xen-devel] Should we mark RTDS as supported feature from experimental feature?

2016-04-27 Thread Dario Faggioli
On Tue, 2016-04-26 at 21:16 -0400, Meng Xu wrote: > > It's indeed not a must for real-time schedulers. In fact, it's only > > important if one wants the system to be overall usable, when using > > a > > real-time scheduler. :-P > > > > Also, I may be wrong but it should not be too hard to implemen

Re: [Xen-devel] [PATCH v2 03/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping

2016-04-27 Thread Xu, Quan
On April 27, 2016 5:37 PM, Jan Beulich wrote: > >>> On 27.04.16 at 10:49, wrote: > > On April 25, 2016 5:51 PM, Jan Beulich wrote: > >> >>> On 18.04.16 at 16:00, wrote: > >> > --- a/xen/arch/x86/mm.c > >> > +++ b/xen/arch/x86/mm.c > >> > @@ -2467,7 +2467,7 @@ static int __get_page_type(struct p

Re: [Xen-devel] Xen 4.7 Headline Features (for PR)

2016-04-27 Thread Lars Kurth
> On 24 Apr 2016, at 02:06, Doug Goldstein wrote: > > On 4/22/16 9:25 AM, George Dunlap wrote: >> On Fri, Apr 22, 2016 at 3:22 PM, Lars Kurth wrote: >>> On 22 Apr 2016, at 15:08, George Dunlap wrote: kconfig for the hypervisor >>> >>> This is one which potentially has a

Re: [Xen-devel] [PATCH v3 for-4.7 07/16] libxc: fix usage of uninitialized variable

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 01:11:45PM +0200, Roger Pau Monne wrote: > *size should be used instead, because it contains the size of the buffer in > out_buf. > > Signed-off-by: Roger Pau Monné > --- > Cc: Ian Jackson > Cc: Wei Liu > --- > Changes since v2: > - Use *size instead of 0, because it wi

Re: [Xen-devel] [PATCH v3 for-4.7 00/16] Fixes for compiling with clang

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 01:11:38PM +0200, Roger Pau Monne wrote: > Hello, > > This is a set of bug fixes for compiling both the hypervisor and the > toolstack with clang. I've only tested it with clang 3.8.0 from base > FreeBSD, so I'm not sure if it's going to work with _all_ clang versions, >

[Xen-devel] [xen-unstable baseline-only test] 44366: tolerable FAIL

2016-04-27 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 44366 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/44366/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-xsm 20 guest-start.2

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread Boris Ostrovsky
On 04/27/2016 05:35 AM, David Vrabel wrote: On 27/04/16 06:02, Juergen Gross wrote: On 21/04/16 11:30, Stefano Stabellini wrote: On Thu, 21 Apr 2016, Juergen Gross wrote: On 20/04/16 15:15, Stefano Stabellini wrote: b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of l

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread David Vrabel
On 27/04/16 14:38, Boris Ostrovsky wrote: > > int xen_nr_legacy_irqs() > { > if (xen_hvm_domain()) > return nr_legacy_irqs(); > if (xen_initial_domain()) > return NR_IRQS_LEGACY; > return 0; > } Yeah, if that does the right thing... David

Re: [Xen-devel] xen/arm: Assertion 'timer->status >= TIMER_STATUS_inactive' failed at timer.c:279

2016-04-27 Thread George Dunlap
On 26/04/16 18:49, Dario Faggioli wrote: > On Tue, 2016-04-26 at 15:25 +0100, Julien Grall wrote: >> Hi Dario, >> > Hi, > >> A couple of people have been reported Xen crash on the ARM64 >> Foundation Model [1] with recent unstable. >> > Ok, thanks for reporting. > >> The crash seems to happen whe

Re: [Xen-devel] [PATCH v9 08/27] arm/x86/vmap: Add v[z|m]alloc_xen and vm_init_type

2016-04-27 Thread Konrad Rzeszutek Wilk
On Wed, Apr 27, 2016 at 01:12:24AM -0600, Jan Beulich wrote: > >>> On 27.04.16 at 04:38, wrote: > >> With vm_alloc() getting removed, vm_free() should get removed > >> here too. And with that, vm_alloc_type() and vm_free_type() can > >> then just become vm_alloc() and vm_free() respectively (as s

Re: [Xen-devel] [PATCH v9 04/27] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op

2016-04-27 Thread Konrad Rzeszutek Wilk
On Wed, Apr 27, 2016 at 12:51:34AM -0600, Jan Beulich wrote: > >>> On 26.04.16 at 19:50, wrote: > > On Tue, Apr 26, 2016 at 04:21:10AM -0600, Jan Beulich wrote: > >> >>> On 25.04.16 at 17:34, wrote: > >> > The implementation does not actually do any patching. > >> > > >> > It just adds the frame

Re: [Xen-devel] [PATCH V6] vm_event: Allow subscribing to write events for specific MSR-s

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 10:48:04AM +0300, Razvan Cojocaru wrote: > Previously, subscribing to MSR write events was an all-or-none > approach, with special cases for introspection MSR-s. This patch > allows the vm_event consumer to specify exactly what MSR-s it is > interested in, and as a side-effe

Re: [Xen-devel] [PATCH v9 10/27] xsplice: Add helper elf routines

2016-04-27 Thread Konrad Rzeszutek Wilk
On Wed, Apr 27, 2016 at 01:27:05AM -0600, Jan Beulich wrote: > >>> On 27.04.16 at 03:59, wrote: > >> > +static int xsplice_header_check(const struct xsplice_elf *elf) > >> > +{ > >> > +const Elf_Ehdr *hdr = elf->hdr; > >> > + > >> > +if ( sizeof(*elf->hdr) > elf->len ) > >> > +{ > >> >

Re: [Xen-devel] [PATCH v2 03/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 15:10, wrote: > Then this code is: > > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -2467,7 +2467,7 @@ static int __get_page_type(struct page_info *page, > unsigned long type, > int preemptible) > { > unsigned long nx, x, y = page->u

Re: [Xen-devel] xen/arm: Assertion 'timer->status >= TIMER_STATUS_inactive' failed at timer.c:279

2016-04-27 Thread Dario Faggioli
On Wed, 2016-04-27 at 14:43 +0100, George Dunlap wrote: > On 26/04/16 18:49, Dario Faggioli wrote: > >  > > Let me know, and I'll resubmit the patch properly (together with > > another bugfix I have in my queue). > Yeah, assuming the description in your changeset is accurate, this > seems > like th

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread Boris Ostrovsky
On 04/27/2016 09:40 AM, David Vrabel wrote: On 27/04/16 14:38, Boris Ostrovsky wrote: int xen_nr_legacy_irqs() { if (xen_hvm_domain()) return nr_legacy_irqs(); if (xen_initial_domain()) return NR_IRQS_LEGACY; return 0; } Yeah, if that does the right thing... I

Re: [Xen-devel] [PATCH v12 1/2] libxl: add support for vscsi

2016-04-27 Thread Wei Liu
AIUI Ian and you talked about vscsi during hackathon so I'm expecting a new version of this feature from you. I've skipped this version for now. Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v9 04/27] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 15:47, wrote: > On Wed, Apr 27, 2016 at 12:51:34AM -0600, Jan Beulich wrote: >> >>> On 26.04.16 at 19:50, wrote: >> > On Tue, Apr 26, 2016 at 04:21:10AM -0600, Jan Beulich wrote: >> >> I also wonder whether the code wouldn't be easier to read if you >> >> used just a sequence o

Re: [Xen-devel] [PATCH v3 1/3] x86/ioreq server(patch for 4.7): Rename p2m_mmio_write_dm to p2m_ioreq_server.

2016-04-27 Thread George Dunlap
On Mon, Apr 25, 2016 at 6:01 PM, Paul Durrant wrote: > For clarity, do you expect any existing use of HVMMEM_mmio_write_dm to > continue to *function*? I agree that things should continue to build, but if > they don't need to function then the now redundant p2m type should be removed > IMO and

Re: [Xen-devel] [PATCH v12 1/2] libxl: add support for vscsi

2016-04-27 Thread Olaf Hering
On Wed, Apr 27, Wei Liu wrote: > AIUI Ian and you talked about vscsi during hackathon so I'm expecting a > new version of this feature from you. I've skipped this version for now. Yes, the outcome was to have a 'pdev' in idl, instead the union hctl/wwn. The hctl/wwn part is supposed to be generat

Re: [Xen-devel] [PATCH v9 08/27] arm/x86/vmap: Add v[z|m]alloc_xen and vm_init_type

2016-04-27 Thread Jan Beulich
>>> On 27.04.16 at 15:46, wrote: > Then this should be perfect: Almost. > From cef95bc0682f94ca5e61609211c4787491212acf Mon Sep 17 00:00:00 2001 > From: Konrad Rzeszutek Wilk > Date: Tue, 26 Apr 2016 14:03:06 -0400 > Subject: [PATCH] arm/x86/vmap: Add vmalloc_xen and vm_init_type > > For those

Re: [Xen-devel] [PATCH] add info to p2m_pod_dump_data

2016-04-27 Thread George Dunlap
On 26/04/16 05:11, zhangcy wrote: > just for debug. > 'xl debug-key q' do not dump d->tot_pages, > so it hard to understand p2m_pod_set_mem_target. debug-key 'q' calls dump_domains, which prints d->tot_pages under the label "nr_pages". I admit this isn't very clear -- what about s/nr_pages/tot_pa

Re: [Xen-devel] [PATCH] add info to p2m_pod_dump_data

2016-04-27 Thread George Dunlap
On 26/04/16 05:11, zhangcy wrote: > just for debug. > 'xl debug-key q' do not dump d->tot_pages, > so it hard to understand p2m_pod_set_mem_target. > > Signed-off-by: zhangcy Also, the SoB is a legal statement, so in future patches you should change "zhangcy" to something which resembles your ac

Re: [Xen-devel] [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

2016-04-27 Thread Xu, Quan
On April 25, 2016 5:27 PM, Jan Beulich wrote: > >>> On 18.04.16 at 16:00, wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -243,21 +243,33 @@ int iommu_map_page(struct domain *d, > unsigned long gfn, unsigned long mfn, > > unsig

Re: [Xen-devel] [PATCH v3 6/7] libxl: Fix libxl_set_memory_target return value

2016-04-27 Thread Wei Liu
On Wed, Apr 20, 2016 at 10:04:03AM +0200, Paulina Szubarczyk wrote: > libxl_set_memory_target seems to have the following return values: > > * 1 on failure, if the failure happens because of a xenstore error *or* > * invalid target > > * -1 if the setmaxmem hypercall If the setmaxmem hypercall f

Re: [Xen-devel] [PATCH v3 7/7] libxl: libxl_tmem functions improving coding style

2016-04-27 Thread Wei Liu
On Wed, Apr 20, 2016 at 11:04:06PM +0200, Olaf Hering wrote: > On Wed, Apr 20, Paulina Szubarczyk wrote: > > > In accordance with CODING_SYTLE: > > - Use 'r' for return values to functions whose return values are a > >different error space (like xc_tmem_control, xc_tmem_auth) > > > > libxc f

Re: [Xen-devel] [PATCH v3 5/7] xl: improve main_tmem_* return codes

2016-04-27 Thread Wei Liu
On Wed, Apr 20, 2016 at 10:04:02AM +0200, Paulina Szubarczyk wrote: > Functions libxl_tmem_freeze(), libxl_tmem_thaw(), libxl_tmem_set() and > libxl_tmem_shared_auth() located in libxl.c file return > ERROR_FAIL/ERROR_INVAL or internal error codes from libxc library > improve main_tmem_* return cod

Re: [Xen-devel] xen/arm: Assertion 'timer->status >= TIMER_STATUS_inactive' failed at timer.c:279

2016-04-27 Thread George Dunlap
On 27/04/16 15:05, Dario Faggioli wrote: > On Wed, 2016-04-27 at 14:43 +0100, George Dunlap wrote: >> On 26/04/16 18:49, Dario Faggioli wrote: >>> >>> Let me know, and I'll resubmit the patch properly (together with >>> another bugfix I have in my queue). >> Yeah, assuming the description in your

Re: [Xen-devel] [PATCH v3 4/7] xl_cmdimpl - Add return codes for pci-detach, pci-attach, pci-asssignable-add, and pci-assignable-remove.

2016-04-27 Thread Wei Liu
On Wed, Apr 20, 2016 at 10:04:01AM +0200, Paulina Szubarczyk wrote: > Returning error codes makes it easier for shell scripts to tell if a > command has failed or succeeded. > > Signed-off-by: George Dunlap > Signed-off-by: Paulina Szubarczyk Acked-by: Wei Liu

Re: [Xen-devel] [PATCH v3 1/7] libxl: improve return codes for some pci related functions

2016-04-27 Thread Wei Liu
Apart from what Oalf already said, I have one minor below. On Wed, Apr 20, 2016 at 10:03:58AM +0200, Paulina Szubarczyk wrote: > *libxl__device_from_pcidev() initialize the values of libxl__device > struct and can be void. > > *libxl__create_pci_backend(), libxl__device_pci_destroy_all() > shou

Re: [Xen-devel] [PATCH v3 00/10] xl: improve coding style and return more failure on

2016-04-27 Thread Wei Liu
Hi Paulina Sorry for the late reply. Now I finally have time to go over your series. All in all it is in very good shape. Feel free to ask questions if my comment is not clear. You can resubmit this series when you get around to fix the issues. Note that we're in code freeze now so this series wi

Re: [Xen-devel] [PATCH v3 1/3] x86/ioreq server(patch for 4.7): Rename p2m_mmio_write_dm to p2m_ioreq_server.

2016-04-27 Thread Paul Durrant
> -Original Message- > From: George Dunlap > Sent: 27 April 2016 15:13 > To: Paul Durrant > Cc: Yu, Zhang; Jan Beulich; Kevin Tian; Wei Liu; Andrew Cooper; Tim > (Xen.org); xen-devel@lists.xen.org; Zhiyuan Lv; Jun Nakajima; Keir (Xen.org) > Subject: Re: [Xen-devel] [PATCH v3 1/3] x86/ioreq

Re: [Xen-devel] [PATCH v3 1/3] x86/ioreq server(patch for 4.7): Rename p2m_mmio_write_dm to p2m_ioreq_server.

2016-04-27 Thread Wei Liu
On Wed, Apr 27, 2016 at 03:12:46PM +0100, George Dunlap wrote: > On Mon, Apr 25, 2016 at 6:01 PM, Paul Durrant wrote: > > For clarity, do you expect any existing use of HVMMEM_mmio_write_dm to > > continue to *function*? I agree that things should continue to build, but > > if they don't need to

  1   2   3   >