[Xen-devel] [xen-unstable-smoke test] 88647: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88647 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/88647/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build fail REGR. vs. 88144 build-armhf

Re: [Xen-devel] HPA <-> GPA mapping

2016-04-04 Thread Jan Beulich
>>> On 04.04.16 at 10:04, wrote: > Does Xen under any circumstances ever modify GPA -> HPA translations > _while_ a HVM guest is running? I could find no cases where that would > happen, but I would appreciate an authoritative answer. Of course we do, namely when asked to by the guest itself (see

Re: [Xen-devel] Getting rid of inside_vm in intel8x0

2016-04-04 Thread George Dunlap
On 02/04/16 13:57, Andy Lutomirski wrote: > On Fri, Apr 1, 2016 at 10:33 PM, Takashi Iwai wrote: >> On Sat, 02 Apr 2016 00:28:31 +0200, >> Luis R. Rodriguez wrote: >>> If the former, could a we somehow detect an emulated device other than >>> through >>> this type of check ? Or could we *add* a c

[Xen-devel] [linux-linus test] 88539: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88539 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/88539/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen6 xen-build fail REGR. vs. 59254 test-amd64-amd64-xl-c

Re: [Xen-devel] xen-utils not running within xen or no compatible utils

2016-04-04 Thread Wei Liu
On Sun, Apr 03, 2016 at 02:38:41PM +0200, aicha hamza wrote: > but how can i prebuild the image from somewhere !! > Try using Debian debootstrap? I don't normally use xen-tools or Xen on ARM so I don't really have good recommendations. Maybe also search wiki.xenproject.org to see if there is any

Re: [Xen-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483

2016-04-04 Thread Wei Liu
On Fri, Apr 01, 2016 at 08:26:16PM +0200, Samuel Thibault wrote: > 7c8f3483 introduced a break within a loop in netfront.c such that > cons and nr_consumed were no longer always being incremented. The > offset at cons will be processed multiple times with the break in > place. > > This commit reve

Re: [Xen-devel] [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

2016-04-04 Thread Wei Liu
On Sat, Apr 02, 2016 at 01:24:07PM +0200, Sjoer van der Ploeg wrote: > Well if you install ocaml-nox oxenstored is made default, so I tested both > situations this morning with and without ocaml. That location is not > causing the problem, as it happened without ocaml too. The install path for > oc

Re: [Xen-devel] [PATCH 03/16] xen: sched: make implementing .alloc_pdata optional

2016-04-04 Thread Jan Beulich
>>> On 01.04.16 at 19:01, wrote: > On Mon, 2016-03-21 at 09:07 -0600, Jan Beulich wrote: >> > > > On 21.03.16 at 15:48, wrote: >> > On 18/03/16 20:04, Dario Faggioli wrote: >> > > @@ -1491,9 +1491,9 @@ static int cpu_schedule_up(unsigned int >> > > cpu) >> > > if ( idle_vcpu[cpu] == NULL ) >

[Xen-devel] [linux-4.1 test] 88510: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88510 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/88510/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 3 host-install(3) broken in 87395 REGR. vs. 66399 build-amd64-rumpuserxen

Re: [Xen-devel] xen-utils not running within xen or no compatible utils

2016-04-04 Thread aicha hamza
what you mean by using debian debootstrap !! how can i work with it ! On Mon, Apr 4, 2016 at 12:27 PM, Wei Liu wrote: > On Sun, Apr 03, 2016 at 02:38:41PM +0200, aicha hamza wrote: > > but how can i prebuild the image from somewhere !! > > > > Try using Debian debootstrap? I don't normally use x

[Xen-devel] [GIT PULL] xen: regression and bug fixes for 4.6-rc2

2016-04-04 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.6-rc2-tag xen: regression and bug fixes for 4.6-rc2 - - Safely migrate event channels between CPUs. - - Fix CPU hotplug. - - Maintain

[Xen-devel] HPA <-> GPA mapping

2016-04-04 Thread Razvan Cojocaru
Hello, Does Xen under any circumstances ever modify GPA -> HPA translations _while_ a HVM guest is running? I could find no cases where that would happen, but I would appreciate an authoritative answer. Thanks, Razvan ___ Xen-devel mailing list Xen-de

Re: [Xen-devel] xen-utils not running within xen or no compatible utils

2016-04-04 Thread Wei Liu
On Mon, Apr 04, 2016 at 12:40:30PM +0200, aicha hamza wrote: > what you mean by using debian debootstrap !! how can i work with it ! > http://lmgtfy.com/?q=debian+debootstrap Google is your friend. :-) And please read http://wiki.xenproject.org/wiki/Asking_Developer_Questions Wei. > On Mon,

Re: [Xen-devel] [PATCH] xen: write information about supported backends

2016-04-04 Thread David Vrabel
On 30/03/16 15:10, Juergen Gross wrote: > Add a Xenstore directory for each supported pv backend. This will allow > Xen tools to decide which backend type to use in case there are > multiple possibilities. > > The information is added under > /local/domain//device-model//backends > before the "run

Re: [Xen-devel] [PATCH] libxl: fix compilation on ARM

2016-04-04 Thread Ian Jackson
Wei Liu writes ("[PATCH] libxl: fix compilation on ARM"): > COLO introduced a few callbacks. The original implementation used > unsigned long for a type which in fact should be xen_pfn_t. That broke > libxl compilation on ARM, because xen_pfn_t is not a synonym for > unsigned long on ARM platform.

Re: [Xen-devel] [PATCH] xen: write information about supported backends

2016-04-04 Thread Juergen Gross
On 04/04/16 11:18, David Vrabel wrote: > On 30/03/16 15:10, Juergen Gross wrote: >> Add a Xenstore directory for each supported pv backend. This will allow >> Xen tools to decide which backend type to use in case there are >> multiple possibilities. >> >> The information is added under >> /local/do

Re: [Xen-devel] [PATCH] libxl: fix compilation on ARM

2016-04-04 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH] libxl: fix compilation on ARM"): > Following discussion on irc, here is a v2: I forgot to update the commit message. Ian. From 4cbc583020642d6c333d07e297c52594bb88b542 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Mon, 4 Apr 2016 11:41:19 +0100 Subject: [PATC

Re: [Xen-devel] [PATCH] libxl: fix compilation on ARM

2016-04-04 Thread Wei Liu
On Mon, Apr 04, 2016 at 11:48:59AM +0100, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH] libxl: fix compilation on ARM"): > > Following discussion on irc, here is a v2: > > I forgot to update the commit message. > > Ian. > > From 4cbc583020642d6c333d07e297c52594bb88b542 Mon Sep 17 00:00:0

Re: [Xen-devel] [PATCH] libxl: fix compilation on ARM

2016-04-04 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: fix compilation on ARM"): > Acked-by: Wei Liu Thanks, pushed. Hopefully this will unblock the smoke test. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Getting rid of inside_vm in intel8x0

2016-04-04 Thread Takashi Iwai
On Mon, 04 Apr 2016 11:05:43 +0200, George Dunlap wrote: > > On 02/04/16 13:57, Andy Lutomirski wrote: > > On Fri, Apr 1, 2016 at 10:33 PM, Takashi Iwai wrote: > >> On Sat, 02 Apr 2016 00:28:31 +0200, > >> Luis R. Rodriguez wrote: > >>> If the former, could a we somehow detect an emulated device

Re: [Xen-devel] P2M aliasing check

2016-04-04 Thread Jan Beulich
>>> On 01.04.16 at 19:18, wrote: > While trying to get hotplug scripts to work on FreeBSD, I've realized that > there's a check in the P2M code that prevents having multiple gfn pointing > to the same mfn. The check in question is performed at > guest_physmap_add_entry, and it means that the ex

[Xen-devel] [PATCH] unmodified_drivers: enable use of register_oldmem_pfn_is_ram() API

2016-04-04 Thread Jan Beulich
From: Mike Meyer During the investigation of very slow dump times of guest images in Amazon EC2 instance, it was discovered that the register_oldmem_pfn_is_ram() API implemented by the upstream kernel commit 997c136f518c5debd63847e78e2a8694f56dcf90: fs/proc/vmcore.c: add hook to read_fro

Re: [Xen-devel] [PATCH v5 11/28] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-04 Thread Jan Beulich
>>> On 01.04.16 at 23:04, wrote: > On Fri, Apr 01, 2016 at 07:28:00AM -0600, Jan Beulich wrote: >> >>> On 24.03.16 at 21:00, wrote: >> > From: Ross Lagerwall >> > >> > Implement support for the apply, revert and replace actions. >> > >> > To perform and action on a payload, the hypercall sets

[Xen-devel] [ovmf test] 88546: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88546 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/88546/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 65543 test-amd64-amd64-xl-qemuu-ov

[Xen-devel] [PATCH] x86/HVM: remove dead code

2016-04-04 Thread Jan Beulich
With commit 96ae556569 ("x86/HVM: fix forwarding of internally cached requests") rc doesn't change anymore in the respective preceding switch() statements. Coverity ID: 1358080 Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -151,8 +151,6 @@ in

[Xen-devel] [xen-unstable-smoke test] 88629: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88629 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/88629/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build fail REGR. vs. 88144 build-armhf

Re: [Xen-devel] [PATCH] unmodified_drivers: enable use of register_oldmem_pfn_is_ram() API

2016-04-04 Thread Olaf Hering
On Mon, Apr 04, Jan Beulich wrote: > From: Mike Meyer > > During the investigation of very slow dump times of guest images in > Amazon EC2 instance, it was discovered that the > register_oldmem_pfn_is_ram() API implemented by the upstream kernel > commit 997c136f518c5debd63847e78e2a8694f56dcf90:

Re: [Xen-devel] [PATCH] Fixed --enable-systemd on latest Debian stretch. Added xencommons as a systemd.service.

2016-04-04 Thread Wei Liu
Add back xen-devel On Mon, Apr 04, 2016 at 01:28:03PM +0200, Sjoer van der Ploeg wrote: > Ocaml search path was set to /usr/local > > I haven't had the time to check why xendomains fails, I've got a few > deadlines for school to finish before Friday. > No worries. Your deadlines are more import

Re: [Xen-devel] [PATCH 05/10] xl_cmdimpl: improve return codes for memset commands

2016-04-04 Thread George Dunlap
On 01/04/16 15:33, Roger Pau Monné wrote: > On Fri, 1 Apr 2016, Paulina Szubarczyk wrote: > >> - Use EXIT_{SUCCESS,FAILURE} for main_mem*() function >> - Use 0/1 as return values of set_memory_{max,target} >> >> Signed-off-by: Paulina Szubarczyk >> --- >> tools/libxl/xl_cmdimpl.c | 24

Re: [Xen-devel] [PATCH 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-04 Thread George Dunlap
On 01/04/16 15:55, Roger Pau Monné wrote: > On Fri, 1 Apr 2016, Paulina Szubarczyk wrote: >> libxl_set_memory_target seems to have the following return values: >> >> * 1 on failure, if the failure happens because of a xenstore error *or* >> * invalid >> target > > AFAICT it seems like you haven't

Re: [Xen-devel] [PATCH v5 3/9] x86/head: Move early exception panic code into early_fixup_exception

2016-04-04 Thread Jan Kara
On Sat 02-04-16 13:58:19, Andy Lutomirski wrote: > [cc Jan Kara] > > On Sat, Apr 2, 2016 at 1:47 PM, Borislav Petkov wrote: > > On Sat, Apr 02, 2016 at 01:13:37PM -0700, Andy Lutomirski wrote: > >> Given that I this isn't really a regression with my patches (it > >> probably never worked much bet

Re: [Xen-devel] [PATCH v13 03/26] tools/libxl: Add back channel to allow migration target send data back

2016-04-04 Thread Olaf Hering
On Fri, Mar 25, Changlong Xie wrote: > +#elif defined(LIBXL_API_VERSION) && LIBXL_API_VERSION >= 0x040400 \ > + && LIBXL_API_VERSION < 0x040700 Is this supposed to work? libvirt.git fails to build now: libxl/libxl_domain.c: In function 'libxlDomainStart': libxl/li

Re: [Xen-devel] xen-utils not running within xen or no compatible utils

2016-04-04 Thread Julien Grall
Hello, On 01/04/2016 17:47, Wei Liu wrote: Add back xen-devel On Fri, Apr 01, 2016 at 05:45:31PM +0200, aicha hamza wrote: yes i compiled xen from the source .. this is exactly what i did http://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions/OMAP5432_uEVM and i get xen runni

[Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-04 Thread Anna-Maria Gleixner
Xen guests do not offline/online CPUs during suspend/resume and therefore FROZEN notifier transitions are not required. Add this explanation as a comment in the code to get not confused why CPU_TASKS_FROZEN masked transitions are not considered. Cc: David Vrabel Cc: Stefano Stabellini Cc: xen-de

Re: [Xen-devel] [PATCH v5 19/28] build_id: Provide ld-embedded build-ids

2016-04-04 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > The version of ld that first implemented --build-id is v2.18. > Hence we check for that or later version - if older version > found we do not build the hypervisor with the build-id > (and the return code is -ENODATA for xen_build_id() call). This appears to be s

Re: [Xen-devel] [PATCH v5 3/9] x86/head: Move early exception panic code into early_fixup_exception

2016-04-04 Thread Peter Zijlstra
On Mon, Apr 04, 2016 at 01:52:06PM +0200, Jan Kara wrote: > Sounds like a good idea to me. I've also consulted this with Petr Mladek > (added to CC) who is using printk_func per-cpu variable in his > printk-from-NMI patches and he also doesn't see a problem with this. There's a few printk() varian

Re: [Xen-devel] [PATCH v13 03/26] tools/libxl: Add back channel to allow migration target send data back

2016-04-04 Thread Wei Liu
CC Jim On Mon, Apr 04, 2016 at 02:07:28PM +0200, Olaf Hering wrote: > On Fri, Mar 25, Changlong Xie wrote: > > > +#elif defined(LIBXL_API_VERSION) && LIBXL_API_VERSION >= 0x040400 \ > > + && LIBXL_API_VERSION < 0x040700 > > Is this supposed to work? libvirt.git fa

[Xen-devel] [qemu-mainline test] 88557: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88557 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/88557/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 10 guest-start fail REGR. vs. 86454 test-amd64-i386-fre

[Xen-devel] [xen-unstable-smoke test] 88656: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88656 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/88656/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build fail REGR. vs. 88144 Tests which di

Re: [Xen-devel] xen-utils not running within xen or no compatible utils

2016-04-04 Thread Julien Grall
(Adding back xen-devel) Please don't top post and keep xen-devel CCed. On 04/04/2016 14:15, aicha hamza wrote: i'm actually looking for building a dom u for omap5 but the problem that i don't have an internet connection .. so i can't get the xen-utils .. (no xl command) is there an other method

[Xen-devel] [linux-3.16 test] 88561: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88561 linux-3.16 real [real] http://logs.test-lab.xenproject.org/osstest/logs/88561/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 21 guest-migrate/src_host/dst_host fail REGR. vs. 85048 Tests which are

[Xen-devel] Policy for force pushing smoke branch Was: Re: [xen-unstable-smoke test] 88656: regressions - FAIL

2016-04-04 Thread Wei Liu
On Mon, Apr 04, 2016 at 01:15:53PM +, osstest service owner wrote: > flight 88656 xen-unstable-smoke real [real] > http://logs.test-lab.xenproject.org/osstest/logs/88656/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-a

[Xen-devel] Policy for force pushing smoke branch Was: Re: [xen-unstable-smoke test] 88656: regressions - FAIL

2016-04-04 Thread Ian Jackson
Wei Liu writes ("Policy for force pushing smoke branch Was: Re: [Xen-devel] [xen-unstable-smoke test] 88656: regressions - FAIL"): > On Mon, Apr 04, 2016 at 01:15:53PM +, osstest service owner wrote: > > flight 88656 xen-unstable-smoke real [real] > > http://logs.test-lab.xenproject.org/osstes

[Xen-devel] Failed vm entry when emulating in hvm_do_resume()

2016-04-04 Thread Razvan Cojocaru
Hello, As a test, I've modified xen-access.c to this simplified skeleton: http://pastebin.com/48WYwW00 then started up an x86 Windows 7 HVM guest, and ran it with: # ./xen-access write once the login screen appeared. The guest promptly crashed with this backtrace: http://pastebin.com/Bz0GeFt

Re: [Xen-devel] [PATCH v5 20/28] HYPERCALL_version_op: Add VERSION_build_id to retrieve build-id.

2016-04-04 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > The VERSION hypercall provides the flexibility to expose > the size of the build-id (so the callers can allocate the > proper size before trying to retrieve it). It also allows > in one nice swoop to retrieve the hypervisor build-id in the > provided buffer. > >

Re: [Xen-devel] [PATCH v5 22/28] xsplice: Print build_id in keyhandler and on bootup.

2016-04-04 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > @@ -1414,10 +1420,16 @@ static void xsplice_printall(unsigned char key) > > static int __init xsplice_init(void) > { > +const void *binary_id = NULL; > +unsigned int len = 0; Pointless initializer. > BUILD_BUG_ON( sizeof(struct xsplice_patch_fu

Re: [Xen-devel] [PATCH V2 1/9] xenalyze: Support for ARM platform

2016-04-04 Thread Wei Liu
On Mon, Apr 04, 2016 at 03:10:46PM +0100, Wei Liu wrote: > I would retitle this patch: > > xentrace: build for both x86 and ARM platform ^ xenalyze Sorry for the typo. Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.

Re: [Xen-devel] [PATCH V2 0/9] xentrace/xenalyze support on ARM

2016-04-04 Thread Wei Liu
On Fri, Apr 01, 2016 at 04:33:44PM -0400, Benjamin Sanda wrote: > This patch set adds support for xentrace/xenalyze to the ARM platform. > > The Xen heap memory mapping, timestamping, and P2M translation needed > by xentrace is corrected for operation on the ARM platform using the > x86 platform a

Re: [Xen-devel] [PATCH V2 1/9] xenalyze: Support for ARM platform

2016-04-04 Thread Wei Liu
I would retitle this patch: xentrace: build for both x86 and ARM platform to be more specific. On Fri, Apr 01, 2016 at 04:33:46PM -0400, Benjamin Sanda wrote: > Modified to provide building of the xenalyze binary for ARM platforms. > This was done in conjunction with patches to xentrace allowi

Re: [Xen-devel] Failed vm entry when emulating in hvm_do_resume()

2016-04-04 Thread Andrew Cooper
On 04/04/16 14:32, Razvan Cojocaru wrote: > Hello, > > As a test, I've modified xen-access.c to this simplified skeleton: > > http://pastebin.com/48WYwW00 > > then started up an x86 Windows 7 HVM guest, and ran it with: > > # ./xen-access write > > once the login screen appeared. The guest promptl

[Xen-devel] libxl gentypes.pl "saved_FOO" oddity

2016-04-04 Thread Ian Jackson
Coverity is complaining (eg, CID 1358114) about this code in _libxl_types.c: *** CID 1358114: Code maintainability issues (UNUSED_VALUE) /tools/libxl/_libxl_types.c: 11035 in libxl__device_usbdev_parse_json() 11029 x = libxl__json_map_get("hostaddr", x, JSON_INTEGER); 11030 if (x) {

Re: [Xen-devel] [PATCH v5 23/28] xsplice: Stacking build-id dependency checking.

2016-04-04 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > @@ -929,6 +932,33 @@ being loaded and requires an hypervisor build-id to > match against. > The old code allows much more flexibility and an additional guard, > but is more complex to implement. > > +The second option which requires an build-id of the hyperv

[Xen-devel] Wrong use of sizeof() in libxl_pvusb.c

2016-04-04 Thread Ian Jackson
Coverity complains, rightly, as follows: > *** CID 1358110: Incorrect expression (SIZEOF_MISMATCH) > /tools/libxl/libxl_pvusb.c: 1068 in bind_usbintf() > 1062 if (fd < 0) { > 1063 LOGE(ERROR, "open file failed: '%s'", path); > 1064 rc = ERROR_FAIL; > 1065

Re: [Xen-devel] [PATCH V2 0/9] xentrace/xenalyze support on ARM

2016-04-04 Thread Julien Grall
Hello, On 04/04/2016 15:11, Wei Liu wrote: On Fri, Apr 01, 2016 at 04:33:44PM -0400, Benjamin Sanda wrote: --- Changed since v1: * Removed Flask changes as deemed uncessesary and unclear in purpose * Corrected all commit messages to be line limited to 72 chars * Implimented v1 rev

Re: [Xen-devel] [PATCH v5 25/28] xsplice: Print dependency and payloads build_id in the keyhandler.

2016-04-04 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > --- a/xen/common/xsplice.c > +++ b/xen/common/xsplice.c > @@ -1514,6 +1514,11 @@ static void xsplice_printall(unsigned char key) > if ( !(i % 100) ) > process_pending_softirqs(); > } > +if ( data->id.len ) > +

Re: [Xen-devel] [PATCH v5 26/28] xsplice: Prevent duplicate payloads from being loaded.

2016-04-04 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > --- a/xen/common/xsplice.c > +++ b/xen/common/xsplice.c > @@ -566,6 +566,27 @@ static int prepare_payload(struct payload *payload, > if ( !payload->id.len || !payload->id.p ) > return -EINVAL; > } > +/* Make sure it is not a duplica

[Xen-devel] Redundant lstats in libxl_pvusb.c

2016-04-04 Thread Ian Jackson
In libxl_usb.c, usbintf_get_drvpath calls stat(2) on the driver sysfs path, and then realpath on the same path. And bind_usbintf calls stat(2) on the driver directory path, and then open(2) on a file in that directory. It seems to be that in both cases, libxl could simply directly access the targ

Re: [Xen-devel] New Defects reported by Coverity Scan for XenProject

2016-04-04 Thread Ian Jackson
scan-ad...@coverity.com writes ("New Defects reported by Coverity Scan for XenProject"): > Please find the latest report on new defect(s) introduced to XenProject found > with Coverity Scan. > > 35 new defect(s) introduced to XenProject found with Coverity Scan. > 2 defect(s), reported by Coverit

Re: [Xen-devel] [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

2016-04-04 Thread George Dunlap
On 01/04/16 15:31, Ian Jackson wrote: > George Dunlap writes ("[PATCH v3 5/9] libxl: Rearrange qemu upstream disk > argument code"): >> Reorganize the qemuu disk argument code to make a clean separation >> between finding a file to use, and constructing the parameters: > > This didn't apply to st

[Xen-devel] [hypervisor deadlock] Re: [PATCH v9 for Xen 4.7 1/4] xen: enable per-VCPU parameter for RTDS

2016-04-04 Thread Andrew Cooper
On 01/04/16 05:59, Chong Li wrote: > diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c > index 305889a..e5d15d8 100644 > --- a/xen/common/sched_credit.c > +++ b/xen/common/sched_credit.c > @@ -1080,15 +1080,13 @@ csched_dom_cntl( > * lock. Runq lock not needed anywhere in her

[Xen-devel] [PATCH 2/2] libxl: Do not leak data on error path from libxl__read_sysfs_file_contents

2016-04-04 Thread Ian Jackson
Bug introduced in bc023ecd "libxl_utils: add internal function to read sysfs file contents" CID: 1358108 Signed-off-by: Ian Jackson CC: cover...@xenproject.org CC: Chunyan Liu --- tools/libxl/libxl_utils.c |1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl_utils.c b/tools/

[Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

2016-04-04 Thread Ian Jackson
We must set rc before using `goto out'. Bug introduced in bf7628f0 "libxl: add pvusb API". CID: 1358113 Signed-off-by: Ian Jackson CC: cover...@xenproject.org CC: Simon Cao CC: George Dunlap CC: Chunyan Liu --- tools/libxl/libxl_pvusb.c |1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [Xen-devel] [PATCH v5 27/28] xsplice: Add support for shadow variables.

2016-04-04 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > Shadow variables are a piece of infrastructure to be used by xsplice > modules. They are used to attach a new piece of data to an existing > structure in memory. An already known question again: Out of recent XSAs, how many needed such? I.e. can#t we put this of

Re: [Xen-devel] [PATCH v13 03/26] tools/libxl: Add back channel to allow migration target send data back

2016-04-04 Thread Olaf Hering
On Mon, Apr 04, Wei Liu wrote: > The fix is to patch libvirt. Looking at libvirt code I think I need to > patch Makefile.in to pass in an explicit LIBXL_API_VERSION number. That might be true. But shouldnt at the same time libxl.h get a change to recognize 0x040700? Perhaps this will be part of

Re: [Xen-devel] [PATCH v5 3/9] x86/head: Move early exception panic code into early_fixup_exception

2016-04-04 Thread Andy Lutomirski
On Apr 4, 2016 4:51 AM, "Jan Kara" wrote: > > On Sat 02-04-16 13:58:19, Andy Lutomirski wrote: > > [cc Jan Kara] > > > > On Sat, Apr 2, 2016 at 1:47 PM, Borislav Petkov wrote: > > > On Sat, Apr 02, 2016 at 01:13:37PM -0700, Andy Lutomirski wrote: > > >> Given that I this isn't really a regression

Re: [Xen-devel] [PATCH v5 3/9] x86/head: Move early exception panic code into early_fixup_exception

2016-04-04 Thread Arjan van de Ven
On 4/4/2016 8:32 AM, Andy Lutomirski wrote: Adding locking would be easy enough, wouldn't it? But do any platforms really boot a second CPU before switching to real printk? Given that I see all the smpboot stuff in dmesg, I guess real printk happens first. I admit I haven't actually checked.

Re: [Xen-devel] ARMv8: New board bring up hangs in kernel start?

2016-04-04 Thread Dirk Behme
Hi Julien, On 01.04.2016 18:34, Julien Grall wrote: On 31/03/16 18:41, Dirk Behme wrote: Hello Julien, Hello Dirk, On 29.03.2016 20:53, Julien Grall wrote: On 23/03/16 17:24, Dirk Behme wrote: trying to bring up Xen on a new ARMv8 64-bit Cortex A57 eval board, I get [1] and then its han

[Xen-devel] [PATCH] x86/extable: Add a comment about early exception handlers

2016-04-04 Thread Andy Lutomirski
Borislav asked for a comment explaining why all exception handlers are allowed early. Signed-off-by: Andy Lutomirski --- arch/x86/mm/extable.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c index 98b5f45d9d79..36fe03bc81ee 100644

Re: [Xen-devel] [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early

2016-04-04 Thread Andy Lutomirski
On Sun, Apr 3, 2016 at 7:10 AM, Borislav Petkov wrote: > On Sun, Apr 03, 2016 at 06:55:00AM -0700, Andy Lutomirski wrote: >> > No, please don't fail at early boot. >> > >> > Early boot is just about the *worst* situation to try to debug odd >> > failures, exactly since things like printk may not b

Re: [Xen-devel] [PATCH V7 1/3] x86/xsaves: fix overwriting between non-lazy/lazy xsaves

2016-04-04 Thread Jan Beulich
>>> On 31.03.16 at 10:57, wrote: > xsaves will not be used until supervised state is introduced in hypervisor. > And XSTATE_XSAVES_ONLY (indicates supervised state is understood in xen) > is instroduced, the use of xsaves depend on whether XSTATE_XSAVES_ONLY There's still a spelling mistake here,

Re: [Xen-devel] [PATCH V2 0/9] xentrace/xenalyze support on ARM

2016-04-04 Thread Ben Sanda
Julien and Wei, >> You patches all have the same subject line. Please make them more >> specific. See my reply to #1 for example. > > +1 > > Also, you should at least check that Xen still builds after applying > each patch. Ideally, you also need to be careful to not break any > feature current

[Xen-devel] [xen-unstable-smoke test] 88672: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88672 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/88672/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build fail REGR. vs. 88144 Tests which di

Re: [Xen-devel] [PATCH V2 0/9] xentrace/xenalyze support on ARM

2016-04-04 Thread Wei Liu
On Mon, Apr 04, 2016 at 03:50:35PM +, Ben Sanda wrote: > Julien and Wei, > > >> You patches all have the same subject line. Please make them more > >> specific. See my reply to #1 for example. > > > > +1 > > > > Also, you should at least check that Xen still builds after applying > > each p

Re: [Xen-devel] [hypervisor deadlock] Re: [PATCH v9 for Xen 4.7 1/4] xen: enable per-VCPU parameter for RTDS

2016-04-04 Thread Chong Li
On Mon, Apr 4, 2016 at 10:14 AM, Andrew Cooper wrote: > On 01/04/16 05:59, Chong Li wrote: >> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c >> index 305889a..e5d15d8 100644 >> --- a/xen/common/sched_credit.c >> +++ b/xen/common/sched_credit.c >> @@ -1080,15 +1080,13 @@ csched_

Re: [Xen-devel] [PATCH V7 2/3] x86/xsaves: fix two remained issues

2016-04-04 Thread Jan Beulich
>>> On 31.03.16 at 10:57, wrote: Considering this isn't the last patch in the series, the subject isn't really nice (apart from being mis-spelled). If you e.g. replaced "remained" by "miscellaneous", I wouldn't insist on splitting. > 1. get_xsave_addr() will only be called when > xsave_area_comp

Re: [Xen-devel] [PATCH v5 3/9] x86/head: Move early exception panic code into early_fixup_exception

2016-04-04 Thread Peter Zijlstra
On Mon, Apr 04, 2016 at 08:32:21AM -0700, Andy Lutomirski wrote: > Adding locking would be easy enough, wouldn't it? See patch in this thread.. > But do any platforms really boot a second CPU before switching to real > printk? I _only_ use early_printk() as printk() is a quagmire of fail :-)

Re: [Xen-devel] [PATCH v2] x86/hvm: separate ioreq server code from generic hvm code

2016-04-04 Thread Boris Ostrovsky
On 04/01/2016 03:54 AM, Paul Durrant wrote: The code in hvm/hvm.c related to handling I/O emulation using the ioreq server framework is large and mostly self-contained. This patch separates the ioreq server code into a new hvm/ioreq.c source module and accompanying asm-x86/hvm/ioreq.h header fil

Re: [Xen-devel] Intel MID / CE4100 - platform support - pnpbios support ?

2016-04-04 Thread H. Peter Anvin
On 03/31/16 13:03, Luis R. Rodriguez wrote: > Andy S, Peter, Thomas, Jiang (or who might know), > > Do Intel MID platforms exist with PNP BIOS support? What abot CE4100? > As it stands I don't see anything that would prevent this but I would > suspect a possibility might be that it doesn't. I'm sa

Re: [Xen-devel] [PATCH V2 0/9] xentrace/xenalyze support on ARM

2016-04-04 Thread Andrew Cooper
On 04/04/16 16:50, Ben Sanda wrote: > Julien and Wei, > >>> You patches all have the same subject line. Please make them more >>> specific. See my reply to #1 for example. >> +1 >> >> Also, you should at least check that Xen still builds after applying >> each patch. Ideally, you also need to be

Re: [Xen-devel] [hypervisor deadlock] Re: [PATCH v9 for Xen 4.7 1/4] xen: enable per-VCPU parameter for RTDS

2016-04-04 Thread George Dunlap
On 04/04/16 16:58, Chong Li wrote: > On Mon, Apr 4, 2016 at 10:14 AM, Andrew Cooper > wrote: >> On 01/04/16 05:59, Chong Li wrote: >>> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c >>> index 305889a..e5d15d8 100644 >>> --- a/xen/common/sched_credit.c >>> +++ b/xen/common/sched

Re: [Xen-devel] [PATCH] x86/extable: Add a comment about early exception handlers

2016-04-04 Thread Borislav Petkov
On Mon, Apr 04, 2016 at 08:46:22AM -0700, Andy Lutomirski wrote: > Borislav asked for a comment explaining why all exception handlers are > allowed early. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/mm/extable.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/ar

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-04 Thread Julien Grall
(CC Stefano new e-mail address) Hello Anna-Maria, On 04/04/2016 13:32, Anna-Maria Gleixner wrote: Xen guests do not offline/online CPUs during suspend/resume and therefore FROZEN notifier transitions are not required. Add this explanation as a comment in the code to get not confused why CPU_TAS

Re: [Xen-devel] [PATCH v5 0/9] Improve non-"safe" MSR access failure handling

2016-04-04 Thread Borislav Petkov
On Sat, Apr 02, 2016 at 07:01:31AM -0700, Andy Lutomirski wrote: > There are two parts here: > > * FIRST PART: EARLY EXCEPTIONS * > > The first few patches move some early panic code into C, add pt_regs > to early exception handling, and make fancy exception handlers work early. > >

Re: [Xen-devel] libxl gentypes.pl "saved_FOO" oddity

2016-04-04 Thread Wei Liu
On Mon, Apr 04, 2016 at 03:57:02PM +0100, Ian Jackson wrote: > Coverity is complaining (eg, CID 1358114) about this code in > _libxl_types.c: > > *** CID 1358114: Code maintainability issues (UNUSED_VALUE) > /tools/libxl/_libxl_types.c: 11035 in libxl__device_usbdev_parse_json() > 11029 x

[Xen-devel] [linux-mingo-tip-master test] 88622: regressions - FAIL

2016-04-04 Thread osstest service owner
flight 88622 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/88622/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 6 xen-build fail REGR. vs. 60684 build-amd6

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-04 Thread David Vrabel
On 04/04/16 17:21, Julien Grall wrote: > (CC Stefano new e-mail address) > > Hello Anna-Maria, > > On 04/04/2016 13:32, Anna-Maria Gleixner wrote: >> Xen guests do not offline/online CPUs during suspend/resume and >> therefore FROZEN notifier transitions are not required. Add this >> explanation

Re: [Xen-devel] [PATCH v5 7/9] x86/paravirt: Add paravirt_{read, write}_msr

2016-04-04 Thread David Vrabel
On 02/04/16 15:01, Andy Lutomirski wrote: > This adds paravirt hooks for unsafe MSR access. On native, they > call native_{read,write}_msr. On Xen, they use > xen_{read,write}_msr_safe. > > Nothing uses them yet for ease of bisection. The next patch will > use them in rdmsrl, wrmsrl, etc. > >

Re: [Xen-devel] [hypervisor deadlock] Re: [PATCH v9 for Xen 4.7 1/4] xen: enable per-VCPU parameter for RTDS

2016-04-04 Thread Dario Faggioli
On Mon, 2016-04-04 at 17:05 +0100, George Dunlap wrote: > On 04/04/16 16:58, Chong Li wrote: > > On Mon, Apr 4, 2016 at 10:14 AM, Andrew Cooper > > wrote: > > > On 01/04/16 05:59, Chong Li wrote: > > > >  > > > > --- a/xen/common/sched_credit2.c > > > > +++ b/xen/common/sched_credit2.c > > > > @@

Re: [Xen-devel] [PATCH v5 7/9] x86/paravirt: Add paravirt_{read, write}_msr

2016-04-04 Thread Andy Lutomirski
On Mon, Apr 4, 2016 at 9:33 AM, David Vrabel wrote: > On 02/04/16 15:01, Andy Lutomirski wrote: >> This adds paravirt hooks for unsafe MSR access. On native, they >> call native_{read,write}_msr. On Xen, they use >> xen_{read,write}_msr_safe. >> >> Nothing uses them yet for ease of bisection. T

Re: [Xen-devel] [hypervisor deadlock] Re: [PATCH v9 for Xen 4.7 1/4] xen: enable per-VCPU parameter for RTDS

2016-04-04 Thread Wei Liu
On Mon, Apr 04, 2016 at 06:32:48PM +0200, Dario Faggioli wrote: > On Mon, 2016-04-04 at 17:05 +0100, George Dunlap wrote: > > On 04/04/16 16:58, Chong Li wrote: > > > On Mon, Apr 4, 2016 at 10:14 AM, Andrew Cooper > > > wrote: > > > > On 01/04/16 05:59, Chong Li wrote: > > > > >  > > > > > --- a/x

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-04 Thread Boris Ostrovsky
On 04/04/2016 12:30 PM, David Vrabel wrote: On 04/04/16 17:21, Julien Grall wrote: (CC Stefano new e-mail address) Hello Anna-Maria, On 04/04/2016 13:32, Anna-Maria Gleixner wrote: Xen guests do not offline/online CPUs during suspend/resume and therefore FROZEN notifier transitions are not re

[Xen-devel] Policy for force pushing smoke branch Was: Re: [xen-unstable-smoke test] 88656: regressions - FAIL [and 1 more messages]

2016-04-04 Thread Ian Jackson
Ian Jackson writes ("Policy for force pushing smoke branch Was: Re: [Xen-devel] [xen-unstable-smoke test] 88656: regressions - FAIL"): > Wei Liu writes ("Policy for force pushing smoke branch Was: Re: [Xen-devel] > [xen-unstable-smoke test] 88656: regressions - FAIL"): > > It would take some time

Re: [Xen-devel] [PATCH v13 03/26] tools/libxl: Add back channel to allow migration target send data back

2016-04-04 Thread Ian.Jackson
Olaf Hering writes ("Re: [Xen-devel] [PATCH v13 03/26] tools/libxl: Add back channel to allow migration target send data back"): > On Mon, Apr 04, Wei Liu wrote: > > The fix is to patch libvirt. Looking at libvirt code I think I need to > > patch Makefile.in to pass in an explicit LIBXL_API_VERSIO

Re: [Xen-devel] [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

2016-04-04 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code"): > I looked through the patch in the branch provided in your reply to 0/9 > [1], and it looks correct; morever, I tested it and it and the basic > functionality (using the "dummy" block script) still work

Re: [Xen-devel] [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

2016-04-04 Thread Andrew Cooper
On 04/04/16 17:59, Ian Jackson wrote: > George Dunlap writes ("Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream disk > argument code"): >> I looked through the patch in the branch provided in your reply to 0/9 >> [1], and it looks correct; morever, I tested it and it and the basic >> functionalit

Re: [Xen-devel] XSM permissive by default.

2016-04-04 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] XSM permissive by default."): > I presume this patch would be to folks +1: > > From 3373a50f386b41eea6ecede4b430e4fa09b2fe7e Mon Sep 17 00:00:00 2001 > From: Konrad Rzeszutek Wilk > Date: Thu, 10 Mar 2016 12:05:29 -0500 > Subject: [PATCH] flask: By d

Re: [Xen-devel] [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code

2016-04-04 Thread Andrew Cooper
On 04/04/16 18:11, Andrew Cooper wrote: > On 04/04/16 17:59, Ian Jackson wrote: >> George Dunlap writes ("Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream >> disk argument code"): >>> I looked through the patch in the branch provided in your reply to 0/9 >>> [1], and it looks correct; morever, I

Re: [Xen-devel] [hypervisor deadlock] Re: [PATCH v9 for Xen 4.7 1/4] xen: enable per-VCPU parameter for RTDS

2016-04-04 Thread Chong Li
On Mon, Apr 4, 2016 at 11:47 AM, Wei Liu wrote: > On Mon, Apr 04, 2016 at 06:32:48PM +0200, Dario Faggioli wrote: >> On Mon, 2016-04-04 at 17:05 +0100, George Dunlap wrote: >> > On 04/04/16 16:58, Chong Li wrote: >> > > On Mon, Apr 4, 2016 at 10:14 AM, Andrew Cooper >> > > wrote: >> > > > On 01/0

[Xen-devel] [PATCH 0/5] COLO fixes

2016-04-04 Thread Wei Liu
Wei Liu (5): libxc: colo: don't leak pfns and iov in send_checkpoint_dirty_pfn_list libxl: colo: simplify colo_proxy_async_wait_for_checkpoint libxl: colo: add missing break in qemu_disk_scsi_drive_string libxl: colo: fix indentation of abort() libxl: colo: remove dead code in colo_save_s

[Xen-devel] [PATCH 2/5] libxl: colo: simplify colo_proxy_async_wait_for_checkpoint

2016-04-04 Thread Wei Liu
Signed-off-by: Wei Liu --- tools/libxl/libxl_colo_save.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxl_colo_save.c b/tools/libxl/libxl_colo_save.c index e2fdc4b..26b3afd 100644 --- a/tools/libxl/libxl_colo_save.c +++ b/tools/libxl/libxl_colo_save.c

  1   2   >