Re: [Xen-devel] [PATCH] xen: Fix XSM build following c/s 92942fd

2016-02-17 Thread Andrew Cooper
On 11/02/16 00:15, Daniel De Graaf wrote: > On 10/02/16 05:47, Jan Beulich wrote: > On 10.02.16 at 11:39, wrote: >>> On 09/02/16 17:05, Jan Beulich wrote: >>> On 09.02.16 at 17:21, wrote: > Signed-off-by: Andrew Cooper I'm sorry for the breakage / not noticing. > --- >>

Re: [Xen-devel] [PATCH v5 5/7] VT-d: Refactor iommu_ops .map_page() and unmap_page()

2016-02-17 Thread Jan Beulich
>>> On 05.02.16 at 11:18, wrote: > to pass down a flag indicating whether the lock is being held, > and check the way up the call trees. Same comments as on the previous patch; most of the changes outside of xen/drivers/passthrough/ seem to be avoidable here. Jan __

Re: [Xen-devel] p2m stuff and crash tool

2016-02-17 Thread Juergen Gross
On 17/02/16 14:59, Daniel Kiper wrote: > On Tue, Feb 16, 2016 at 01:55:33PM +0100, Juergen Gross wrote: >> Hi Daniel, >> >> On 16/02/16 12:35, Daniel Kiper wrote: >>> Hey Juergen, > > [...] > >>> After that I decided to take a look at Linux kernel upstream. I saw >>> that xen_max_p2m_pfn in xen_b

[Xen-devel] [PATCH 1/2] tools: gtracestat: Drop unused functions do_cstate and single_cstate helper

2016-02-17 Thread Ian Campbell
These have always been dead code since the code was added AFAICT. This eliminates the code containing CID 10567079, 10567080, 10567081 and 10567082 (all apparently some confusion between max_cx_num vs MAX_CX_NR, but given the lack of callers its hard to tell what was intended) Signed-off-by: Ian

[Xen-devel] [PATCH 2/2] tools: gtracestat: make all functions and global data static

2016-02-17 Thread Ian Campbell
After "Drop unused functions do_cstate and single_cstate helper" make all the remaining functions and global data static and in the process allow the compiler to notice that cond_rec_init() is also unused, thus remove it. Signed-off-by: Ian Campbell --- tools/misc/gtracestat.c | 103

Re: [Xen-devel] [PATCH] x86/HVM: fold hypercall tables

2016-02-17 Thread Andrew Cooper
On 15/02/16 08:52, Jan Beulich wrote: On 15.02.16 at 09:26, wrote: >> On 15/02/2016 07:42, Jan Beulich wrote: >>> @@ -5395,7 +5398,7 @@ int hvm_do_hypercall(struct cpu_user_reg >>> } >>> #endif >>> >>> -regs->_eax = hvm_hypercall32_table[eax](ebx, ecx, edx, esi, edi, >>>

[Xen-devel] [PATCH v3 2/3] xenoprof: fix up ability to disable it

2016-02-17 Thread Doug Goldstein
Allow Xenoprof to be fully disabled when toggling the option off. Signed-off-by: Doug Goldstein --- change since v2: - move all functions in xenoprof.h inside CONFIG_XENOPROF change since v1: - switch to #define empty 'functions' as suggested by Andrew Cooper --- xen/arch/x86/Makefile

[Xen-devel] [PATCH v3 3/3] build: convert xenoprof to Kconfig

2016-02-17 Thread Doug Goldstein
Convert the xenoprof x86 build time option to Kconfig. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Reviewed-by: Andrew Cooper Signed-off-by: Doug Goldstein --- CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper change since v2: - require EXPERT for XENOPROF as suggested by Jan Beulic

[Xen-devel] [PATCH v3 1/3] PMU: make {acquire, release}_pmu_ownership names consistent

2016-02-17 Thread Doug Goldstein
The function names were inconsistent with acquire and release being called acquire_pmu_ownership() and release_pmu_ownship() respectively. Function prototypes were available for both spellings so this change makes them consistent and drops the dual function prototypes. Additionally change the inter

[Xen-devel] [PATCH v3 1/3] PMU: make {acquire, release}_pmu_ownership names consistent

2016-02-17 Thread Doug Goldstein
The function names were inconsistent with acquire and release being called acquire_pmu_ownership() and release_pmu_ownship() respectively. Function prototypes were available for both spellings so this change makes them consistent and drops the dual function prototypes. Additionally change the inter

[Xen-devel] [PATCH v3 2/3] xenoprof: fix up ability to disable it

2016-02-17 Thread Doug Goldstein
Allow Xenoprof to be fully disabled when toggling the option off. Signed-off-by: Doug Goldstein --- CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper change since v2: - move all functions in xenoprof.h inside CONFIG_XENOPROF as suggested by Andrew Cooper change since v1: - switch to #define

Re: [Xen-devel] [PATCH v4 1/4] x86/HVM: update the start info structure layout

2016-02-17 Thread Boris Ostrovsky
On 02/17/2016 05:05 AM, Roger Pau Monné wrote: El 17/2/16 a les 10:58, Jan Beulich ha escrit: On 16.02.16 at 22:26, wrote: On 02/16/2016 12:37 PM, Roger Pau Monne wrote: diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h index 7b629b1..6ba060f 100644 --- a/xen/include/public/xen

Re: [Xen-devel] [PATCH v5 7/7] VT-d: Fix vt-d Device-TLB flush timeout issue.

2016-02-17 Thread Jan Beulich
>>> On 05.02.16 at 11:18, wrote: > --- a/xen/drivers/passthrough/vtd/qinval.c > +++ b/xen/drivers/passthrough/vtd/qinval.c > @@ -229,6 +229,69 @@ int qinval_device_iotlb(struct iommu *iommu, > return 0; > } > > +static void dev_invalidate_iotlb_timeout(struct iommu *iommu, u16 did, > +

[Xen-devel] [PATCH] tools: remove xenpmd

2016-02-17 Thread Ian Campbell
It has four instances of the same CID 1198719 (strncpy(..., 32) into a 32-byte buffer). However ever since it was checked in in 2008 it has contained a /tmp instead of the real ones in /proc. I therefore conclude that it has not ever been used in its current form in the last 8 years and might as w

[Xen-devel] [PATCH v3 3/3] build: convert xenoprof to Kconfig

2016-02-17 Thread Doug Goldstein
Convert the xenoprof x86 build time option to Kconfig. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Reviewed-by: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Makefile | 2 +- xen/arch/x86/Rules.mk | 3 --- xen/common/Kconfig| 14 ++ xen/common/Makefile

Re: [Xen-devel] [PATCH v2 15/30] xen/x86: Improvements to in-hypervisor cpuid sanity checks

2016-02-17 Thread Jan Beulich
>>> On 17.02.16 at 15:02, wrote: > On 17/02/16 10:55, Jan Beulich wrote: > On 17.02.16 at 11:43, wrote: >>> On 16/02/16 10:06, Jan Beulich wrote: >>> On 15.02.16 at 18:12, wrote: > On 15/02/16 15:43, Jan Beulich wrote: > On 05.02.16 at 14:42, wrote: >>> @@ -4617,50 +4618

Re: [Xen-devel] [PATCH v2] x86: avoid flush IPI when possible

2016-02-17 Thread Andrew Cooper
On 16/02/16 10:14, Jan Beulich wrote: > --- a/xen/arch/x86/smp.c > +++ b/xen/arch/x86/smp.c > @@ -205,26 +205,30 @@ static unsigned int flush_flags; > > void invalidate_interrupt(struct cpu_user_regs *regs) > { > +unsigned int flags = flush_flags; > ack_APIC_irq(); > perfc_incr(ip

Re: [Xen-devel] [PATCH v3 1/3] PMU: make {acquire, release}_pmu_ownership names consistent

2016-02-17 Thread Andrew Cooper
On 17/02/16 14:37, Doug Goldstein wrote: > The function names were inconsistent with acquire and release being > called acquire_pmu_ownership() and release_pmu_ownship() respectively. > Function prototypes were available for both spellings so this change > makes them consistent and drops the dual f

Re: [Xen-devel] [PATCH] x86/HVM: fold hypercall tables

2016-02-17 Thread Jan Beulich
>>> On 17.02.16 at 15:35, wrote: > On 15/02/16 08:52, Jan Beulich wrote: > On 15.02.16 at 09:26, wrote: >>> On 15/02/2016 07:42, Jan Beulich wrote: @@ -5395,7 +5398,7 @@ int hvm_do_hypercall(struct cpu_user_reg } #endif -regs->_eax = hvm_hypercall3

Re: [Xen-devel] p2m stuff and crash tool

2016-02-17 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 03:27:01PM +0100, Juergen Gross wrote: > On 17/02/16 14:59, Daniel Kiper wrote: > > On Tue, Feb 16, 2016 at 01:55:33PM +0100, Juergen Gross wrote: > >> Hi Daniel, > >> > >> On 16/02/16 12:35, Daniel Kiper wrote: > >>> Hey Juergen, > > > > [...] > > > >>> After that I decided

Re: [Xen-devel] [PATCH v3 1/3] PMU: make {acquire, release}_pmu_ownership names consistent

2016-02-17 Thread Boris Ostrovsky
On 02/17/2016 09:37 AM, Doug Goldstein wrote: The function names were inconsistent with acquire and release being called acquire_pmu_ownership() and release_pmu_ownship() respectively. Function prototypes were available for both spellings so this change makes them consistent and drops the dual fu

Re: [Xen-devel] [PATCH v4 1/4] x86/HVM: update the start info structure layout

2016-02-17 Thread Jan Beulich
>>> On 17.02.16 at 15:39, wrote: > On 02/17/2016 05:05 AM, Roger Pau Monné wrote: >> El 17/2/16 a les 10:58, Jan Beulich ha escrit: >> On 16.02.16 at 22:26, wrote: On 02/16/2016 12:37 PM, Roger Pau Monne wrote: > diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h >

Re: [Xen-devel] [PATCH v3 2/3] xenoprof: fix up ability to disable it

2016-02-17 Thread Andrew Cooper
On 17/02/16 14:37, Doug Goldstein wrote: > diff --git a/xen/include/asm-x86/xenoprof.h b/xen/include/asm-x86/xenoprof.h > index b006ddc..c78e8cf 100644 > --- a/xen/include/asm-x86/xenoprof.h > +++ b/xen/include/asm-x86/xenoprof.h > @@ -67,9 +67,33 @@ void xenoprof_backtrace(struct vcpu *, const str

[Xen-devel] [PATCH] xenpaging: do not leak if --pagefile given twice

2016-02-17 Thread Ian Campbell
By freeing filename (which is either NULL or the previous iteration of this argument). This implements a semantic where the last --pagefile given on the command line takes precedence. This is the same semantic as the other options have. CID: 1198792 Signed-off-by: Ian Campbell --- tools/xenpag

Re: [Xen-devel] p2m stuff and crash tool

2016-02-17 Thread Juergen Gross
On 17/02/16 15:52, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 03:27:01PM +0100, Juergen Gross wrote: >> On 17/02/16 14:59, Daniel Kiper wrote: >>> On Tue, Feb 16, 2016 at 01:55:33PM +0100, Juergen Gross wrote: Hi Daniel, On 16/02/16 12:35, Daniel Kiper wrote: > Hey Juergen, >>

Re: [Xen-devel] [PATCH v5 0/2] Vm-events: move monitor vm-events code to common-side.

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 17, 2016 at 09:33:58AM +0200, Corneliu ZUZU wrote: > This patch series is an attempt to move some of the monitor vm-events code to > the common-side. Done to make it easier to move additional parts that can be > moved to common when ARM-side implementations are to be added. Both applie

[Xen-devel] [PATCH v4] public/io/netif.h: make control ring hash protocol more general

2016-02-17 Thread Paul Durrant
This patch modified the control ring protocol (of which there is not yet an implementation) to make it more general. Most of the concepts are not limited to toeplitz hashing so it's best not to make them unnecessarily specific. Apart from changing the names of various definitions and modifying com

Re: [Xen-devel] [PATCH v3 3/3] build: convert xenoprof to Kconfig

2016-02-17 Thread Jan Beulich
>>> On 17.02.16 at 15:37, wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -84,6 +84,20 @@ config LATE_HWDOM > > If unsure, say N. > > +# Adds support for Xenoprof > +config XENOPROF > + bool > + prompt "Xen Oprofile Support" if EXPERT = "y" > + default y

[Xen-devel] [ovmf test] 82909: regressions - FAIL

2016-02-17 Thread osstest service owner
flight 82909 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/82909/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-localmigrate/x10 fail REGR. vs. 65543 test-amd64-amd64-xl-qem

Re: [Xen-devel] [PATCH v2 06/16] xen: sched: tracing: enable TSC tracing for all events

2016-02-17 Thread Meng Xu
On Wed, Feb 17, 2016 at 4:52 AM, Dario Faggioli wrote: > On Tue, 2016-02-16 at 13:21 -0500, Meng Xu wrote: >> Hi Dario, >> >> Since this patch did some obvious change, I will reply with >> reviewed-by, although my reviewed-by does not count much. ;-) >> > That can't be less true. First of all, you

[Xen-devel] [PATCH] xenpaging: don't try to log via xch if xc_interface_close fails

2016-02-17 Thread Ian Campbell
Since xch may not be valid (enough) any longer, xc_interface_close already logs anything of any use before it tears down the integrated logger so there is no need to log any further in the application via that path. CID: 1056203 Signed-off-by: Ian Campbell --- tools/xenpaging/xenpaging.c | 6 +-

Re: [Xen-devel] [PATCH v5 2/2] xen/vm-events: Move parts of monitor_domctl code to common-side.

2016-02-17 Thread Tamas K Lengyel
On Wed, Feb 17, 2016 at 12:38 AM, Corneliu ZUZU wrote: > This patch moves monitor_domctl to common-side. > Purpose: move what's common to common, prepare for implementation > of such vm-events on ARM. > > * move get_capabilities to arch-side => arch_monitor_get_capabilities. > * add arch-side mon

[Xen-devel] [linux-mingo-tip-master test] 82877: regressions - FAIL

2016-02-17 Thread osstest service owner
flight 82877 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/82877/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen6 xen-build fail REGR. vs. 60684 build-amd6

[Xen-devel] [PATCH] x86/mm: slightly simplify mod_l1_entry()

2016-02-17 Thread Jan Beulich
Re-order code to simplify error cleanup. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1873,38 +1873,32 @@ static int mod_l1_entry(l1_pgentry_t *pl { /* Translate foreign guest addresses. */ struct page_info *page = NULL; -if ( pagi

[Xen-devel] [PATCH 0/5] x86: XSA-170 follow-up

2016-02-17 Thread Jan Beulich
Patch 1 was sent out before (as replacement proposal to another patch), and is unchanged (still awaiting feedback, but fitting pretty nicely with the topic of XSA-170). Patch 2 fixes the actual problem which was reported to us, resulting in XSA-170. The remaining patches are only loosely related,

[Xen-devel] [PATCH OSSTEST] Increase priority of xen-unstable-coverity

2016-02-17 Thread Ian Campbell
Since we are limited on the number of these we can do per week (to 2) we would like these to happen fairly promptly after the time given in the crontab, otherwise we can potentially end up with the Wednesday run not actually happening until late Saturday, right before the Sunday run which might hap

[Xen-devel] [PATCH 1/5] x86emul: fix rIP handling

2016-02-17 Thread Jan Beulich
Deal with rIP just like with any other register: Truncate to designated width upon entry, write back the zero-extended 32-bit value when emulating 32-bit code, and leave the upper 48 bits unchanged for 16-bit code. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen

[Xen-devel] [PATCH] xen/blback: Fit the important information of the thread in 17 characters

2016-02-17 Thread Konrad Rzeszutek Wilk
The processes names are truncated to 17, while we had the length of the process as name 20 - which meant that while we filled it out with various details - the last 3 characters (which had the queue number) never surfaced to the user-space. To simplify this and be able to fit the device name, doma

[Xen-devel] [PATCH 2/5] x86emul: limit-check branch targets

2016-02-17 Thread Jan Beulich
All branches need to #GP when their target violates the segment limit (in 16- and 32-bit modes) or is non-canonical (in 64-bit mode). For near branches facilitate this via a zero-byte instruction fetch from the target address (resulting in address translation and validation without an actual read f

[Xen-devel] [PATCH 3/5] x86emul: simplify IRET logic

2016-02-17 Thread Jan Beulich
Since we only handle real mode, we need to consider neither non-ring0 nor IOPL. Also for POPF the mode_iopl() check can really be inside the not-ring-0 body. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -2490,9 +2490,11 @

[Xen-devel] [PATCH 4/5] VMX: fold redundant code

2016-02-17 Thread Jan Beulich
No need to do this in two slightly different ways, possibly keeping the compiler from folding the code for us. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3103,6 +3103,7 @@ void vmx_vmexit_handler(struct cpu_user_ && vector !

[Xen-devel] [PATCH 5/5] x86: drop failsafe callback invocation from assembly

2016-02-17 Thread Jan Beulich
Afaict this was never necessary on a 64-bit hypervisor, and was instead just blindly cloned over from 32-bit code: We don't fiddle with (and hence don't reload) any of DS, ES, FS, or GS, and an exception on IRET itself can equally well be reported to the guest as that very exception on the target o

Re: [Xen-devel] [PATCH] MAINTAINERS: add myself as seabios maintainer

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 17, 2016 at 09:48:28AM +, Ian Campbell wrote: > On Tue, 2016-02-16 at 17:54 +, Ian Jackson wrote: > > Wei Liu writes ("[PATCH] MAINTAINERS: add myself as seabios maintainer"): > > >  SEABIOS UPSTREAM > > >  M: Ian Campbell > > > +M: Wei Liu > > >  S: Supporte

Re: [Xen-devel] [PATCH] MAINTAINERS: add myself as seabios maintainer

2016-02-17 Thread Wei Liu
On Wed, Feb 17, 2016 at 11:45:58AM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 17, 2016 at 09:48:28AM +, Ian Campbell wrote: > > On Tue, 2016-02-16 at 17:54 +, Ian Jackson wrote: > > > Wei Liu writes ("[PATCH] MAINTAINERS: add myself as seabios maintainer"): > > > >  SEABIOS UPSTREAM

Re: [Xen-devel] [PATCH] xen/arm64: Make sure we get all debug output

2016-02-17 Thread Dirk Behme
On 04.02.2016 18:07, Dirk Behme wrote: On 04.02.2016 18:00, Ian Campbell wrote: On Thu, 2016-02-04 at 17:49 +0100, Dirk Behme wrote: From: Dirk Behme Starting in the wrong ELx mode I get the following debug output: ... - Current EL 0004 - - Xen must be entered in NS EL2 mode - - Boot fai

Re: [Xen-devel] EXTRA_CFLAGS when compiling Xen

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 17, 2016 at 02:09:43PM +0200, Corneliu ZUZU wrote: > On 2/17/2016 12:34 PM, Jan Beulich wrote: > > > >>The reason I need this is to pass '-save-temps' to GCC, I want to inspect > >>some code > >>and it would be easier to do that on the preprocessed files. > >... there's absolutely no ne

Re: [Xen-devel] [PATCH] tools: remove xenpmd

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 17, 2016 at 02:41:14PM +, Ian Campbell wrote: > It has four instances of the same CID 1198719 (strncpy(..., 32) into a > 32-byte buffer). > > However ever since it was checked in in 2008 it has contained a > /tmp instead of the real ones in /proc. I therefore conclude that it > has

Re: [Xen-devel] EXTRA_CFLAGS when compiling Xen

2016-02-17 Thread Corneliu ZUZU
On 2/17/2016 3:54 PM, Jan Beulich wrote: On 17.02.16 at 14:11, wrote: On 2/17/2016 2:43 PM, Jan Beulich wrote: On 17.02.16 at 13:09, wrote: On 2/17/2016 12:34 PM, Jan Beulich wrote: The reason I need this is to pass '-save-temps' to GCC, I want to inspect some code and it would be easier to

[Xen-devel] [PATCH v3 00/10] grub-xen: support booting huge pv-domains

2016-02-17 Thread Juergen Gross
The Xen hypervisor supports starting a dom0 with large memory (up to the TB range) by not including the initrd and p2m list in the initial kernel mapping. Especially the p2m list can grow larger than the available virtual space in the initial mapping. The started kernel is indicating the support o

[Xen-devel] [PATCH v3 04/10] xen: synchronize xen header

2016-02-17 Thread Juergen Gross
Get actual version of include/xen/xen.h from the Xen repository in order to be able to use constants defined there. Signed-off-by: Juergen Gross --- include/xen/arch-x86/xen-x86_32.h | 22 +++ include/xen/arch-x86/xen-x86_64.h | 8 +-- include/xen/xen.h | 125 +

[Xen-devel] [PATCH v3 05/10] xen: factor out p2m list allocation into separate function

2016-02-17 Thread Juergen Gross
Do the p2m list allocation of the to be loaded kernel in a separate function. This will allow doing the p2m list allocation at different times of the boot preparations depending on the features the kernel is supporting. While at this remove superfluous setting of first_p2m_pfn and nr_p2m_frames as

[Xen-devel] [PATCH v3 10/10] xen: add capability to load p2m list outside of kernel mapping

2016-02-17 Thread Juergen Gross
Modern pvops linux kernels support a p2m list not covered by the kernel mapping. This capability is flagged by an elf-note specifying the virtual address the kernel is expecting the p2m list to be mapped to. In case the elf-note is set by the kernel don't place the p2m list into the kernel mapping

[Xen-devel] [PATCH v3 06/10] xen: factor out allocation of special pages into separate function

2016-02-17 Thread Juergen Gross
Do the allocation of special pages (start info, console and xenbus ring buffers) in a separate function. This will allow to do the allocation at different times of the boot preparations depending on the features the kernel is supporting. Signed-off-by: Juergen Gross --- grub-core/loader/i386/xen

[Xen-devel] [PATCH v3 08/10] xen: add capability to load initrd outside of initial mapping

2016-02-17 Thread Juergen Gross
Modern pvops linux kernels support an initrd not covered by the initial mapping. This capability is flagged by an elf-note. In case the elf-note is set by the kernel don't place the initrd into the initial mapping. This will allow to load larger initrds and/or support domains with larger memory, a

[Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-17 Thread Juergen Gross
The loader for xen paravirtualized environment is using lots of global variables. Reduce the number by making them either local or by putting them into a single state structure. Signed-off-by: Juergen Gross --- grub-core/loader/i386/xen.c | 259 +++- 1 fil

[Xen-devel] [PATCH v3 01/10] xen: make xen loader callable multiple times

2016-02-17 Thread Juergen Gross
The loader for xen paravirtualized environment isn't callable multiple times as it won't free any memory in case of failure. Call grub_relocator_unload() as other modules do it before allocating a new relocator or when unloading the module. Signed-off-by: Juergen Gross --- grub-core/loader/i386

[Xen-devel] [PATCH v3 07/10] xen: factor out allocation of page tables into separate function

2016-02-17 Thread Juergen Gross
Do the allocation of page tables in a separate function. This will allow to do the allocation at different times of the boot preparations depending on the features the kernel is supporting. Signed-off-by: Juergen Gross --- grub-core/loader/i386/xen.c | 91

[Xen-devel] [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants

2016-02-17 Thread Juergen Gross
Various features and parameters of a pv-kernel are specified via elf notes in the kernel image. Those notes are part of the interface between the Xen hypervisor and the kernel. Instead of using num,bers in the code when interpreting the elf notes make use of the header supplied by Xen for that pur

[Xen-devel] [PATCH v3 09/10] xen: modify page table construction

2016-02-17 Thread Juergen Gross
Modify the page table construction to allow multiple virtual regions to be mapped. This is done as preparation for removing the p2m list from the initial kernel mapping in order to support huge pv domains. This allows a cleaner approach for mapping the relocator page by using this capability. The

[Xen-devel] [PATCH v6] libxl: allow 'phy' backend to use empty files

2016-02-17 Thread Roger Pau Monne
This was introduced by 97ee1f (~5 years ago), but was probably never surfaced because most people used regular files as CDROM images, so the PHY backend was actually never selected. A year ago this was changed, and now regular RAW files are also handled by the PHY backend, which has made this bug s

[Xen-devel] [PATCH V2 1/3] libxlu_cfg: reject unknown characters following '\'

2016-02-17 Thread Jim Fehlig
When dequoting config strings in xlu__cfgl_dequote(), unknown characters following a '\', and the '\' itself, are discarded. E.g. a disk configuration string containing rbd:pool/image:mon_host=192.168.0.100\:6789 would be dequoted as rbd:pool/image:mon_host=192.168.0.1006789 Instead of disc

[Xen-devel] [PATCH V2 0/3] libxl and docs: small improvements in qdisk support

2016-02-17 Thread Jim Fehlig
This series contains a few improvments related to libxl's support for the various qdisk types. Patch1 is a small fix for libxlu_cfg to error when encountering unknown backslash- escaped characters instead of silently dropping them. Patch2 is actually unrelated and fixes a typo noticed while reviewi

[Xen-devel] [PATCH V2 2/3] docs: fix typo in xl-disk-configuration.txt

2016-02-17 Thread Jim Fehlig
Signed-off-by: Jim Fehlig Acked-by: Ian Campbell --- docs/misc/xl-disk-configuration.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/misc/xl-disk-configuration.txt b/docs/misc/xl-disk-configuration.txt index 6a2118d..29f6ddb 100644 --- a/docs/misc/xl-disk-configurat

[Xen-devel] [PATCH V2 3/3] docs: add more info about target= in disk config

2016-02-17 Thread Jim Fehlig
target= in disk config can be used to convey arbitrary configuration information to backends. Add a bit more info to xl-disk-configuration.txt to clarify this, including some simple nbd and rbd qdisk configurations. Signed-off-by: Jim Fehlig --- docs/misc/xl-disk-configuration.txt | 10 +

Re: [Xen-devel] [PATCH 3/3] docs: add more info about target= in disk config

2016-02-17 Thread Jim Fehlig
On 02/17/2016 03:10 AM, Ian Campbell wrote: > On Tue, 2016-02-16 at 20:54 -0700, Jim Fehlig wrote: >> target= in disk config can be used to convey arbitrary >> configuration information to backends. Add a bit more info >> to xl-disk-configuration.txt to clarify this, including some >> simple nbd an

Re: [Xen-devel] [PATCH 1/3] libxlu_cfg: reject unknown characters following '\'

2016-02-17 Thread Jim Fehlig
On 02/17/2016 03:11 AM, Ian Campbell wrote: > On Wed, 2016-02-17 at 10:05 +, Ian Campbell wrote: >> On Tue, 2016-02-16 at 20:54 -0700, Jim Fehlig wrote: >>> When dequoting config strings in xlu__cfgl_dequote(), unknown >>> characters following a '\', and the '\' itself, are discarded. >>> E.g.

[Xen-devel] Stabilising some tools only HVMOPs?

2016-02-17 Thread Wei Liu
Hi all Tools people are in the process of splitting libxenctrl into a set of stable libraries. One of the proposed libraries is libxendevicemodel which has a collection of APIs that can be used by device model. Currently we use QEMU as reference to extract symbols and go through them one by one.

Re: [Xen-devel] [PATCH V2 1/3] libxlu_cfg: reject unknown characters following '\'

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 17, 2016 at 10:20:57AM -0700, Jim Fehlig wrote: > When dequoting config strings in xlu__cfgl_dequote(), unknown > characters following a '\', and the '\' itself, are discarded. > E.g. a disk configuration string containing > > rbd:pool/image:mon_host=192.168.0.100\:6789 > > would be

Re: [Xen-devel] [PATCH V2 2/3] docs: fix typo in xl-disk-configuration.txt

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 17, 2016 at 10:20:58AM -0700, Jim Fehlig wrote: > Signed-off-by: Jim Fehlig > Acked-by: Ian Campbell applied > --- > docs/misc/xl-disk-configuration.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/misc/xl-disk-configuration.txt > b/docs/misc/xl-di

[Xen-devel] Xen Project Infrastructure Maintenance: Feb 25th and 1st of March

2016-02-17 Thread Lars Kurth
Hi everyone, we are rebooting a number of Xen Project services in the next few days to upgrade operating systems. This means that a few services may be temporarily unavailable. The following websites are affected and will be done during the times below. If you notice any issues after the reboot

Re: [Xen-devel] [PATCH] x86/mm: slightly simplify mod_l1_entry()

2016-02-17 Thread Andrew Cooper
On 17/02/16 16:10, Jan Beulich wrote: > Re-order code to simplify error cleanup. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/5] x86emul: fix rIP handling

2016-02-17 Thread Andrew Cooper
On 17/02/16 16:32, Jan Beulich wrote: > Deal with rIP just like with any other register: Truncate to designated > width upon entry, write back the zero-extended 32-bit value when > emulating 32-bit code, and leave the upper 48 bits unchanged for 16-bit > code. > > Signed-off-by: Jan Beulich Revie

Re: [Xen-devel] [PATCH v5 0/2] Vm-events: move monitor vm-events code to common-side.

2016-02-17 Thread Corneliu ZUZU
On 2/17/2016 5:09 PM, Konrad Rzeszutek Wilk wrote: On Wed, Feb 17, 2016 at 09:33:58AM +0200, Corneliu ZUZU wrote: This patch series is an attempt to move some of the monitor vm-events code to the common-side. Done to make it easier to move additional parts that can be moved to common when ARM-si

Re: [Xen-devel] [PATCH 2/5] x86emul: limit-check branch targets

2016-02-17 Thread Andrew Cooper
On 17/02/16 16:35, Jan Beulich wrote: > All branches need to #GP when their target violates the segment limit > (in 16- and 32-bit modes) or is non-canonical (in 64-bit mode). For > near branches facilitate this via a zero-byte instruction fetch from > the target address (resulting in address trans

Re: [Xen-devel] [PATCH 3/5] x86emul: simplify IRET logic

2016-02-17 Thread Andrew Cooper
On 17/02/16 16:36, Jan Beulich wrote: > Since we only handle real mode, we need to consider neither non-ring0 > nor IOPL. Also for POPF the mode_iopl() check can really be inside the > not-ring-0 body. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___

[Xen-devel] [PATCH v4 2/2] build: convert xenoprof to Kconfig

2016-02-17 Thread Doug Goldstein
Convert the xenoprof x86 build time option to Kconfig. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Reviewed-by: Andrew Cooper Signed-off-by: Doug Goldstein Acked-by: Jan Beulich --- CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper change since v3: - move xenoprof entry to the main

[Xen-devel] [PATCH v4 1/2] xenoprof: fix up ability to disable it

2016-02-17 Thread Doug Goldstein
Allow Xenoprof to be fully disabled when toggling the option off. Signed-off-by: Doug Goldstein --- CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper change since v3: - drop (void)var; from static inlines - fix typo that broke build (must have forgotten to do XEN_CONFIG_EXPERT=y make change s

Re: [Xen-devel] [PATCH 4/5] VMX: fold redundant code

2016-02-17 Thread Andrew Cooper
On 17/02/16 16:37, Jan Beulich wrote: > No need to do this in two slightly different ways, possibly keeping the > compiler from folding the code for us. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -3103,6 +3103,7 @@ void vmx_vmexit_ha

[Xen-devel] [linux-linus test] 82911: regressions - trouble: blocked/broken/fail/pass

2016-02-17 Thread osstest service owner
flight 82911 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/82911/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen6 xen-build fail REGR. vs. 59254 build-amd64-rumpuserx

Re: [Xen-devel] 82599 passthrough problem

2016-02-17 Thread Konrad Rzeszutek Wilk
On Thu, Feb 04, 2016 at 02:42:32PM +0800, Norton.Zhu wrote: > XEN HVM, after it hung, no serial log printed. > it hang in __pirq_guest_unbind. its call stack as follows: > (XEN)[] __pirq_guest_unbind+0x36/0x350 > (XEN)[] __pirq_guest_unbind+0x36/0x350 > (XEN)[] do_invalid_op+0x30b/0x3f0

Re: [Xen-devel] [PATCH 5/5] x86: drop failsafe callback invocation from assembly

2016-02-17 Thread Andrew Cooper
On 17/02/16 16:38, Jan Beulich wrote: > Afaict this was never necessary on a 64-bit hypervisor, and was instead > just blindly cloned over from 32-bit code: We don't fiddle with (and > hence don't reload) any of DS, ES, FS, or GS, and an exception on IRET > itself can equally well be reported to th

[Xen-devel] Is: PVH dom0 - MWAIT detection logic to get deeper C-states exposed in ACPI AML code. Was:Re: [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

2016-02-17 Thread Konrad Rzeszutek Wilk
On Mon, Feb 15, 2016 at 03:41:41PM +, Andrew Cooper wrote: > On 15/02/16 15:02, Jan Beulich wrote: > On 15.02.16 at 15:53, wrote: > >> On 15/02/16 14:50, Jan Beulich wrote: > >> On 15.02.16 at 15:38, wrote: > On 15/02/16 09:20, Jan Beulich wrote: > On 12.02.16 at 18:42,

Re: [Xen-devel] [PATCH v2 17/30] x86/cpu: Common infrastructure for levelling context switching

2016-02-17 Thread Konrad Rzeszutek Wilk
On Fri, Feb 05, 2016 at 01:42:10PM +, Andrew Cooper wrote: > This change is purely scaffolding to reduce the complexity of the following > three patches. Keep in mind that the patches may not be applied right after this. It would be easier to jus spell out the three patches.

Re: [Xen-devel] [PATCH] xenpaging: do not leak if --pagefile given twice

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 17, 2016 at 02:58:33PM +, Ian Campbell wrote: > By freeing filename (which is either NULL or the previous iteration of > this argument). This implements a semantic where the last --pagefile > given on the command line takes precedence. > > This is the same semantic as the other opt

Re: [Xen-devel] [PATCH v4 1/2] xenoprof: fix up ability to disable it

2016-02-17 Thread Andrew Cooper
On 17/02/16 18:02, Doug Goldstein wrote: > Allow Xenoprof to be fully disabled when toggling the option off. > > Signed-off-by: Doug Goldstein > --- > CC: Keir Fraser > CC: Jan Beulich > CC: Andrew Cooper > > change since v3: > - drop (void)var; from static inlines > - fix typo that broke build

Re: [Xen-devel] [PATCH] xenpaging: do not leak if --pagefile given twice

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 17, 2016 at 02:14:38PM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 17, 2016 at 02:58:33PM +, Ian Campbell wrote: > > By freeing filename (which is either NULL or the previous iteration of > > this argument). This implements a semantic where the last --pagefile > > given on the

[Xen-devel] [PATCH] xen: Avoid left shifting into a sign bit

2016-02-17 Thread Andrew Cooper
Clang 3.8 notices, and objects because it is undefined behaviour. "error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]" Use unsigned constants rather than signed ones. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Tim Deegan CC: Ian Campbell CC: Kevi

Re: [Xen-devel] [PATCH v2 24/30] tools/libxc: Modify bitmap operations to take void pointers

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 10, 2016 at 10:07:12AM +, Andrew Cooper wrote: > On 08/02/16 16:36, Ian Campbell wrote: > > On Mon, 2016-02-08 at 16:23 +, Tim Deegan wrote: > >> At 13:42 + on 05 Feb (1454679737), Andrew Cooper wrote: > >>> The type of the pointer to a bitmap is not interesting; it does not

Re: [Xen-devel] Is: PVH dom0 - MWAIT detection logic to get deeper C-states exposed in ACPI AML code. Was:Re: [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

2016-02-17 Thread Boris Ostrovsky
On 02/17/2016 02:02 PM, Konrad Rzeszutek Wilk wrote: On Mon, Feb 15, 2016 at 03:41:41PM +, Andrew Cooper wrote: On 15/02/16 15:02, Jan Beulich wrote: On 15.02.16 at 15:53, wrote: On 15/02/16 14:50, Jan Beulich wrote: On 15.02.16 at 15:38, wrote: On 15/02/16 09:20, Jan Beulich wrote: O

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-17 Thread Luis R. Rodriguez
OK so here's a wiki to keep track of progress of the difference uses: http://kernelnewbies.org/KernelProjects/remove-paravirt-enabled It seems we have a resolution one way or another for all except for the use on arch/x86/mm/dump_pagetables.c, is that right? So to be clear we should not merge mor

Re: [Xen-devel] [PATCH v2 03/11] xen/hvmlite: Initialize HVMlite kernel

2016-02-17 Thread Luis R. Rodriguez
On Mon, Feb 1, 2016 at 7:38 AM, Boris Ostrovsky wrote: > + pv_info.paravirt_enabled = 1; As its being discussed we want to remove paravirt_enabled so this series should not be merged with this: http://kernelnewbies.org/KernelProjects/remove-paravirt-enabled Luis

Re: [Xen-devel] [RFC PATCH 1/7] common/pv-iommu: Add stub hypercall for PV-IOMMU

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 10, 2016 at 10:10:29AM +, Malcolm Crossley wrote: > Signed-off-by: Malcolm Crossley > -- > Cc: jbeul...@suse.com > Cc: andrew.coop...@citrix.com > Cc: ian.campb...@citrix.com > Cc: k...@xen.org > Cc: t...@xen.org > Cc: xen-devel@lists.xen.org > --- > xen/arch/x86/x86_64/compat/ent

Re: [Xen-devel] [RFC PATCH 0/7] Implement Xen PV-IOMMU interface

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 10, 2016 at 10:33:24AM +, Malcolm Crossley wrote: > This RFC series implements the PV-IOMMU interface according to the PV-IOMMU > design draft D. > > The PV-IOMMU interface is currently restricted to being used by the hardware > domain only as non hardware domain callers have not b

[Xen-devel] [linux-3.18 test] 82928: regressions - FAIL

2016-02-17 Thread osstest service owner
flight 82928 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/82928/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 6 xen-build fail REGR. vs. 79037 build-i386-rumpuserxen

Re: [Xen-devel] [RFC PATCH 2/7] iommu: add iommu_lookup_page to lookup guest gfn for a particular IOMMU mapping

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 10, 2016 at 10:10:30AM +, Malcolm Crossley wrote: > If IOMMU driver does not implement lookup_page function then it returns > -ENOMEM. That is a very odd return code. Could you explain why -ENOMEM? > > Returns 0 on success and any other value on failure. > > Signed-off-by: Malc

Re: [Xen-devel] [RFC PATCH 3/7] VT-d: Add iommu_lookup_page support

2016-02-17 Thread Konrad Rzeszutek Wilk
On Wed, Feb 10, 2016 at 10:10:31AM +, Malcolm Crossley wrote: > Function does not need to handle shared EPT use of IOMMU as core code > already handles this. Could you mention which part of 'core code' handles this? Also you may want to say this code can only deal with 4K pages but not with l

[Xen-devel] [PATCH] [VERY RFC] Clang: Issues with .data.rel.ro relocations

2016-02-17 Thread Andrew Cooper
Clang-3.8 generates several .data.rel.ro sections when compiling Xen. c/s eb2952b4 "x86: move alternative.c data fully into .init.*" cited "While at it also drop the non-local section names from SPECIAL_DATA_SECTIONS - they can't be safely converted." without any further information, and google is

Re: [Xen-devel] Adding Xen to the kbuild bot?

2016-02-17 Thread Andy Lutomirski
On Fri, Feb 5, 2016 at 5:17 PM, Fengguang Wu wrote: > On Fri, Feb 05, 2016 at 12:10:56PM -0800, Andy Lutomirski wrote: >> On Feb 4, 2016 7:11 PM, "Fengguang Wu" wrote: >> > >> > Hi Andy, >> > >> > CC more people on Xen testing -- in case OSStest already (or plans to) >> > cover such test case. >>

[Xen-devel] [libvirt test] 82949: tolerable FAIL - PUSHED

2016-02-17 Thread osstest service owner
flight 82949 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/82949/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 guest-saverestorefail never pass test-armhf-armhf-libvirt 12 migrate-sup

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-17 Thread Borislav Petkov
On Wed, Feb 17, 2016 at 12:07:13PM -0800, Luis R. Rodriguez wrote: > OK so here's a wiki to keep track of progress of the difference uses: > > http://kernelnewbies.org/KernelProjects/remove-paravirt-enabled > > It seems we have a resolution one way or another for all except for > the use on arch/

<    1   2   3   >