Re: [Xen-devel] [PATCH v2 1/2] x86/hvm: allow guest to use clflushopt and clwb

2016-01-08 Thread Haozhong Zhang
On 01/07/16 07:34, Jan Beulich wrote: > >>> On 07.01.16 at 15:01, wrote: > > On 07/01/16 13:49, Jan Beulich wrote: > > On 30.12.15 at 12:48, wrote: > >>> --- a/xen/arch/x86/hvm/hvm.c > >>> +++ b/xen/arch/x86/hvm/hvm.c > >>> @@ -4583,21 +4583,30 @@ void hvm_cpuid(unsigned int input, unsigned i

Re: [Xen-devel] [PATCH v2 1/2] x86/hvm: allow guest to use clflushopt and clwb

2016-01-08 Thread Jan Beulich
>>> On 08.01.16 at 09:27, wrote: > On 01/07/16 07:34, Jan Beulich wrote: >> >>> On 07.01.16 at 15:01, wrote: >> > On 07/01/16 13:49, Jan Beulich wrote: >> > On 30.12.15 at 12:48, wrote: >> >>> --- a/xen/arch/x86/hvm/hvm.c >> >>> +++ b/xen/arch/x86/hvm/hvm.c >> >>> @@ -4583,21 +4583,30 @@ voi

Re: [Xen-devel] [PATCH] arch/x86: convert bigmem to Kconfig

2016-01-08 Thread Jan Beulich
>>> On 08.01.16 at 03:55, wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -25,6 +25,18 @@ config ARCH_DEFCONFIG > > menu "Architecture Features" > > +config BIGMEM > + bool "big memory support" > + default n > + ---help--- > + Allows Xen to support up t

Re: [Xen-devel] [PATCH v3 02/13] x86/time.c: Use correct guest TSC frequency in tsc_get_info()

2016-01-08 Thread Jan Beulich
>>> On 04.01.16 at 18:48, wrote: > On 12/30/2015 10:03 PM, Haozhong Zhang wrote: >> When the TSC mode of a HVM container is TSC_MODE_DEFAULT or >> TSC_MODE_PVRDTSCP and no TSC emulation is used, the existing >> tsc_get_info() uses the host TSC frequency (cpu_khz) as the guest TSC >> frequency. How

Re: [Xen-devel] [PATCH v3 02/13] x86/time.c: Use correct guest TSC frequency in tsc_get_info()

2016-01-08 Thread Haozhong Zhang
On 01/08/16 02:05, Jan Beulich wrote: > >>> On 04.01.16 at 18:48, wrote: > > On 12/30/2015 10:03 PM, Haozhong Zhang wrote: > >> When the TSC mode of a HVM container is TSC_MODE_DEFAULT or > >> TSC_MODE_PVRDTSCP and no TSC emulation is used, the existing > >> tsc_get_info() uses the host TSC freque

Re: [Xen-devel] [PATCH v3 04/13] x86/time.c: Scale host TSC in pvclock properly

2016-01-08 Thread Jan Beulich
>>> On 31.12.15 at 04:03, wrote: > This patch makes the pvclock return the scaled host TSC and > corresponding scaling parameters to HVM domains if guest TSC is not > emulated and TSC scaling is enabled. > > Signed-off-by: Haozhong Zhang > --- > Changes in v3: > (addressing Boris Ostrovsky's co

Re: [Xen-devel] [PATCH v3 05/13] svm: Remove redundant TSC scaling in svm_set_tsc_offset()

2016-01-08 Thread Jan Beulich
>>> On 31.12.15 at 04:03, wrote: > @@ -854,6 +841,7 @@ static void svm_set_tsc_offset(struct vcpu *v, u64 > offset, u64 at_tsc) > n2_tsc_offset = vmcb_get_tsc_offset(n2vmcb) - > vmcb_get_tsc_offset(n1vmcb); > if ( svm->ns_tscratio != DEFAULT_TSC_RATIO ) { > +

Re: [Xen-devel] [PATCH v3 03/13] x86/hvm: Scale host TSC when setting/getting guest TSC

2016-01-08 Thread Jan Beulich
>>> On 31.12.15 at 04:03, wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -804,6 +804,16 @@ static uint64_t scale_tsc(uint64_t host_tsc, uint64_t > ratio) > return scaled_host_tsc; > } > > +static uint64_t svm_scale_tsc(struct vcpu *v, uint64_t tsc) > +{

Re: [Xen-devel] [OSSTEST PATCH 3/7] Database locking: Tcl: Use db-execute

2016-01-08 Thread Ian Campbell
On Thu, 2016-01-07 at 19:38 +, Ian Jackson wrote: > Replace open-coded uses of pg_execute dbh STMT with > jobdb::db-execute-array STMT. ITYM jobdb::db-execute? ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [OSSTEST PATCH 5/7] Database locking: Tcl: for errorCode, use pg_exec, not pg_execute

2016-01-08 Thread Ian Campbell
On Thu, 2016-01-07 at 19:38 +, Ian Jackson wrote: > We would like to be able to retry db transactions.  To do this we need > to know why they failed (if they did). > > But pg_execute does not set errorCode.  (This is clearly a bug.)  And > since it immediately discards a failed statement, any

Re: [Xen-devel] [PATCH v3 07/13] x86: Add functions for 64-bit integer arithmetic

2016-01-08 Thread Jan Beulich
>>> On 31.12.15 at 04:03, wrote: > --- /dev/null > +++ b/xen/include/asm-x86/math64.h > @@ -0,0 +1,105 @@ > +#ifndef __X86_MATH64 > +#define __X86_MATH64 > + > +/* > + * Functions defined in this file are derived from Linux kernel > + * (include/linux/math64.h). > + */ This is not true. At least

Re: [Xen-devel] [OSSTEST PATCH 0/7] Better database handling in Tcl

2016-01-08 Thread Ian Campbell
On Thu, 2016-01-07 at 19:38 +, Ian Jackson wrote: > This series arranges for the owner daemon to be able to tolerate > database restarts, and is generally much more careful about database > errors in Tcl. I had a trivial comment on #3's commit message, assuming that rather than the code is wro

Re: [Xen-devel] [PATCH v3 08/13] x86/hvm: Setup TSC scaling ratio

2016-01-08 Thread Jan Beulich
>>> On 31.12.15 at 04:03, wrote: > @@ -301,6 +302,42 @@ int hvm_set_guest_pat(struct vcpu *v, u64 guest_pat) > return 1; > } > > +bool_t hvm_validate_tsc_scaling_ratio(uint32_t gtsc_khz) > +{ > +u64 ratio; > + > +if ( !hvm_funcs.tsc_scaling_supported ) > +return FALSE; We

Re: [Xen-devel] [PATCH v3 2/5] remus: resume immediately if libxl__xc_domain_save_done() completes

2016-01-08 Thread Andrew Cooper
On 08/01/16 06:38, Wen Congyang wrote: > For example: if the secondary host is down, and we fail to send the data to > the secondary host. xc_domain_save() returns 0. So in the function > libxl__xc_domain_save_done(), rc is 0(the helper program exits normally), > and retval is 0(it is xc_domain_sav

Re: [Xen-devel] [PATCH v4.1] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Ian Campbell
On Thu, 2016-01-07 at 17:11 -0500, Boris Ostrovsky wrote: > With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain > builder if supported") location of ramdisk may not be available to > HVMlite guests by the time alloc_magic_pages_hvm() is invoked if the > guest supports unmapped initrd

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Ian Campbell
On Thu, 2016-01-07 at 17:19 -0500, Boris Ostrovsky wrote: > v4: >  * See the last two paragraphs from commit message above > > v4.1: >  * Inverted testing of start_info_size in bootlate_hvm(). > > v4.2 >  * Actually do what I said I'd do in 4.1 I was so proud of myself for spotting 4.1 just bef

[Xen-devel] [xen-4.4-testing test] 77307: regressions - FAIL

2016-01-08 Thread osstest service owner
flight 77307 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/77307/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-prev 5 xen-build fail REGR. vs. 66458 build-i386-prev

[Xen-devel] [PATCH v6] x86/VPMU: implement ipc and arch filter flags

2016-01-08 Thread Brendan Gregg
This introduces a way to have a restricted VPMU, by specifying one of two predefined groups of PMCs to make available. For secure environments, this allows the VPMU to be used without needing to enable all PMCs. Signed-off-by: Brendan Gregg Reviewed-by: Boris Ostrovsky Acked-by: Kevin Tian ---

Re: [Xen-devel] [PATCH 3/3] checkpatch: add virt barriers

2016-01-08 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 02:11:37PM -0800, Joe Perches wrote: > On Mon, 2016-01-04 at 23:07 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 04, 2016 at 08:47:53AM -0800, Joe Perches wrote: > > > On Mon, 2016-01-04 at 13:37 +0200, Michael S. Tsirkin wrote: > > > > Add virt_ barriers to list of barri

[Xen-devel] [PATCH XEN v3 1/2] x86/hvm: allow guest to use clflushopt and clwb

2016-01-08 Thread Haozhong Zhang
Pass CPU features CLFLUSHOPT and CLWB into HVM domain so that those two instructions can be used by guest. The specification of above two instructions can be found in https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf Reviewed-by: Andrew Cooper Reviewed-by: Kevin Tian A

[Xen-devel] [PATCH XEN v3 0/2] add support for vNVDIMM - Part 1: enable instructions

2016-01-08 Thread Haozhong Zhang
I split the previous patch series "[PATCH 0/4] add support for vNVDIMM" into two parts. This is the first part that enables clflushopt/clwb/pcommit instructions for HVM guests. Changes in v3: * Remove unnecessary hypervisor code for clflushopt and clwb in patch 1. * Move the code refactoring in

[Xen-devel] [PATCH XEN v3 2/2] x86/hvm: add support for pcommit instruction

2016-01-08 Thread Haozhong Zhang
Pass PCOMMIT CPU feature into HVM domain. Currently, we do not intercept pcommit instruction for L1 guest, and allow L1 to intercept pcommit instruction for L2 guest. The specification of pcommit instruction can be found in https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pd

[Xen-devel] [linux-mingo-tip-master test] 77311: regressions - FAIL

2016-01-08 Thread osstest service owner
flight 77311 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/77311/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rumpuserxen-i386 10 guest-start fail REGR. vs. 60684 Regression

Re: [Xen-devel] [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-08 Thread Stefano Stabellini
On Thu, 7 Jan 2016, Gerd Hoffmann wrote: > On Do, 2016-01-07 at 13:10 +, Stefano Stabellini wrote: > > CC'ing the Xen x86 maintainers > > > > On Thu, 7 Jan 2016, Gerd Hoffmann wrote: > > > Hi, > > > > > > > One thing I don't like about this is that it is going to skip the checks > > > > don

Re: [Xen-devel] [PATCH XEN v3 0/2] add support for vNVDIMM - Part 1: enable instructions

2016-01-08 Thread Jan Beulich
>>> On 08.01.16 at 11:46, wrote: > I split the previous patch series "[PATCH 0/4] add support for vNVDIMM" > into two parts. This is the first part that enables clflushopt/clwb/pcommit > instructions for HVM guests. > > Changes in v3: > * Remove unnecessary hypervisor code for clflushopt and clw

Re: [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-08 Thread Stefano Stabellini
Since you are at it, could you please let me know how well igd passthrough works without this bugfix: http://marc.info/?l=qemu-devel&m=145172165010604 which is about to land in QEMU. I guess it doesn't work at all? I am asking because I would like to know the level of support we need to provide

[Xen-devel] [xen-unstable-smoke test] 77507: tolerable all pass - PUSHED

2016-01-08 Thread osstest service owner
flight 77507 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/77507/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [qemu-upstream-4.2-testing test] 77180: regressions - FAIL

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("Re: [qemu-upstream-4.2-testing test] 77180: regressions - FAIL"): > So our choices WRT these fixes in qemu-xen.git#staging-4.2, given they have > already been pushed, are: > >4. Force push. We (Ian C, Stefano and myself) had a conversation in which we decided that this

Re: [Xen-devel] [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-08 Thread Stefano Stabellini
On Fri, 8 Jan 2016, Stefano Stabellini wrote: > > > > xen_pt_initfn checks that igd-passthru=on is set in case it finds a igd > > > > device is assigned, that will make sure the igd-isa-bridge is present. > > > > > > > > But, yes, you can create a igd-isa-bridge now even when not assigning a > > >

Re: [Xen-devel] [PATCH 03/28] libxl: Provide libxl__dm_support_*

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 03/28] libxl: Provide libxl__dm_support_*"): > On Tue, 2015-12-22 at 18:44 +, Ian Jackson wrote: > > This allows code elsewhere in libxl to find out what options a device > > model executable supports.  This is done by searching the usage > > message for fixed s

Re: [Xen-devel] [PATCH 21/28] libxl: dm user: Reject attempts to set user!=root with qemu trad

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 21/28] libxl: dm user: Reject attempts to set user!=root with qemu trad"): > On Tue, 2015-12-22 at 18:44 +, Ian Jackson wrote: > > Previously this option would be silently ignored, which is a potential > > security problem (introduced in 84f2fd1b "run QEMU as n

Re: [Xen-devel] [PATCH 21/28] libxl: dm user: Reject attempts to set user!=root with qemu trad

2016-01-08 Thread Ian Campbell
On Fri, 2016-01-08 at 12:16 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 21/28] libxl: dm user: Reject attempts > to set user!=root with qemu trad"): > > On Tue, 2015-12-22 at 18:44 +, Ian Jackson wrote: > > > Previously this option would be silently ignored, which is a > > > po

Re: [Xen-devel] [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-08 Thread Gerd Hoffmann
Hi, > > That is true. Given that the only qemu-xen codebase with igd support is > > 4.7 and 4.7 hasn't been released yet, I am OK with changing the guest > > visible PCI layout. I might ask for your help in backporting the patches > > ;-) What are the 4.7 release plans btw? > One thing that I

Re: [Xen-devel] [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-08 Thread Stefano Stabellini
On Fri, 8 Jan 2016, Gerd Hoffmann wrote: > Hi, > > > > That is true. Given that the only qemu-xen codebase with igd support is > > > 4.7 and 4.7 hasn't been released yet, I am OK with changing the guest > > > visible PCI layout. I might ask for your help in backporting the patches > > > ;-) > >

Re: [Xen-devel] Missing libvirt+libxl functionality (Was: Re: [Xen-users] Programmatic administration of Xen machines)

2016-01-08 Thread Ian Campbell
On Thu, 2016-01-07 at 22:54 -0700, Jim Fehlig wrote: > > > I had even more trouble, e.g. I wasn't able to use non-standard block > > > scripts (neither via /etc/xen/scripts/block-XXX nor via a script > > > parameter) which are mandatory for me. > > Looking at the code it seems like this is still mi

Re: [Xen-devel] [PATCH XEN v3 0/2] add support for vNVDIMM - Part 1: enable instructions

2016-01-08 Thread Haozhong Zhang
On 01/08/16 04:50, Jan Beulich wrote: > >>> On 08.01.16 at 11:46, wrote: > > I split the previous patch series "[PATCH 0/4] add support for vNVDIMM" > > into two parts. This is the first part that enables clflushopt/clwb/pcommit > > instructions for HVM guests. > > > > Changes in v3: > > * Remov

[Xen-devel] [PATCH v3 10/15] xenstore: make use of the "xenstore domain" flag

2016-01-08 Thread Juergen Gross
Create the xenstore domain with the xenstore flag specified. This enables us to test whether such a domain is already running before we create it. As there ought to be only one xenstore in the system we don't need to start another one. Signed-off-by: Juergen Gross --- V3: omit dom0 when checking

[Xen-devel] [PATCH v3 04/15] xenstore: move init-xenstore-domain to tools/helpers

2016-01-08 Thread Juergen Gross
The program init-xenstore-domain to start a xenstore domain instead of the xenstored daemon is built, but not installed. Change that. Move the program to a new tools subdirectory "helpers" to be able to use libxl in a later patch. Otherwise a dependency loop will be created. Signed-off-by: Juerge

[Xen-devel] [PATCH v3 07/15] xenstore: destroy xenstore domain in case of error after creating it

2016-01-08 Thread Juergen Gross
When creating a xenstore domain via init-xenstore-domain destroy it in case of an error occurred after calling xc_domain_create(). Signed-off-by: Juergen Gross Acked-by: Daniel De Graaf --- tools/helpers/init-xenstore-domain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Xen-devel] [PATCH v3 12/15] tools: split up xen-init-dom0.c

2016-01-08 Thread Juergen Gross
Split up tools/helpers/xen-init-dom0.c in order to prepare reusing generation of the json configuration by init-xenstore-domain.c. Signed-off-by: Juergen Gross Acked-by: Ian Campbell --- tools/helpers/Makefile| 2 +- tools/helpers/init-dom-json.c | 59 ++

[Xen-devel] [PATCH v3 01/15] xen: add xenstore domain flag to hypervisor

2016-01-08 Thread Juergen Gross
In order to be able to have full support of a xenstore domain in Xen add a "Xenstore-domain" flag to the hypervisor. This flag must be specified at domain creation time and is returned by XEN_DOMCTL_getdomaininfo. It will allow the domain to retrieve domain information by issuing the XEN_DOMCTL_ge

[Xen-devel] [PATCH v3 06/15] libxl: move xen-init-dom0 to tools/helpers

2016-01-08 Thread Juergen Gross
Move xen-init-dom0 from tools/libxl to tools/helpers, as it is just a helper program. Signed-off-by: Juergen Gross --- V3: adjust .gitignore as requested by Ian Campbell use libxentoollog instead of libxc as requested by Ian Campbell --- .gitignore | 2 +- tool

[Xen-devel] [PATCH v3 05/15] xenstore: adjust coding style of init-xenstore-domain.c

2016-01-08 Thread Juergen Gross
Adjust the coding style of init-xenstore-domain.c to the general Xen coding style. Signed-off-by: Juergen Gross --- tools/helpers/init-xenstore-domain.c | 221 --- 1 file changed, 126 insertions(+), 95 deletions(-) diff --git a/tools/helpers/init-xenstore-domain.

[Xen-devel] [PATCH v3 14/15] tools: don't stop xenstore domain when stopping dom0

2016-01-08 Thread Juergen Gross
When restarting or shutting down dom0 the xendomains script tries to stop all other domains. Don't do this for the xenstore domain, as it might survive a dom0 reboot in the future. The same applies to xl shutdown --all. Here the xenstore domain is flagged as "never stop". Signed-off-by: Juergen G

[Xen-devel] [PATCH v3 02/15] libxc: support new xenstore domain flag in libxc

2016-01-08 Thread Juergen Gross
Support the xenstore domain flag for obtaining domain info. Signed-off-by: Juergen Gross Acked-by: Ian Campbell --- V3: changed name of flag from "xs_domain" to "xenstore" as requested by Ian Campbell --- tools/libxc/include/xenctrl.h | 2 +- tools/libxc/xc_domain.c | 1 + 2 files cha

[Xen-devel] [PATCH v3 03/15] libxl: provide a flag in dominfo to avoid stopping it

2016-01-08 Thread Juergen Gross
Add a "never_stop" flag to dominfo as indicator for the toolstack that this domain is to be kept running. For now it is being set for xenstore domain, but there might be other domains in the future. Signed-off-by: Juergen Gross --- V3: flag in dominfo instead function to get xenstore domid as req

[Xen-devel] [PATCH v3 00/15] xenstore: make it easier to run xenstore in a domain

2016-01-08 Thread Juergen Gross
Xen supports to run xenstore in a dedicated domain. It is, however, a setup which isn't easy to configure. Today flask is required for full functionality and the resulting xenstore domain is not configurable in the same way as the xenstore daemon. This patch series enables running a xenstore domai

[Xen-devel] [PATCH v3 08/15] xenstore: add error messages to init-xenstore-domain

2016-01-08 Thread Juergen Gross
Additional add some diagnostic messages to the program to have an idea why it failed. Signed-off-by: Juergen Gross Acked-by: Ian Campbell Acked-by: Daniel De Graaf --- tools/helpers/init-xenstore-domain.c | 66 ++-- 1 file changed, 64 insertions(+), 2 deletions(

[Xen-devel] [PATCH v3 15/15] docs: document xenstore domain xenstore paths

2016-01-08 Thread Juergen Gross
Add the xenstore domain specific xenstore paths to docs/misc/xenstore-paths.markdown Signed-off-by: Juergen Gross --- docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/misc/xenstore-paths.markdown b/docs/misc/xenstore-paths.markdown index 197

[Xen-devel] [PATCH v3 13/15] xenstore: write xenstore domain data to xenstore

2016-01-08 Thread Juergen Gross
After starting the xenstore domain write the basic data (domid, name and memory values) to the xenstore. This makes the domain appear correctly in xl list. Create a stub json object in order to make e.g. xl list -l happy. Add a new option to init-xenstore-domain to be able to specify the domain's

[Xen-devel] [PATCH v3 09/15] xenstore: modify init-xenstore-domain parameter syntax

2016-01-08 Thread Juergen Gross
init-xenstore-domain takes only positional parameters today. Change this to a more flexible parameter syntax allowing to specify additional options or to omit some. Today the supported usage is: init-xenstore-domain [] Modify this to: init-xenstore-domain --kernel

[Xen-devel] [PATCH v3 11/15] xenstore: add init-xenstore-domain parameter to specify cmdline

2016-01-08 Thread Juergen Gross
Add a parameter to init-xenstore-domain for support of arbitrary parameters for the xenstore domain. Signed-off-by: Juergen Gross Acked-by: Ian Campbell Acked-by: Daniel De Graaf --- tools/helpers/init-xenstore-domain.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) dif

[Xen-devel] [distros-debian-jessie test] 38603: tolerable FAIL

2016-01-08 Thread Platform Team regression test user
flight 38603 distros-debian-jessie real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38603/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-amd64-jessie-netboot-pvgrub 10 guest-startfail like 38579 Tests which did

Re: [Xen-devel] [PATCH v3 04/13] x86/time.c: Scale host TSC in pvclock properly

2016-01-08 Thread Haozhong Zhang
On 01/08/16 02:20, Jan Beulich wrote: > >>> On 31.12.15 at 04:03, wrote: > > This patch makes the pvclock return the scaled host TSC and > > corresponding scaling parameters to HVM domains if guest TSC is not > > emulated and TSC scaling is enabled. > > > > Signed-off-by: Haozhong Zhang > > ---

Re: [Xen-devel] [PATCH v3 05/13] svm: Remove redundant TSC scaling in svm_set_tsc_offset()

2016-01-08 Thread Haozhong Zhang
On 01/08/16 02:22, Jan Beulich wrote: > >>> On 31.12.15 at 04:03, wrote: > > @@ -854,6 +841,7 @@ static void svm_set_tsc_offset(struct vcpu *v, u64 > > offset, u64 at_tsc) > > n2_tsc_offset = vmcb_get_tsc_offset(n2vmcb) - > > vmcb_get_tsc_offset(n1vmcb); > > if ( sv

[Xen-devel] [xen-4.3-testing test] 77314: regressions - FAIL

2016-01-08 Thread osstest service owner
flight 77314 xen-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/77314/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-prev 5 xen-build fail REGR. vs. 65650 build-i386-prev

Re: [Xen-devel] [PATCH XEN v3 0/2] add support for vNVDIMM - Part 1: enable instructions

2016-01-08 Thread Jan Beulich
>>> On 08.01.16 at 14:03, wrote: > On 01/08/16 04:50, Jan Beulich wrote: >> >>> On 08.01.16 at 11:46, wrote: >> > * Move the code refactoring in hvm_cpuid() to patch 2. >> > * Replace checking host cpuid by checking VMX capabilities for pcommit. >> >> Replace? > > Yes, akin to how MPX is chec

Re: [Xen-devel] [PATCH v3 04/13] x86/time.c: Scale host TSC in pvclock properly

2016-01-08 Thread Jan Beulich
>>> On 08.01.16 at 14:22, wrote: > On 01/08/16 02:20, Jan Beulich wrote: >> >>> On 31.12.15 at 04:03, wrote: >> > --- a/xen/arch/x86/time.c >> > +++ b/xen/arch/x86/time.c >> > @@ -815,10 +815,18 @@ static void __update_vcpu_system_time(struct vcpu >> > *v, int force) >> > } >> > else >

Re: [Xen-devel] [PATCH v3 07/13] x86: Add functions for 64-bit integer arithmetic

2016-01-08 Thread Haozhong Zhang
On 01/08/16 02:34, Jan Beulich wrote: > >>> On 31.12.15 at 04:03, wrote: > > --- /dev/null > > +++ b/xen/include/asm-x86/math64.h > > @@ -0,0 +1,105 @@ > > +#ifndef __X86_MATH64 > > +#define __X86_MATH64 > > + > > +/* > > + * Functions defined in this file are derived from Linux kernel > > + * (in

Re: [Xen-devel] [PATCH v3 04/13] x86/time.c: Scale host TSC in pvclock properly

2016-01-08 Thread Haozhong Zhang
On 01/08/16 06:43, Jan Beulich wrote: > >>> On 08.01.16 at 14:22, wrote: > > On 01/08/16 02:20, Jan Beulich wrote: > >> >>> On 31.12.15 at 04:03, wrote: > >> > --- a/xen/arch/x86/time.c > >> > +++ b/xen/arch/x86/time.c > >> > @@ -815,10 +815,18 @@ static void __update_vcpu_system_time(struct vcpu

Re: [Xen-devel] [PATCH v3 08/13] x86/hvm: Setup TSC scaling ratio

2016-01-08 Thread Haozhong Zhang
On 01/08/16 02:44, Jan Beulich wrote: > >>> On 31.12.15 at 04:03, wrote: > > @@ -301,6 +302,42 @@ int hvm_set_guest_pat(struct vcpu *v, u64 guest_pat) > > return 1; > > } > > > > +bool_t hvm_validate_tsc_scaling_ratio(uint32_t gtsc_khz) > > +{ > > +u64 ratio; > > + > > +if ( !hvm_f

Re: [Xen-devel] [PATCH v3 08/13] x86/hvm: Setup TSC scaling ratio

2016-01-08 Thread Jan Beulich
>>> On 08.01.16 at 14:55, wrote: > On 01/08/16 02:44, Jan Beulich wrote: >> >>> On 31.12.15 at 04:03, wrote: >> > +ratio = mul_u64_u32_div(1ULL << hvm_funcs.tsc_scaling_ratio_frac_bits, >> > +gtsc_khz, cpu_khz); >> > + >> > +return (!ratio || ratio > hvm_funcs.

Re: [Xen-devel] [PATCH v3 03/13] x86/hvm: Scale host TSC when setting/getting guest TSC

2016-01-08 Thread Haozhong Zhang
On 01/08/16 02:15, Jan Beulich wrote: > >>> On 31.12.15 at 04:03, wrote: > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -804,6 +804,16 @@ static uint64_t scale_tsc(uint64_t host_tsc, uint64_t > > ratio) > > return scaled_host_tsc; > > } > > > > +static ui

Re: [Xen-devel] [PATCH v3 01/15] xen: add xenstore domain flag to hypervisor

2016-01-08 Thread Jan Beulich
>>> On 08.01.16 at 14:08, wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -318,6 +318,12 @@ struct domain *domain_create(domid_t domid, unsigned int > domcr_flags, > hardware_domain = d; > } > > +if ( domcr_flags & DOMCRF_xs_domain ) > +{ > +d->

Re: [Xen-devel] [PATCH v3 08/13] x86/hvm: Setup TSC scaling ratio

2016-01-08 Thread Haozhong Zhang
On 01/08/16 07:04, Jan Beulich wrote: > >>> On 08.01.16 at 14:55, wrote: > > On 01/08/16 02:44, Jan Beulich wrote: > >> >>> On 31.12.15 at 04:03, wrote: > >> > +ratio = mul_u64_u32_div(1ULL << > >> > hvm_funcs.tsc_scaling_ratio_frac_bits, > >> > +gtsc_khz, cpu_khz

Re: [Xen-devel] [PATCH 25/28] libxl: emuids: Perhaps change dm xs control path

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 25/28] libxl: emuids: Perhaps change dm xs control path"): > So, do I understand correctly that the states (combinations of bits) are: No. > Describing SPLIT as an "ID" is a bit odd (it's a kind of meta thing) but I > suppose I can see why it is done this way. An

[Xen-devel] [libvirt test] 77324: tolerable FAIL - PUSHED

2016-01-08 Thread osstest service owner
flight 77324 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/77324/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-libvirt-vhd 9 debian-di-installfail like 77211 Tests which did not succeed, but a

Re: [Xen-devel] [PATCH] arch/x86: convert bigmem to Kconfig

2016-01-08 Thread Doug Goldstein
On 1/8/16 2:50 AM, Jan Beulich wrote: On 08.01.16 at 03:55, wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -25,6 +25,18 @@ config ARCH_DEFCONFIG >> >> menu "Architecture Features" >> >> +config BIGMEM >> +bool "big memory support" >> +default n >> +-

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Boris Ostrovsky
On 01/07/2016 11:57 PM, Juergen Gross wrote: On 07/01/16 23:19, Boris Ostrovsky wrote: With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain builder if supported") location of ramdisk may not be available to HVMlite guests by the time alloc_magic_pages_hvm() is invoked if the guest

Re: [Xen-devel] [PATCH v3 01/15] xen: add xenstore domain flag to hypervisor

2016-01-08 Thread Juergen Gross
On 08/01/16 15:07, Jan Beulich wrote: On 08.01.16 at 14:08, wrote: >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -318,6 +318,12 @@ struct domain *domain_create(domid_t domid, unsigned >> int domcr_flags, >> hardware_domain = d; >> } >> >> +if ( domcr_fla

Re: [Xen-devel] [PATCH v4.1] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Boris Ostrovsky
On 01/08/2016 04:56 AM, Ian Campbell wrote: On Thu, 2016-01-07 at 17:11 -0500, Boris Ostrovsky wrote: With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain builder if supported") location of ramdisk may not be available to HVMlite guests by the time alloc_magic_pages_hvm() is invoke

Re: [Xen-devel] [PATCH v3 01/15] xen: add xenstore domain flag to hypervisor

2016-01-08 Thread Andrew Cooper
On 08/01/16 14:22, Juergen Gross wrote: > On 08/01/16 15:07, Jan Beulich wrote: > On 08.01.16 at 14:08, wrote: >>> --- a/xen/common/domain.c >>> +++ b/xen/common/domain.c >>> @@ -318,6 +318,12 @@ struct domain *domain_create(domid_t domid, unsigned >>> int domcr_flags, >>> hardware_d

[Xen-devel] [PATCH RFC OSSTEST v1 01/12] Debian: Abolish $suite and $xopts{Suite} from preseed_* interfaces.

2016-01-08 Thread Ian Campbell
Generating a preseed for a suite which does not match the ->{Suite} of the underlying guest or host object does not seem useful, so remove this option and use ->{Suite} instead. For guests ->{Suite} is set by debian_guest_suite() (which is called from preseed_guest_create(), although it is often a

[Xen-devel] [PATCH RFC OSSTEST v1 11/12] mfi-common: usual_debianhvm_image: derive version from $guestsuite

2016-01-08 Thread Ian Campbell
This more likely matches the callers intention. Move the setting into production-config* alongside the Suite and TftpDiVersion settings. Continue to support $DEBIAN_IMAGE_VERSION as an override. The value for Wheezy is from what was replaced in 610ea1628363 "Switch to Debian 8.0 (jessie) as OS for

[Xen-devel] [PATCH RFC OSSTEST v1 05/12] make-*flight: Abolish $defsuite and $guestdefsuite

2016-01-08 Thread Ian Campbell
Instead have mfi-common set $suite or $guestsuite if it is unset. When doing so move the use of local to this point, using local at the top of the function would shadow any attempt to set a global value, while restricting it only to when setting the default means it doesn't leak. NB "local" scopes

[Xen-devel] [PATCH RFC OSSTEST v1 07/12] ts-debian-di-install: Allow Di Version to come from runvars

2016-01-08 Thread Ian Campbell
and following the lead of the suite arrange for a version selected from the defaults to be written back to the runvars. Signed-off-by: Ian Campbell --- Osstest/Debian.pm| 15 ++- ts-debian-di-install | 3 ++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/Osstes

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Juergen Gross
On 08/01/16 15:19, Boris Ostrovsky wrote: > On 01/07/2016 11:57 PM, Juergen Gross wrote: >> On 07/01/16 23:19, Boris Ostrovsky wrote: >>> With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain >>> builder if supported") location of ramdisk may not be available to >>> HVMlite guests by t

[Xen-devel] [PATCH RFC OSSTEST v1 04/12] mfi-common: always add host suite to hostos_runvars

2016-01-08 Thread Ian Campbell
This avoids situations where production-config* has changed DebianSuite but the bisector is still picking up baselines etc from before the change and reusing their runvars (without suite) with an inconsistent config. Switch selecthost() to use target_var when querying the suite. This means it will

[Xen-devel] [PATCH RFC OSSTEST v1 02/12] target_var: Support fallback to all_(guest|host)_$vn

2016-01-08 Thread Ian Campbell
Having to set {ident}_foo for all idents used in a job (e.g host vs src_host+dst_host) in make-flight would be a little fiddly. Instead follow the lead of all_hostflags and consult all_host_$vn. I have no immediate use for all_guest_$vn, but support it for consistency. Signed-off-by: Ian Campbel

[Xen-devel] [PATCH RFC OSSTEST v1 09/12] mfi-common: Set diversion for build & test host install

2016-01-08 Thread Ian Campbell
This means that bisections will use the same version, even if production-config changed in the mean time. Signed-off-by: Ian Campbell --- mfi-common | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/mfi-common b/mfi-common index 44e7b3e..c1c4ec5 100644 --- a/mfi-c

[Xen-devel] [PATCH RFC OSSTEST v1 03/12] mfi-common: Rename $suite_runvars as $hostos_runvars

2016-01-08 Thread Ian Campbell
Later in the series more runvars to control the host install will be added. Signed-off-by: Ian Campbell --- mfi-common | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/mfi-common b/mfi-common index b739c7d..ccf8a5b 100644 --- a/mfi-common +++ b/mf

[Xen-devel] [PATCH RFC OSSTEST v1 12/12] make-flight: Use older Debian for host and guest OS with older Xen

2016-01-08 Thread Ian Campbell
Sometimes when updating osstest to use a newer version of Debian as a baseline we find that the new compiler or other tools pickup latent errors in older code bases for which the fixes are invasive or otherwise inappropriate for a stable branch. This is the case with Debian Jessie and Xen 4.3 and

[Xen-devel] [PATCH RFC OSSTEST v1 08/12] make-flight: Set diversion runvar on d-i based test jobs.

2016-01-08 Thread Ian Campbell
Note that make-distros-flight does not want this, since it uses d-i fetched from the web not the version in our config. Signed-off-by: Ian Campbell --- make-flight | 5 + 1 file changed, 5 insertions(+) diff --git a/make-flight b/make-flight index 50abf97..3b3950a 100755 --- a/make-flight +

[Xen-devel] [PATCH RFC OSSTEST v1 10/12] Qualify TftpDiVersion with the suite.

2016-01-08 Thread Ian Campbell
This allows the version to differ e.g. between Wheezy and Jessie. Update production-config* to set TftpDiVersion_jessie instead of just TftpDiVersion, also add TftpDiVersion_wheezy using the version replaced in commit f610ea162836 "Switch to Debian 8.0 (jessie) as OS for test hosts". In mfi-commo

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Ian Campbell
On Fri, 2016-01-08 at 09:19 -0500, Boris Ostrovsky wrote: > index 2460818..cac4698 100644 > > > --- a/tools/libxc/include/xc_dom.h > > > +++ b/tools/libxc/include/xc_dom.h > > > @@ -71,6 +71,7 @@ struct xc_dom_image { > > >   > > >   /* arguments and parameters */ > > >   char *cmdline; >

[Xen-devel] [PATCH RFC OSSTEST v1 06/12] ts-host-install: Support DiVersion coming from runvars

2016-01-08 Thread Ian Campbell
To do so initialise $ho->{DiVersion} in select host and use it in ts-host-install. Signed-off-by: Ian Campbell --- Osstest/TestSupport.pm | 1 + ts-host-install| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 3923

Re: [Xen-devel] [PATCH 26/28] libxl: spawns two QEMUs for HVM guests

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 26/28] libxl: spawns two QEMUs for HVM guests"): > On Tue, 2015-12-22 at 18:45 +, Ian Jackson wrote: > > @@ -440,6 +442,15 @@ static int domcreate_setdefault_dm_user(libxl__gc > > *gc, > > +if (!libxl__dm_supported(gc, dm, > > libxl__dm_support_check__emula

[Xen-devel] [PATCH v2] tools/libxc: Adjust error handling in map_p2m_list() to fix CentOS 7 build

2016-01-08 Thread Andrew Cooper
The "goto err;" for malloc() error handling would cause the cleanup code to use 'ptes' before it had been initialised, and causing a build failure because of -Werror=maybe-uninitialised. Use "goto err;" consistently for all error handling. Signed-off-by: Andrew Cooper --- CC: Ian Campbell CC: I

Re: [Xen-devel] [PATCH 28/28] libxl: xsrestrict QEMU

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 28/28] libxl: xsrestrict QEMU"): > On Tue, 2015-12-22 at 18:45 +, Ian Jackson wrote: > > If QEMU supports xsrestrict, pass xsrestrict=on to it (by default). > > > > XXX We need to do this only if xenstored supports it, and AFAICT there > > is not a particularly

Re: [Xen-devel] [PATCH 25/28] libxl: emuids: Perhaps change dm xs control path

2016-01-08 Thread Ian Campbell
On Fri, 2016-01-08 at 14:12 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 25/28] libxl: emuids: Perhaps change dm > xs control path"): > > So, do I understand correctly that the states (combinations of bits) > > are: > > No. > > > Describing SPLIT as an "ID" is a bit odd (it's a ki

Re: [Xen-devel] [PATCH v2] tools/libxc: Adjust error handling in map_p2m_list() to fix CentOS 7 build

2016-01-08 Thread Juergen Gross
On 08/01/16 15:38, Andrew Cooper wrote: > The "goto err;" for malloc() error handling would cause the cleanup code > to use 'ptes' before it had been initialised, and causing a build > failure because of -Werror=maybe-uninitialised. > > Use "goto err;" consistently for all error handling. > > Sig

Re: [Xen-devel] [PATCH 25/28] libxl: emuids: Perhaps change dm xs control path

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH 25/28] libxl: emuids: Perhaps change dm xs control path"): > On Fri, 2016-01-08 at 14:12 +, Ian Jackson wrote: > >   * In xenstore we record which qemus a domain has.  This is necessary > >   * for correct teardown.  And, we also record whether the xenstore > >

Re: [Xen-devel] [PATCH 25/28] libxl: emuids: Perhaps change dm xs control path

2016-01-08 Thread Ian Campbell
On Fri, 2016-01-08 at 14:45 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 25/28] libxl: emuids: Perhaps change dm > xs control path"): > > On Fri, 2016-01-08 at 14:12 +, Ian Jackson wrote: > > >   * In xenstore we record which qemus a domain has.  This is > > > necessary > > >  

Re: [Xen-devel] [PATCH 26/28] libxl: spawns two QEMUs for HVM guests

2016-01-08 Thread Ian Campbell
On Fri, 2016-01-08 at 14:35 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH 26/28] libxl: spawns two QEMUs for HVM > guests"): > > On Tue, 2015-12-22 at 18:45 +, Ian Jackson wrote: > > > @@ -440,6 +442,15 @@ static int > > > domcreate_setdefault_dm_user(libxl__gc > > > *gc, > > > +

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Boris Ostrovsky
On 01/08/2016 09:30 AM, Juergen Gross wrote: On 08/01/16 15:19, Boris Ostrovsky wrote: On 01/07/2016 11:57 PM, Juergen Gross wrote: On 07/01/16 23:19, Boris Ostrovsky wrote: With commit 8c45adec18e0 ("libxc: create unmapped initrd in domain builder if supported") location of ramdisk may not be

Re: [Xen-devel] [PATCH RFC OSSTEST v1 01/12] Debian: Abolish $suite and $xopts{Suite} from preseed_* interfaces.

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("[PATCH RFC OSSTEST v1 01/12] Debian: Abolish $suite and $xopts{Suite} from preseed_* interfaces."): > Generating a preseed for a suite which does not match the ->{Suite} of > the underlying guest or host object does not seem useful, so remove > this option and use ->{Suite} i

Re: [Xen-devel] [PATCH RFC OSSTEST v1 02/12] target_var: Support fallback to all_(guest|host)_$vn

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("[PATCH RFC OSSTEST v1 02/12] target_var: Support fallback to all_(guest|host)_$vn"): > Having to set {ident}_foo for all idents used in a job (e.g host vs > src_host+dst_host) in make-flight would be a little fiddly. Acked-by: Ian Jackson _

Re: [Xen-devel] [PATCH RFC OSSTEST v1 03/12] mfi-common: Rename $suite_runvars as $hostos_runvars

2016-01-08 Thread Ian Jackson
Ian Campbell writes ("[PATCH RFC OSSTEST v1 03/12] mfi-common: Rename $suite_runvars as $hostos_runvars"): > Later in the series more runvars to control the host install will be > added. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists

Re: [Xen-devel] [PATCH v6] x86/VPMU: implement ipc and arch filter flags

2016-01-08 Thread Boris Ostrovsky
On 01/08/2016 05:15 AM, Brendan Gregg wrote: This introduces a way to have a restricted VPMU, by specifying one of two predefined groups of PMCs to make available. For secure environments, this allows the VPMU to be used without needing to enable all PMCs. Signed-off-by: Brendan Gregg Reviewed-

Re: [Xen-devel] [PATCH v4.2] libxc: Defer initialization of start_page for HVM guests

2016-01-08 Thread Ian Campbell
On Fri, 2016-01-08 at 09:53 -0500, Boris Ostrovsky wrote: > On 01/08/2016 09:30 AM, Juergen Gross wrote: > > On 08/01/16 15:19, Boris Ostrovsky wrote: > > > On 01/07/2016 11:57 PM, Juergen Gross wrote: > > > > On 07/01/16 23:19, Boris Ostrovsky wrote: > > > > > With commit 8c45adec18e0 ("libxc: cre

  1   2   >