Re: [Xen-devel] [PATCH v4 31/31] libxl: allow the creation of HVM domains without a device model.

2015-08-10 Thread Paul Durrant
> -Original Message- > From: xen-devel-boun...@lists.xen.org [mailto:xen-devel- > boun...@lists.xen.org] On Behalf Of Andrew Cooper > Sent: 07 August 2015 19:42 > To: Wei Liu; Roger Pau Monne > Cc: xen-de...@lists.xenproject.org; Ian Jackson; Ian Campbell; Stefano > Stabellini > Subject: Re

[Xen-devel] [PATCH for-4.6 v2 4/4] oxenstored: move sd_notify_ready out of main loop

2015-08-10 Thread Wei Liu
Oxenstored only needs to notify systemd its readiness state once. Move sd_notify_ready out of main loop. Signed-off-by: Wei Liu Acked-by: Dave Scott --- For 4.6: avoid wasting CPU cycles, easy to reason its correctness. There is a small risk that either I wrote the wrong code or I misunderstand

[Xen-devel] [PATCH for-4.6 v2 3/4] oxenstored: fix systemd socket activation

2015-08-10 Thread Wei Liu
Use the correct API sd_listen_fds to determine whether the process is started by systemd. Change sd_booted to launched_by_systemd to avoid confusion with systemd's API. Signed-off-by: Wei Liu Acked-by: Dave Scott Acked-by: Ian Campbell --- For 4.6: without this oxenstored is broken when runni

[Xen-devel] [PATCH for-4.6 v2 0/4] Patches for c/oxenstored

2015-08-10 Thread Wei Liu
Wei Liu (4): cxenstored: fix systemd socket activation cxenstored: document a bunch of short options in help string oxenstored: fix systemd socket activation oxenstored: move sd_notify_ready out of main loop tools/ocaml/xenstored/systemd.ml | 2 +- tools/ocaml/xenstored/systemd.mli

[Xen-devel] [PATCH for-4.6 v2 2/4] cxenstored: document a bunch of short options in help string

2015-08-10 Thread Wei Liu
Signed-off-by: Wei Liu Acked-by: Ian Campbell --- For 4.6: pure doc changes, risk free. --- tools/xenstore/xenstored_core.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index

[Xen-devel] [PATCH for-4.6 v2 1/4] cxenstored: fix systemd socket activation

2015-08-10 Thread Wei Liu
There were two problems with original code: 1. sd_booted() was used to determined if the process was started by systemd, which was wrong. 2. Exit with error if pidfile was specified, which was too harsh. These two combined made cxenstored unable to start by hand if it ran on a system which had

Re: [Xen-devel] [PATCH for-4.6 v2 4/4] oxenstored: move sd_notify_ready out of main loop

2015-08-10 Thread Andrew Cooper
On 10/08/2015 09:00, Wei Liu wrote: > Oxenstored only needs to notify systemd its readiness state once. Move > sd_notify_ready out of main loop. > > Signed-off-by: Wei Liu > Acked-by: Dave Scott > --- > For 4.6: avoid wasting CPU cycles, easy to reason its correctness. > > There is a small risk t

Re: [Xen-devel] [PATCH for-4.6 v2 4/4] oxenstored: move sd_notify_ready out of main loop

2015-08-10 Thread Wei Liu
On Mon, Aug 10, 2015 at 09:04:20AM +0100, Andrew Cooper wrote: > On 10/08/2015 09:00, Wei Liu wrote: > > Oxenstored only needs to notify systemd its readiness state once. Move > > sd_notify_ready out of main loop. > > > > Signed-off-by: Wei Liu > > Acked-by: Dave Scott > > --- > > For 4.6: avoid

Re: [Xen-devel] [PATCH v3 1/2] Differentiate IO/mem resources tracked by ioreq server

2015-08-10 Thread Wei Liu
On Mon, Aug 10, 2015 at 11:33:40AM +0800, Yu Zhang wrote: > Currently in ioreq server, guest write-protected ram pages are > tracked in the same rangeset with device mmio resources. Yet > unlike device mmio, which can be in big chunks, the guest write- > protected pages may be discrete ranges with

[Xen-devel] [xen-unstable test] 60639: tolerable FAIL

2015-08-10 Thread osstest service owner
flight 60639 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/60639/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail like 60624 test-amd64-amd64-

[Xen-devel] OSSTest-- Leases::check_ip() ignore guest free IP

2015-08-10 Thread Hu, Robert
Hi, Say such a leases file: lease 192.168.199.124 { starts 4 2015/08/06 08:46:50; ends 4 2015/08/06 08:58:50; cltt 4 2015/08/06 08:46:50; binding state active; next binding state free; hardware ethernet 5e:36:0e:f5:00:02; uid "\001^6\016\365\000\002"; } lease 192.168.199.242 { star

Re: [Xen-devel] [PATCH v3 1/2] Differentiate IO/mem resources tracked by ioreq server

2015-08-10 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 10 August 2015 09:26 > To: Yu Zhang > Cc: xen-devel@lists.xen.org; Paul Durrant; Ian Jackson; Stefano Stabellini; > Ian > Campbell; Wei Liu; Keir (Xen.org); jbeul...@suse.com; Andrew Cooper; > Kevin Tian; zhiyuan...@

Re: [Xen-devel] [xen 4.6 retrospective] More public/easy to find information about the release schedule

2015-08-10 Thread Wei Liu
On Fri, Aug 07, 2015 at 05:36:57PM +0200, Roger Pau Monné wrote: > = Issue / Observation = > > The information about the release schedule is not clearly published > anywhere apart from the mailing lists, which makes it hard for > non-developers (or even for developers) given that the mailing list

Re: [Xen-devel] [RFC 1/4] HVM x86 deprivileged mode: Page allocation helper

2015-08-10 Thread Tim Deegan
Hi, At 10:57 +0100 on 07 Aug (1438945038), Ben Catterall wrote: > On 06/08/15 20:22, Andrew Cooper wrote: > > On 06/08/15 17:45, Ben Catterall wrote: > >> This allocation function is used by the deprivileged mode initialisation > >> code > >> to allocate pages for the new page table mappings and

Re: [Xen-devel] [RFC 1/4] HVM x86 deprivileged mode: Page allocation helper

2015-08-10 Thread Tim Deegan
At 09:50 +0100 on 10 Aug (1439200241), Tim Deegan wrote: > Hi, > > At 10:57 +0100 on 07 Aug (1438945038), Ben Catterall wrote: > > On 06/08/15 20:22, Andrew Cooper wrote: > > > On 06/08/15 17:45, Ben Catterall wrote: > > >> This allocation function is used by the deprivileged mode initialisation

Re: [Xen-devel] [RFC 1/4] HVM x86 deprivileged mode: Page allocation helper

2015-08-10 Thread Andrew Cooper
On 10/08/2015 09:52, Tim Deegan wrote: > At 09:50 +0100 on 10 Aug (1439200241), Tim Deegan wrote: >> Hi, >> >> At 10:57 +0100 on 07 Aug (1438945038), Ben Catterall wrote: >>> On 06/08/15 20:22, Andrew Cooper wrote: On 06/08/15 17:45, Ben Catterall wrote: > This allocation function is used

Re: [Xen-devel] Linux 4.2-rc5:

2015-08-10 Thread Ross Lagerwall
On 08/06/2015 08:51 PM, li...@eikelenboom.it wrote: Hi Ross, On my dom0 with a linux 4.2-rc5 kernel i encoutered the splat below. It's probably related to your patch that went in just for 4.2-rc5: "xen/events/fifo: Handle linked events when closing a port" -- Sander [ 49.020173]

Re: [Xen-devel] [xen 4.6 retrospective] More public/easy to find information about the release schedule

2015-08-10 Thread Lars Kurth
> On 10 Aug 2015, at 09:33, Wei Liu wrote: > > On Fri, Aug 07, 2015 at 05:36:57PM +0200, Roger Pau Monné wrote: >> = Issue / Observation = >> >> The information about the release schedule is not clearly published >> anywhere apart from the mailing lists, which makes it hard for >> non-developer

Re: [Xen-devel] Can I xc_await_suspend() for a suspend event caused by another application?

2015-08-10 Thread Razvan Cojocaru
> I've noticed that the xc_suspend_evtchn_init() functions in xenguest.h > connect the client application to a guest suspend event channel, and > that it's possible to subscribe to these events, in theory even if you > never signal the channel (i.e. even if you don't issue a suspend request). > >

Re: [Xen-devel] [xen 4.6 retrospective] More public/easy to find information about the release schedule

2015-08-10 Thread Fabio Fantoni
Il 10/08/2015 11:06, Lars Kurth ha scritto: On 10 Aug 2015, at 09:33, Wei Liu wrote: On Fri, Aug 07, 2015 at 05:36:57PM +0200, Roger Pau Monné wrote: = Issue / Observation = The information about the release schedule is not clearly published anywhere apart from the mailing lists, which makes

Re: [Xen-devel] [RFC 3/4] HVM x86 deprivileged mode: Code for switching into/out of deprivileged mode

2015-08-10 Thread Tim Deegan
Hi, At 17:45 +0100 on 06 Aug (1438883118), Ben Catterall wrote: > The process to switch into and out of deprivileged mode can be likened to > setjmp/longjmp. > > To enter deprivileged mode, we take a copy of the stack from the guest's > registers up to the current stack pointer. This copy is pre

Re: [Xen-devel] Can I xc_await_suspend() for a suspend event caused by another application?

2015-08-10 Thread Andrew Cooper
On 10/08/15 10:28, Razvan Cojocaru wrote: >> I've noticed that the xc_suspend_evtchn_init() functions in xenguest.h >> connect the client application to a guest suspend event channel, and >> that it's possible to subscribe to these events, in theory even if you >> never signal the channel (i.e. eve

Re: [Xen-devel] [PATCH v3 18/20] net/xen-netback: Make it running on 64KB page granularity

2015-08-10 Thread Julien Grall
Hi Wei, On 08/08/2015 15:55, Wei Liu wrote: struct xenvif_rx_meta { int id; @@ -80,16 +81,18 @@ struct xenvif_rx_meta { /* Discriminate from any valid pending_idx value. */ #define INVALID_PENDING_IDX 0x -#define MAX_BUFFER_OFFSET PAGE_SIZE +#define MAX_BUFFER_OFFSET XEN_PAGE_

Re: [Xen-devel] [PATCH v3 9/9] xen/xenbus: Rename the variable xen_store_mfn to xen_store_gfn

2015-08-10 Thread Julien Grall
Hi Boris, On 07/08/2015 22:33, Boris Ostrovsky wrote: On 08/07/2015 12:34 PM, Julien Grall wrote: The variable xen_store_mfn is effectively storing a GFN and not an MFN. Signed-off-by: Julien Grall --- Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel I think that the a

Re: [Xen-devel] Can I xc_await_suspend() for a suspend event caused by another application?

2015-08-10 Thread Razvan Cojocaru
On 08/10/2015 12:52 PM, Andrew Cooper wrote: > On 10/08/15 10:28, Razvan Cojocaru wrote: >>> I've noticed that the xc_suspend_evtchn_init() functions in xenguest.h >>> connect the client application to a guest suspend event channel, and >>> that it's possible to subscribe to these events, in theory

Re: [Xen-devel] [PATCH v6 0/6] xen/PMU: PMU support for Xen PV(H) guests

2015-08-10 Thread Stefano Stabellini
On Sun, 9 Aug 2015, Boris Ostrovsky wrote: > Changes in v6: > * Fix ARM builds (as suggested by Julien): > o Make XEN_SYMS depend on X86 (patch 1) > o Add CONFIG_XEN_HAVE_PVMMU and use it in drivers/xen/sys-hypervisor.c > (patch 2) > * Adjust release dates in Documentation/ABI/testing/sysfs

Re: [Xen-devel] [RFC 1/4] HVM x86 deprivileged mode: Page allocation helper

2015-08-10 Thread Tim Deegan
At 09:55 +0100 on 10 Aug (1439200516), Andrew Cooper wrote: > On 10/08/2015 09:52, Tim Deegan wrote: > >> Whie I agree that it would be good to account this to the domain, > >> paging->alloc_page() is an internal _paging assistance_ helper. :) > >> This new allocation is nothing to do with mm/pagin

Re: [Xen-devel] [RFC 4/4] HVM x86 deprivileged mode: Trap handlers for deprivileged mode

2015-08-10 Thread Tim Deegan
Hi, > @@ -685,8 +685,17 @@ static int hap_page_fault(struct vcpu *v, unsigned long > va, > { > struct domain *d = v->domain; > > +/* If we get a page fault whilst in HVM security user mode */ > +if( v->user_mode == 1 ) > +{ > +printk("HVM: #PF (%u:%u) whilst in user mo

Re: [Xen-devel] [PATCH v3 9/9] xen/xenbus: Rename the variable xen_store_mfn to xen_store_gfn

2015-08-10 Thread Stefano Stabellini
On Fri, 7 Aug 2015, Julien Grall wrote: > The variable xen_store_mfn is effectively storing a GFN and not an MFN. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > Cc: Konrad Rzeszutek Wilk > Cc: Boris Ostrovsky > Cc: David Vrabel > > I think that the assignation of xe

Re: [Xen-devel] [PATCH V5 3/7] libxl: add pvusb API

2015-08-10 Thread George Dunlap
On 08/07/2015 03:31 AM, Chun Yan Liu wrote: >> +("devid", libxl_devid), >> +("version", integer), >> +("ports", integer), >> +("backend_domid", libxl_domid), >> +("backend_domname", string), >> + ]) >> + >> +libxl_device_usb

Re: [Xen-devel] [PATCH v3 02/20] arm/xen: Drop pte_mfn and mfn_pte

2015-08-10 Thread Stefano Stabellini
On Fri, 7 Aug 2015, Julien Grall wrote: > They are not used in common code expect in one place in balloon.c which is > only compiled when Linux is using PV MMU. It's not the case on ARM. > > Rather than worrying how to handle the 64KB case, drop them. > > Signed-off-by: Julien Grall Reviewed-by

Re: [Xen-devel] [RFC 3/4] HVM x86 deprivileged mode: Code for switching into/out of deprivileged mode

2015-08-10 Thread Andrew Cooper
On 10/08/15 10:49, Tim Deegan wrote: > Hi, > > At 17:45 +0100 on 06 Aug (1438883118), Ben Catterall wrote: >> The process to switch into and out of deprivileged mode can be likened to >> setjmp/longjmp. >> >> To enter deprivileged mode, we take a copy of the stack from the guest's >> registers up t

[Xen-devel] [PATCH 3.2 110/110] x86/ldt: Make modify_ldt synchronous

2015-08-10 Thread Ben Hutchings
3.2.71-rc1 review patch. If anyone has any objections, please let me know. -- From: Andy Lutomirski commit 37868fe113ff2ba814b3b4eb12df214df555f8dc upstream. modify_ldt() has questionable locking and does not synchronize threads. Improve it: redesign the locking and synchroni

[Xen-devel] [PATCH 3.2 109/110] x86/xen: Probe target addresses in set_aliased_prot() before the hypercall

2015-08-10 Thread Ben Hutchings
3.2.71-rc1 review patch. If anyone has any objections, please let me know. -- From: Andy Lutomirski commit aa1acff356bbedfd03b544051f5b371746735d89 upstream. The update_va_mapping hypercall can fail if the VA isn't present in the guest's page tables. Under certain loads, this

[Xen-devel] [PATCH V6 0/7] xen pvusb toolstack work

2015-08-10 Thread Chunyan Liu
This patch series is to add pvusb toolstack work, supporting hot add|remove USB device to|from guest and specify USB device in domain configuration file. Changes to V5: * Address George's comments on libxl API and Ian's comments on libxl_read_sysfs_file_content V5 is here: http://lists.xen.org/

[Xen-devel] [PATCH V6 4/7] libxl: add libxl_device_usb_assignable_list API

2015-08-10 Thread Chunyan Liu
Add API for listing assignable USB devices info. Assignable USB device means the USB device type is assignable and it's not assigned to any guest yet. Signed-off-by: Chunyan Liu --- This could be squashed with previous patch. Split because there is some dispute on this. If this is acceptable, cou

[Xen-devel] [PATCH V6 1/7] libxl: export some functions for pvusb use

2015-08-10 Thread Chunyan Liu
Signed-off-by: Chunyan Liu Signed-off-by: Simon Cao --- tools/libxl/libxl.c | 4 ++-- tools/libxl/libxl_internal.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 083f099..006e8da 100644 --- a/tools/libxl/libxl.c +

[Xen-devel] [PATCH V6 3/7] libxl: add pvusb API

2015-08-10 Thread Chunyan Liu
Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list usb controller and usb devices - some other helper functions Signed-off-by: Chunyan Liu Signed-off-by: Simon Cao --- changes: - Address George's comments: * Update libxl

[Xen-devel] [PATCH V6 6/7] xl: add usb-assignable-list command

2015-08-10 Thread Chunyan Liu
Add xl usb-assignable-list command to list assignable USB devices. Assignable USB device means the USB device type is assignable and it's not assigned to any guest yet. Signed-off-by: Chunyan Liu --- Same as "libxl: add libxl_device_usb_assignable_list API" patch, this patch could be sqaushed

[Xen-devel] [PATCH V6 7/7] domcreate: support pvusb in configuration file

2015-08-10 Thread Chunyan Liu
Add code to support pvusb in domain config file. One could specify usbctrl and usb in domain's configuration file and create domain, then usb controllers will be created and usb device would be attached to guest automatically. One could specify usb controllers and usb devices in config file like t

[Xen-devel] [PATCH V6 2/7] libxl_read_file_contents: add new entry to read sysfs file

2015-08-10 Thread Chunyan Liu
Sysfs file has size=4096 but actual file content is less than that. Current libxl_read_file_contents will treat it as error when file size and actual file content differs, so reading sysfs file content with this function always fails. Add a new entry libxl_read_sysfs_file_contents to handle sysfs

[Xen-devel] [PATCH V6 5/7] xl: add pvusb commands

2015-08-10 Thread Chunyan Liu
Add pvusb commands: usb-ctrl-attach, usb-ctrl-detach, usb-list, usb-attach and usb-detach. To attach a usb device to guest through pvusb, one could follow following example: #xl usb-ctrl-attach test_vm version=1 num_ports=8 #xl usb-list test_vm will show the usb controllers and port usage und

Re: [Xen-devel] [PATCH v3 04/20] xen/grant: Introduce helpers to split a page into grant

2015-08-10 Thread Stefano Stabellini
On Fri, 7 Aug 2015, Julien Grall wrote: > Currently, a grant is always based on the Xen page granularity (i.e > 4KB). When Linux is using a different page granularity, a single page > will be split between multiple grants. > > The new helpers will be in charge to split the Linux page into grants a

Re: [Xen-devel] [PATCH v3 03/20] xen: Add Xen specific page definition

2015-08-10 Thread Stefano Stabellini
On Fri, 7 Aug 2015, Julien Grall wrote: > The Xen hypercall interface is always using 4K page granularity on ARM > and x86 architecture. > > With the incoming support of 64K page granularity for ARM64 guest, it > won't be possible to re-use the Linux page definition in Xen drivers. > > Introduce

Re: [Xen-devel] [PATCH v3 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page

2015-08-10 Thread Stefano Stabellini
On Fri, 7 Aug 2015, Julien Grall wrote: > On ARM all dma-capable devices on a same platform may not be protected > by an IOMMU. The DMA requests have to use the BFN (i.e MFN on ARM) in > order to use correctly the device. > > While the DOM0 memory is allocated in a 1:1 fashion (PFN == MFN), grant

Re: [Xen-devel] [PATCH v3 1/2] Differentiate IO/mem resources tracked by ioreq server

2015-08-10 Thread Andrew Cooper
On 10/08/15 09:33, Paul Durrant wrote: >> -Original Message- >> From: Wei Liu [mailto:wei.l...@citrix.com] >> Sent: 10 August 2015 09:26 >> To: Yu Zhang >> Cc: xen-devel@lists.xen.org; Paul Durrant; Ian Jackson; Stefano Stabellini; >> Ian >> Campbell; Wei Liu; Keir (Xen.org); jbeul...@suse

Re: [Xen-devel] [PATCH v3 1/2] Differentiate IO/mem resources tracked by ioreq server

2015-08-10 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 10 August 2015 11:56 > To: Paul Durrant; Wei Liu; Yu Zhang > Cc: xen-devel@lists.xen.org; Ian Jackson; Stefano Stabellini; Ian Campbell; > Keir (Xen.org); jbeul...@suse.com; Kevin Tian; zhiyuan...@intel.co

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-10 Thread Bob Liu
On 08/10/2015 07:03 PM, Rafal Mielniczuk wrote: > On 01/07/15 04:03, Jens Axboe wrote: >> On 06/30/2015 08:21 AM, Marcus Granado wrote: >>> Hi, >>> >>> Our measurements for the multiqueue patch indicate a clear improvement >>> in iops when more queues are used. >>> >>> The measurements were obtain

Re: [Xen-devel] [PATCH v3 12/20] xen/balloon: Don't rely on the page granularity is the same for Xen and Linux

2015-08-10 Thread Stefano Stabellini
On Fri, 7 Aug 2015, Julien Grall wrote: > For ARM64 guests, Linux is able to support either 64K or 4K page > granularity. Although, the hypercall interface is always based on 4K > page granularity. > > With 64K page granularity, a single page will be spread over multiple > Xen frame. > > To avoid

Re: [Xen-devel] [PATCH v3 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page

2015-08-10 Thread Julien Grall
Hi Stefano, On 10/08/15 11:50, Stefano Stabellini wrote: > On Fri, 7 Aug 2015, Julien Grall wrote: >> On ARM all dma-capable devices on a same platform may not be protected >> by an IOMMU. The DMA requests have to use the BFN (i.e MFN on ARM) in >> order to use correctly the device. >> >> While th

Re: [Xen-devel] [PATCH v3 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page

2015-08-10 Thread Stefano Stabellini
On Mon, 10 Aug 2015, Julien Grall wrote: > Hi Stefano, > > On 10/08/15 11:50, Stefano Stabellini wrote: > > On Fri, 7 Aug 2015, Julien Grall wrote: > >> On ARM all dma-capable devices on a same platform may not be protected > >> by an IOMMU. The DMA requests have to use the BFN (i.e MFN on ARM) in

Re: [Xen-devel] [PATCH v3 12/20] xen/balloon: Don't rely on the page granularity is the same for Xen and Linux

2015-08-10 Thread Julien Grall
Hi Stefano, On 10/08/15 12:18, Stefano Stabellini wrote: >> /* Link back into the page tables if not highmem. */ >> @@ -396,14 +413,15 @@ static enum bp_state increase_reservation(unsigned >> long nr_pages) >> static enum bp_state decrease_reservation(unsigned long nr_pages,

Re: [Xen-devel] [PATCH v3 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page

2015-08-10 Thread Julien Grall
On 10/08/15 12:25, Stefano Stabellini wrote: > yes and page/pages: > > xen/biomerge: Don't allow biovec's to be merged when Linux is not using 4KB > pages Why the ' in biovec's ? Shouldn't we says biovecs directly? Regards, -- Julien Grall ___ Xen-

Re: [Xen-devel] [PATCH v3 18/20] net/xen-netback: Make it running on 64KB page granularity

2015-08-10 Thread Wei Liu
On Mon, Aug 10, 2015 at 10:57:48AM +0100, Julien Grall wrote: [...] > > >>+ info.page = page; > >>+ gnttab_foreach_grant_in_range(page, offset, bytes, > >>+ xenvif_gop_frag_copy_grant, > >>+ &info);

Re: [Xen-devel] [PATCH v3 18/20] net/xen-netback: Make it running on 64KB page granularity

2015-08-10 Thread Julien Grall
On 10/08/15 12:39, Wei Liu wrote: > On Mon, Aug 10, 2015 at 10:57:48AM +0100, Julien Grall wrote: >> while (size > 0) { >> BUG_ON(offset >= PAGE_SIZE); >> >> bytes = PAGE_SIZE - offset; >> if (bytes > size) >> bytes = s

Re: [Xen-devel] [PATCH v3 19/20] xen/privcmd: Add support for Linux 64KB page granularity

2015-08-10 Thread Stefano Stabellini
On Fri, 7 Aug 2015, Julien Grall wrote: > The hypercall interface (as well as the toolstack) is always using 4KB > page granularity. When the toolstack is asking for mapping a series of > guest PFN in a batch, it expects to have the page map contiguously in > its virtual memory. > > When Linux is

[Xen-devel] Does Xen project have test suites for testing xc/xl/hypercall and so on?

2015-08-10 Thread Jinjian (Ken)
Hi all, I'm looking into xen's test suites now, and encounter some problems. Does xen have unit tests that can be executed by xen contributors to validate their code-commits before sending a patch to xen-devel? In xen-4.5.1(and its upstream), there are sevral test cases in the 'tests' di

[Xen-devel] xen/pcifront: Use monotonic clock

2015-08-10 Thread Abhilash Jindal
Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to user setting the time or due to NTP. Monotonic time is constantly increasing time better suited for comparing two timestamps. --- drivers/pci/xen-pcifront.c | 10 +- 1 file changed, 5 insertions(+), 5 deletion

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-10 Thread Rafal Mielniczuk
On 01/07/15 04:03, Jens Axboe wrote: > On 06/30/2015 08:21 AM, Marcus Granado wrote: >> Hi, >> >> Our measurements for the multiqueue patch indicate a clear improvement >> in iops when more queues are used. >> >> The measurements were obtained under the following conditions: >> >> - using blkback a

[Xen-devel] [libvirt test] 60641: regressions - trouble: broken/fail/pass

2015-08-10 Thread osstest service owner
flight 60641 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/60641/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 3 host-install(3) broken REGR. vs. 60629 test-armhf-armhf-libvirt

Re: [Xen-devel] [PATCH v3 19/20] xen/privcmd: Add support for Linux 64KB page granularity

2015-08-10 Thread David Vrabel
On 10/08/15 13:03, Stefano Stabellini wrote: > On Fri, 7 Aug 2015, Julien Grall wrote: >> -rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp); >> -return rc < 0 ? rc : err; >> +for (i = 0; i < nr_gfn; i++) { >> +if ((i % XEN_PFN_PER_PAGE) == 0) { >> +

Re: [Xen-devel] Does Xen project have test suites for testing xc/xl/hypercall and so on?

2015-08-10 Thread Andrew Cooper
On 07/08/15 09:47, Jinjian (Ken) wrote: > Hi all, >I'm looking into xen's test suites now, and encounter some problems. >Does xen have unit tests that can be executed by xen contributors to > validate their code-commits before sending a patch to xen-devel? >In xen-4.5.1(and its upstream

Re: [Xen-devel] Does Xen project have test suites for testing xc/xl/hypercall and so on?

2015-08-10 Thread Lars Kurth
There is some very minimal functionality in Raisin for testing, which Stefano is working on. See https://blog.xenproject.org/2015/06/28/project-raisin-raise-xen/ Lars > On 10 Aug 2015, at 13:18, Andrew Cooper wrote: > > On 07/08/15 09:47, Jinjian (Ken) wrote: >> Hi all, >> I'm looking into x

Re: [Xen-devel] [xen 4.6 retrospective] More public/easy to find information about the release schedule

2015-08-10 Thread Lars Kurth
> On 10 Aug 2015, at 10:40, Fabio Fantoni wrote: > > Il 10/08/2015 11:06, Lars Kurth ha scritto: >>> On 10 Aug 2015, at 09:33, Wei Liu wrote: >>> >>> On Fri, Aug 07, 2015 at 05:36:57PM +0200, Roger Pau Monné wrote: = Issue / Observation = The information about the release sched

Re: [Xen-devel] [PATCH v3 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page

2015-08-10 Thread David Vrabel
On 10/08/15 12:32, Julien Grall wrote: > On 10/08/15 12:25, Stefano Stabellini wrote: >> yes and page/pages: >> >> xen/biomerge: Don't allow biovec's to be merged when Linux is not using 4KB >> pages > > Why the ' in biovec's ? Shouldn't we says biovecs directly? Pluralizing named C structures w

Re: [Xen-devel] [PATCH v3 20/20] arm/xen: Add support for 64KB page granularity

2015-08-10 Thread Stefano Stabellini
On Fri, 7 Aug 2015, Julien Grall wrote: > The hypercall interface is always using 4KB page granularity. This is > requiring to use xen page definition macro when we deal with hypercall. > > Note that pfn_to_gfn is working with a Xen pfn (i.e 4KB). We may want to > rename pfn_gfn to make this expli

Re: [Xen-devel] [PATCH v3 12/20] xen/balloon: Don't rely on the page granularity is the same for Xen and Linux

2015-08-10 Thread Stefano Stabellini
On Mon, 10 Aug 2015, Julien Grall wrote: > Hi Stefano, > > On 10/08/15 12:18, Stefano Stabellini wrote: > >>/* Link back into the page tables if not highmem. */ > >> @@ -396,14 +413,15 @@ static enum bp_state increase_reservation(unsigned > >> long nr_pages) > >> static enum

Re: [Xen-devel] [PATCH v3 19/20] xen/privcmd: Add support for Linux 64KB page granularity

2015-08-10 Thread Stefano Stabellini
On Mon, 10 Aug 2015, David Vrabel wrote: > On 10/08/15 13:03, Stefano Stabellini wrote: > > On Fri, 7 Aug 2015, Julien Grall wrote: > >> - rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp); > >> - return rc < 0 ? rc : err; > >> + for (i = 0; i < nr_gfn; i++) { > >> + if ((i

Re: [Xen-devel] Does Xen project have test suites for testing xc/xl/hypercall and so on?

2015-08-10 Thread Stefano Stabellini
Hi Jinjian, validating changes made by contributors before submitting their patches to xen-devel, is exactly the reason why I introduced "raise test" in raisin. However the number of tests available is still very limited and the functionality pretty immature. Of course I would be happy to take pa

Re: [Xen-devel] [PATCH v3 19/20] xen/privcmd: Add support for Linux 64KB page granularity

2015-08-10 Thread Julien Grall
Hi Stefano, On 10/08/15 13:57, Stefano Stabellini wrote: > On Mon, 10 Aug 2015, David Vrabel wrote: >> On 10/08/15 13:03, Stefano Stabellini wrote: >>> On Fri, 7 Aug 2015, Julien Grall wrote: - rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp); - return rc < 0 ? rc : err; >

Re: [Xen-devel] [PATCH v3 12/20] xen/balloon: Don't rely on the page granularity is the same for Xen and Linux

2015-08-10 Thread Julien Grall
On 10/08/15 13:55, Stefano Stabellini wrote: >> If your only concern is the size of the array, we could decrease the >> number of frames by batch. Or allocation the variable once a boot time. > > Yes, that is my only concern. Allocating only nr_pages new struct page* > would be good enough I guess

[Xen-devel] [PATCH v3] xen-apic: Enable on domU as well

2015-08-10 Thread Jason A. Donenfeld
It turns out that domU also requires the Xen APIC driver. Otherwise we get stuck in busy loops that never exit, such as in this stack trace: (gdb) target remote localhost: Remote debugging using localhost: __xapic_wait_icr_idle () at ./arch/x86/include/asm/ipi.h:56 56 while (n

Re: [Xen-devel] [PATCH v3] xen-apic: Enable on domU as well

2015-08-10 Thread David Vrabel
On 10/08/15 14:40, Jason A. Donenfeld wrote: > It turns out that domU also requires the Xen APIC driver. Otherwise we > get stuck in busy loops that never exit, such as in this stack trace: What's the difference between v3 and v2? David ___ Xen-devel

Re: [Xen-devel] [PATCH v3] xen-apic: Enable on domU as well

2015-08-10 Thread Jason A. Donenfeld
On Mon, Aug 10, 2015 at 3:41 PM, David Vrabel wrote: > On 10/08/15 14:40, Jason A. Donenfeld wrote: >> It turns out that domU also requires the Xen APIC driver. Otherwise we >> get stuck in busy loops that never exit, such as in this stack trace: > > What's the difference between v3 and v2? I did

Re: [Xen-devel] Linux 4.2-rc5:

2015-08-10 Thread Sander Eikelenboom
Monday, August 10, 2015, 11:00:11 AM, you wrote: > On 08/06/2015 08:51 PM, li...@eikelenboom.it wrote: >> Hi Ross, >> >> On my dom0 with a linux 4.2-rc5 kernel i encoutered the splat below. >> It's probably related to your patch that went in just for 4.2-rc5: >> "xen/events/fifo: Handle linked ev

Re: [Xen-devel] About Xen bridged pci devices and suspend/resume for the X10SAE motherboard

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Aug 10, 2015 at 02:11:38AM +0300, M. Ivanov wrote: > Hello, > > excuse me for bothering you, but I've read an old thread on a mailing > list about X10SAE compatibility. > http://lists.xen.org/archives/html/xen-devel/2014-02/msg02111.html CC-ing Xen devel. > > Currently I own this board

Re: [Xen-devel] [PATCH v6 2/6] xen/PMU: Sysfs interface for setting Xen PMU mode

2015-08-10 Thread Konrad Rzeszutek Wilk
On Sun, Aug 09, 2015 at 09:31:43PM -0400, Boris Ostrovsky wrote: > Set Xen's PMU mode via /sys/hypervisor/pmu/pmu_mode. Add XENPMU hypercall. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk > --- > Documentation/ABI/testing/sysfs-hypervisor-pmu | 23 + > arch/x86/inc

[Xen-devel] [PATCHv1] xen/events/fifo: Handle linked events when closing a PIRQ port

2015-08-10 Thread David Vrabel
Commit fcdf31a7c162de0c93a2bee51df4688ab0a348f8 (xen/events/fifo: Handle linked events when closing a port) did not handle closing a port bound to a PIRQ because these are closed from shutdown_pirq() which is called with interrupts disabled. Defer the close to a work queue where we can safely spin

[Xen-devel] [PATCH] x86: Allow PV guest set X86_CR4_PCE flag

2015-08-10 Thread Boris Ostrovsky
With added PV support for VPMU, guests may legitimately decide to set CR4's PCE flag. We should allow this when VPMU is enabled. Signed-off-by: Boris Ostrovsky --- xen/arch/x86/cpu/vpmu.c | 19 +++ xen/arch/x86/domain.c| 13 - xen/include/asm-x86/domain.h

Re: [Xen-devel] [PATCH] x86: Allow PV guest set X86_CR4_PCE flag

2015-08-10 Thread Andrew Cooper
On 10/08/15 15:27, Boris Ostrovsky wrote: > With added PV support for VPMU, guests may legitimately decide to set > CR4's PCE flag. We should allow this when VPMU is enabled. > > Signed-off-by: Boris Ostrovsky Why? Even a PV guest using VPMU should know that it doesn't actually control CR4.PCE

Re: [Xen-devel] About Xen bridged pci devices and suspend/resume for the X10SAE motherboard

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Aug 10, 2015 at 05:14:28PM +0300, M. Ivanov wrote: > On Mon, 2015-08-10 at 09:58 -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Aug 10, 2015 at 02:11:38AM +0300, M. Ivanov wrote: > > > Hello, > > > > > > excuse me for bothering you, but I've read an old thread on a mailing > > > list abou

Re: [Xen-devel] [PATCH] x86: Allow PV guest set X86_CR4_PCE flag

2015-08-10 Thread Boris Ostrovsky
On 08/10/2015 10:37 AM, Andrew Cooper wrote: On 10/08/15 15:27, Boris Ostrovsky wrote: With added PV support for VPMU, guests may legitimately decide to set CR4's PCE flag. We should allow this when VPMU is enabled. Signed-off-by: Boris Ostrovsky Why? Even a PV guest using VPMU should know

Re: [Xen-devel] [PATCH] x86: Allow PV guest set X86_CR4_PCE flag

2015-08-10 Thread Andrew Cooper
On 10/08/15 15:49, Boris Ostrovsky wrote: > > > On 08/10/2015 10:37 AM, Andrew Cooper wrote: >> On 10/08/15 15:27, Boris Ostrovsky wrote: >>> With added PV support for VPMU, guests may legitimately decide to set >>> CR4's PCE flag. We should allow this when VPMU is enabled. >>> >>> Signed-off-by: B

Re: [Xen-devel] how can I find hypercall page address?

2015-08-10 Thread Dario Faggioli
On Sat, 2015-08-08 at 08:02 +0800, big strong wrote: > I think I've stated clearly what I want to do. > Well... > > |I want to locate the hypercall page address when creating a new domU, > so as to locate hypercalls. > Ok. What for? Dario -- <> (Raistlin Majere)

Re: [Xen-devel] [PATCH] x86: Allow PV guest set X86_CR4_PCE flag

2015-08-10 Thread Boris Ostrovsky
On 08/10/2015 11:02 AM, Andrew Cooper wrote: On 10/08/15 15:49, Boris Ostrovsky wrote: On 08/10/2015 10:37 AM, Andrew Cooper wrote: On 10/08/15 15:27, Boris Ostrovsky wrote: With added PV support for VPMU, guests may legitimately decide to set CR4's PCE flag. We should allow this when VPMU

Re: [Xen-devel] Developing Desktop Window Integration

2015-08-10 Thread Dario Faggioli
On Fri, 2015-08-07 at 12:55 -0400, hanji unit wrote: > I have started looking at what would be required. It looks like a full > graphical stack implementation, including userland, kernelmode, and > possibly even VGA device code. For these reasons, I think it will be a > large undertaking and want t

Re: [Xen-devel] [xen 4.6 retrospective] More public/easy to find information about the release schedule

2015-08-10 Thread Dario Faggioli
On Fri, 2015-08-07 at 17:36 +0200, Roger Pau Monné wrote: > = Issue / Observation = > > The information about the release schedule is not clearly published > anywhere apart from the mailing lists, which makes it hard for > non-developers (or even for developers) given that the mailing list > traff

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-10 Thread Jens Axboe
On 08/10/2015 05:03 AM, Rafal Mielniczuk wrote: On 01/07/15 04:03, Jens Axboe wrote: On 06/30/2015 08:21 AM, Marcus Granado wrote: Hi, Our measurements for the multiqueue patch indicate a clear improvement in iops when more queues are used. The measurements were obtained under the following c

Re: [Xen-devel] [PATCH v2 01/23] x86/boot: remove unneeded instruction

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 27, 2015 at 09:46:08PM +0200, Daniel Kiper wrote: > On Fri, Jul 24, 2015 at 12:22:57PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jul 20, 2015 at 04:28:56PM +0200, Daniel Kiper wrote: > > > Signed-off-by: Daniel Kiper > > > > Don't you use it in: > > > > /* Switch to low-memor

Re: [Xen-devel] [PATCHv1] xen/events/fifo: Handle linked events when closing a PIRQ port

2015-08-10 Thread Boris Ostrovsky
On 08/10/2015 10:24 AM, David Vrabel wrote: Commit fcdf31a7c162de0c93a2bee51df4688ab0a348f8 (xen/events/fifo: Handle linked events when closing a port) did not handle closing a port bound to a PIRQ because these are closed from shutdown_pirq() which is called with interrupts disabled. Defer the

[Xen-devel] OVMF BoF @ KVM Forum 2015

2015-08-10 Thread Laszlo Ersek
Hi. Let's do an OVMF BoF at this year's KVM Forum too. Paolo will present Securing secure boot: system management mode in KVM and Tiano Core on Thursday, August 20, in the 5:00pm - 5:30pm time slot. Right after that, the BoF section starts at 5:30pm: http://events.linuxfoundation.org/even

Re: [Xen-devel] [PATCH v2 04/23] x86/boot: call reloc() using cdecl calling convention

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:28:59PM +0200, Daniel Kiper wrote: > Suggested-by: Jan Beulich > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > xen/arch/x86/boot/head.S |4 +++- > xen/arch/x86/boot/reloc.c | 20 > 2 files changed, 19 insertions(+

Re: [Xen-devel] [PATCH v2 06/23] x86/boot: use %ecx instead of %eax

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:01PM +0200, Daniel Kiper wrote: > Use %ecx instead of %eax to store low memory upper limit from EBDA. > This way we do not wipe multiboot protocol identifier. It is needed > in reloc() to differentiate between multiboot (v1) and > multiboot2 protocol. > > Signed-off-b

Re: [Xen-devel] [PATCH v2 07/23] x86/boot/reloc: Rename some variables and rearrange code a bit

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:02PM +0200, Daniel Kiper wrote: > Rename mbi and mbi_old variables and rearrange code a bit to make s/mbi_old/mbi_in/ Perhaps you want to say: rename mbi_old with mbi_in, and mbi with mbi_out or better: Replace mbi with mbi_out and mbi_old with mbi_in and ... > i

[Xen-devel] [linux-3.18 test] 60642: regressions - FAIL

2015-08-10 Thread osstest service owner
flight 60642 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/60642/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 58581 Regressions which are

Re: [Xen-devel] [PATCH 3.2 110/110] x86/ldt: Make modify_ldt synchronous

2015-08-10 Thread Andy Lutomirski
On Mon, Aug 10, 2015 at 3:12 AM, Ben Hutchings wrote: > 3.2.71-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Andy Lutomirski > > commit 37868fe113ff2ba814b3b4eb12df214df555f8dc upstream. Unfortunately, this patch was slightly buggy. The fi

Re: [Xen-devel] [PATCHv1] xen/events/fifo: Handle linked events when closing a PIRQ port

2015-08-10 Thread linux
On 2015-08-10 16:24, David Vrabel wrote: Commit fcdf31a7c162de0c93a2bee51df4688ab0a348f8 (xen/events/fifo: Handle linked events when closing a port) did not handle closing a port bound to a PIRQ because these are closed from shutdown_pirq() which is called with interrupts disabled. Defer the clo

Re: [Xen-devel] [PATCHv1] xen/events/fifo: Handle linked events when closing a PIRQ port

2015-08-10 Thread David Vrabel
On 10/08/15 17:47, li...@eikelenboom.it wrote: > On 2015-08-10 16:24, David Vrabel wrote: >> Commit fcdf31a7c162de0c93a2bee51df4688ab0a348f8 (xen/events/fifo: >> Handle linked events when closing a port) did not handle closing a >> port bound to a PIRQ because these are closed from shutdown_pirq()

[Xen-devel] [PATCH] xen/xenbus: Don't leak memory when unmapping the ring on HVM backend

2015-08-10 Thread Julien Grall
The commit ccc9d90a9a8b5c4ad7e9708ec41f75ff9e98d61d "xenbus_client: Extend interface to support multi-page ring" removes the call to free_xenballooned_pages in xenbus_unmap_ring_vfree_hvm. This will result to not give back the pages to Linux and loose them forever. It only happens when the backend

Re: [Xen-devel] [PATCH] xen/xenbus: Don't leak memory when unmapping the ring on HVM backend

2015-08-10 Thread Boris Ostrovsky
On 08/10/2015 02:10 PM, Julien Grall wrote: The commit ccc9d90a9a8b5c4ad7e9708ec41f75ff9e98d61d "xenbus_client: Extend interface to support multi-page ring" removes the call to free_xenballooned_pages in xenbus_unmap_ring_vfree_hvm. This will result to not give back the pages to Linux and loos

  1   2   >