On 2015/7/10 21:49, George Dunlap wrote:
On Thu, Jul 9, 2015 at 6:33 AM, Tiejun Chen wrote:
Now we get this map layout by call XENMEM_memory_map then
save them into one global variable memory_map[]. It should
include lowmem range, rdm range and highmem range. Note
rdm range and highmem range ma
>>> On 11.07.15 at 22:01, wrote:
>> From: Jan Beulich [mailto:jbeul...@suse.com]
>>Sent: Friday, July 10, 2015 2:31 AM
>>
> On 10.07.15 at 02:52, wrote:
>>> @@ -3234,6 +3256,13 @@ void vmx_vmexit_handler(struct cpu_user_regs
>>*regs)
>>> update_guest_eip();
>>> break;
>>
>>> On 11.07.15 at 23:25, wrote:
>> From: Sahita, Ravi
>>Sent: Saturday, July 11, 2015 1:01 PM
>>>From: Jan Beulich [mailto:jbeul...@suse.com]
>>>Sent: Friday, July 10, 2015 2:31 AM
>> On 10.07.15 at 02:52, wrote:
@@ -3825,10 +3826,7 @@ x86_emulate(
>>> On 11.07.15 at 00:03, wrote:
>> From: Jan Beulich [mailto:jbeul...@suse.com]
>>Sent: Friday, July 10, 2015 3:01 AM
> On 10.07.15 at 02:52, wrote:
>>> +default:
>>> +return -ENOSYS;
>>> +
>>> +break;
>>
>>Bogus (unreachable) break.
>
> Wanted to keep this s
Hello,
I'd like to ask for a freeze exception for the "vm_event memory
introspection helpers" series.
[PATCH 1/3] xen/mem_access: Support for memory-content hiding
[PATCH 2/3] xen/vm_event: Support for guest-requested events
[PATCH 3/3] xen/vm_event: Deny register writes if refused by
vm_event re
Hi,
I have a couple of high-level points here:
* Do you think it would be reasonable to have a minimal design without
in-place patching, just using trampolines? The examples discussed
below suggest so.
* Regarding tboot integration: Do you plan to report hotpatching state
to guests or do
>>> On 10.07.15 at 21:30, wrote:
>> From: Jan Beulich [mailto:jbeul...@suse.com]
>>Sent: Thursday, July 09, 2015 6:01 AM
> On 01.07.15 at 20:09, wrote:
>>> @@ -232,6 +235,15 @@ static int ept_set_middle_entry(struct p2m_domain
>>> @@ -1134,6 +1151,13 @@ int ept_p2m_init(struct p2m_domain *p2m
Hello,
I'm battling the following hypervisor crash with current staging:
(d2) Invoking ROMBIOS ...
(XEN) stdvga.c:147:d2v0 entering stdvga and caching modes
(d2) VGABios $Id: vgabios.c,v 1.67 2008/01/27 09:44:12 vruppert Exp $
(XEN) Watchdog timer detects that CPU7 is stuck!
(XEN) [ Xen-4.6-u
>>> On 10.07.15 at 23:48, wrote:
>> From: Jan Beulich [mailto:jbeul...@suse.com]
>>Sent: Thursday, July 09, 2015 6:30 AM
>>
> On 01.07.15 at 20:09, wrote:
>>> ---
>>> xen/arch/x86/hvm/Makefile| 1 +
>>> xen/arch/x86/hvm/altp2m.c| 92
>>+
>>
>From cri-args-hostlists or invoke-daemon.
All sites now have a suitable $HOME/.xen-osstest/settings in place
which does this.
Signed-off-by: Ian Campbell
---
This was waiting to be applied once " allow instance specific
settings" passed the Cambridge push gate, which happened ages ago.
---
cri
>>> On 13.07.15 at 08:31, wrote:
> 3. explain why it doesn't break things (risks).
>
> Our policy makes sure that system will work in the original way by
> default as without the RMRR patches. And especially, this series just
> impacts those platforms which have RMRR.
I think this should read
On 13/07/2015 08:48, Razvan Cojocaru wrote:
> Hello,
>
> I'm battling the following hypervisor crash with current staging:
>
> (d2) Invoking ROMBIOS ...
> (XEN) stdvga.c:147:d2v0 entering stdvga and caching modes
> (d2) VGABios $Id: vgabios.c,v 1.67 2008/01/27 09:44:12 vruppert Exp $
> (XEN) Watchd
I wrote this ages ago while migrating the Cambridge instance to a new
VM and then forgot about it. It's incomplete and I'm not sure where I
was planning to go next, but better than nothing maybe?
Signed-off-by: Ian Campbell
---
INSTALL.production | 78
Many of our branches include a version number, this change results in
e.g. linux-3.0 < linux-3.4 < linux-3.10 rather than linux-3.0 <
linux-3.10 < linux-3.4, which is more natural for uses such as
./mg-all-branch-statuses.
Requires Sort::Versions (Debian package libsort-versions-perl).
Signed-off
by adding a two step loop. The function now finds a fallback cpu for a given
vcpu using the following precedence...
1) the vcpu's current pcpu
soft affinity step...
2) another pcpu from the vcpu's current runq in the vcpu's soft affinity
3) an online pcpu in the vcpu's domain's cpupool, and in the
Move macro VCPU2ONLINE from schedule.c to sched.h so it can be used by other
source files.
Signed-off-by: Justin T. Weaver
---
xen/common/schedule.c |1 -
xen/include/xen/sched.h |2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/common/schedule.c b/xen/common/sch
by making sure that vcpus only run on the pcpu(s) they are allowed to
run on based on their hard affinity cpu masks.
Signed-off-by: Justin T. Weaver
---
Changes in v4:
* Renamed scratch_mask to _scratch_mask
* Renamed csched2_cpumask to scratch_mask
* Removed "else continue" in function choose
Hello,
The credit2 vcpu scheduler currently ignores per-vcpu hard and soft affinity
masks.
In the v3 review I was asked by George Dunlap to split up the soft affinity
patch into multiple patches by function and only resend the changes to two of
them, get_fallback_cpu and runq_tickle, so this seri
Move affinity balancing related functions and defines from sched_credit.c to
sched-if.h so other schedulers can use them. Change name prefixes from csched
to sched since they are no longer specific to the credit scheduler. No
functional changes intended.
Signed-off-by: Justin T. Weaver
Reviewed-b
by adding two two-step affinity loops.
The first looks for an idle, non-tickled cpu in the given vcpu's soft
affinity, and then in it's hard affinity.
If no cpu was found, the second two-step loop first looks for the non-idle,
non-tickled cpu with the lowest credit in the vcpu's soft affinity. If
By converting the current boolean $force_baseline into a keyword
indicating the reason.
Signed-off-by: Ian Campbell
---
cr-daily-branch | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/cr-daily-branch b/cr-daily-branch
index 34b6d2b..7e3e69e 100755
--- a/cr-dail
Provide a new cr-daily-branch setting OSSTEST_BASELINES_ONLY which
causes it to only attempt to test the current baseline (if it is
untested) and never the tip version. Such tests will not result in any
push.
Add a cronjob to Cambridge which runs in this manner, ensuring that
there will usually be
"ap-fetch-version: Arrange for osstest merges from upstream to be
stable" has now passed the Cambridge push gate and done a couple of
merges from upstream as well as some failed attempts, which behaved as
expected. I've dropped a stop file in Cambridge while this pull request
is pending, so we don'
>>> On 11.07.15 at 06:52, wrote:
> @@ -1162,8 +1176,82 @@ rt_dom_cntl(
> }
> spin_unlock_irqrestore(&prv->lock, flags);
> break;
> +case XEN_DOMCTL_SCHEDOP_getvcpuinfo:
> +spin_lock_irqsave(&prv->lock, flags);
> +for ( index = 0; index < op->u.v.nr_vc
flight 59489 rumpuserxen real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59489/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64-rumpuserxen 5 rumpuserxen-build fail REGR. vs. 33866
build-i386-rumpuserxe
flight 59488 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59488/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-i386-libvirt5 libvirt-build fail REGR. vs. 58842
build-i386-pvops
>>> On 10.07.15 at 18:07, wrote:
> @@ -2710,17 +2711,21 @@ int hvm_send_assist_req(struct hvm_ioreq_server *s,
> ioreq_t *proto_p)
> return X86EMUL_UNHANDLEABLE;
> }
>
> -void hvm_broadcast_assist_req(ioreq_t *p)
> +int hvm_broadcast_ioreq(ioreq_t *p, bool_t buffered)
> {
> struct d
>>> On 10.07.15 at 18:24, wrote:
> On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote:
>> Log first 10 active grants of a domain. This function is going to be used
>> for soft reset, active grants on this path usually mean misbehaving backends
>> refusing to release their mappings on
On 07/13/2015 11:10 AM, Andrew Cooper wrote:
> On 13/07/2015 08:48, Razvan Cojocaru wrote:
>> Hello,
>>
>> I'm battling the following hypervisor crash with current staging:
>>
>> (d2) Invoking ROMBIOS ...
>> (XEN) stdvga.c:147:d2v0 entering stdvga and caching modes
>> (d2) VGABios $Id: vgabios.c,v
> -Original Message-
> From: Andrew Cooper [mailto:am...@hermes.cam.ac.uk] On Behalf Of
> Andrew Cooper
> Sent: 13 July 2015 09:11
> To: Razvan Cojocaru; xen-devel@lists.xen.org
> Cc: Keir (Xen.org); Jan Beulich; Paul Durrant
> Subject: Re: Deadlock in stdvga_mem_accept() with emulation
>
> -Original Message-
> From: Jan Beulich [mailto:jbeul...@suse.com]
> Sent: 13 July 2015 09:44
> To: Paul Durrant
> Cc: Andrew Cooper; xen-devel@lists.xen.org; Keir (Xen.org)
> Subject: Re: [PATCH v2] x86/hvm: add support for broadcast of buffered
> ioreqs...
>
> >>> On 10.07.15 at 18:07,
From: Fu Wei
- This adds support for the Xen boot on ARM specification for arm64.
- The implementation for Xen is following :
http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot
and xen/docs/misc/arm/device-tree/booting.txt in Xen source code.
- The multiboo
From: Fu Wei
This patch adds the support of boot command on arm64 for XEN:
xen_hypervisor
xen_module
Signed-off-by: Fu Wei
---
util/grub.d/20_linux_xen.in | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/util/grub.d/20_linux_xen.in b/util/grub.d/20_li
>>> On 13.07.15 at 05:36, wrote:
> phys_proc_id is invalidated in remove_siblinginfo() which gets called
> before cpu_smpboot_free(). This means calling cpu_to_socket(cpu) in
> cpu_smpboot_free() is not possible to be correct.
>
> This patch invokes remove_siblinginfo() in cpu_smpboot_free(),
> i
From: Fu Wei
This patch adds Xen boot support file:
grub-core/loader/arm64/xen_boot.c
include/grub/arm64/xen_boot.h
This patch also adds commands register code and hearder file into
grub-core/loader/arm64/linux.c
- This adds support for the Xen boot on ARM specification for arm64.
- The imp
From: Fu Wei
This patch adds the introduction of xen_hypervisor/xen_module commands
in docs/grub.texi
Signed-off-by: Fu Wei
---
docs/grub.texi | 27 +++
1 file changed, 27 insertions(+)
diff --git a/docs/grub.texi b/docs/grub.texi
index b9f41a7..3bd2fc3 100644
--- a/do
>>> On 13.07.15 at 08:47, wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -480,6 +480,7 @@ struct xen_domctl_assign_device {
> } u;
> /* IN */
> #define XEN_DOMCTL_DEV_RDM_RELAXED 1
> +#define XEN_DOMCTL_DEV_RDM_MASK 0x1
As said befor
On 13/07/15 09:50, Razvan Cojocaru wrote:
> On 07/13/2015 11:10 AM, Andrew Cooper wrote:
>> On 13/07/2015 08:48, Razvan Cojocaru wrote:
>>> Hello,
>>>
>>> I'm battling the following hypervisor crash with current staging:
>>>
>>> (d2) Invoking ROMBIOS ...
>>> (XEN) stdvga.c:147:d2v0 entering stdvga
On 07/13/2015 12:00 PM, Andrew Cooper wrote:
> On 13/07/15 09:50, Razvan Cojocaru wrote:
>> On 07/13/2015 11:10 AM, Andrew Cooper wrote:
>>> On 13/07/2015 08:48, Razvan Cojocaru wrote:
Hello,
I'm battling the following hypervisor crash with current staging:
(d2) Invoking RO
> -Original Message-
> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com]
> Sent: 13 July 2015 09:50
> To: Andrew Cooper; xen-devel@lists.xen.org
> Cc: Keir (Xen.org); Jan Beulich; Paul Durrant
> Subject: Re: Deadlock in stdvga_mem_accept() with emulation
>
> On 07/13/2015 11:10 AM,
On 07/13/2015 12:01 PM, Paul Durrant wrote:
>> -Original Message-
>> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com]
>> Sent: 13 July 2015 09:50
>> To: Andrew Cooper; xen-devel@lists.xen.org
>> Cc: Keir (Xen.org); Jan Beulich; Paul Durrant
>> Subject: Re: Deadlock in stdvga_mem_acc
On Thu, 2015-07-09 at 16:31 +0300, Oleksandr Dmytryshyn wrote:
> I have some questions:
> 1. Is this a correct solution?
> 2. Could this solution be considered as a normal (not hack)?
> 3. If not then could anybody help me to implement this in the right way?
The way we deal with this elsewhere in
>>> On 13.07.15 at 08:55, wrote:
> There are two main outstanding issues so far:
> 1. Jan's security concern. I have proposed some solutions but Jan still has
> some problems with my proposals. It would be great if Jan can give a clear
> proposal so that we can discuss and keep making progress.
M
> -Original Message-
> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com]
> Sent: 13 July 2015 10:03
> To: Paul Durrant; Andrew Cooper; xen-devel@lists.xen.org
> Cc: Keir (Xen.org); Jan Beulich
> Subject: Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation
>
> On 07/13/201
On Mon, 2015-07-13 at 09:45 +0100, Jan Beulich wrote:
> >>> On 10.07.15 at 18:24, wrote:
> > On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote:
> >> Log first 10 active grants of a domain. This function is going to be used
> >> for soft reset, active grants on this path usually mean
On Sat, 2015-07-11 at 20:10 +0530, Vijay Kilari wrote:
> On Fri, Jul 10, 2015 at 7:16 PM, Ian Campbell wrote:
> > On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote:
> >> From: Vijaya Kumar K
> >>
> >> Implements hw_irq_controller api's required
> >> to handle LPI's
> >>
> >> Signed-
Do you mean I should merge them as one as possible?
"Factor it out" means to break out into a separate function (or maybe
a macro or something, but in this case a function is appropriate). So
in this case take the two sets of similar code, combine them into a
function with appropriate arguments
On Sat, 2015-07-11 at 20:19 +0530, Vijay Kilari wrote:
> >> +int vgic_its_process_cmd(struct vcpu *v, struct vgic_its *vits)
> >> +{
> >> +its_cmd_block virt_cmd;
> >> +
> >> +ASSERT(spin_is_locked(&vits->lock));
> >> +
> >> +do {
> >> +if ( vgic_its_read_virt_cmd(v, vits, &virt
On Sat, 2015-07-11 at 20:18 +0530, Vijay Kilari wrote:
> On Fri, Jul 10, 2015 at 7:45 PM, Ian Campbell wrote:
> > On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote:
> >> +static int vits_entry(struct domain *d, paddr_t entry, void *addr,
> >> + uint32_t size, boo
On Sat, 2015-07-11 at 20:18 +0530, Vijay Kilari wrote:
> Hi Ian,
>
> On Fri, Jul 10, 2015 at 7:24 PM, Ian Campbell wrote:
> > On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote:
> >> +/* RB-tree helpers for vits_device attached to a domain */
> >
> > In the rest of the series I found
>>> On 13.07.15 at 11:05, wrote:
> --- a/xen/arch/x86/hvm/stdvga.c
> +++ b/xen/arch/x86/hvm/stdvga.c
> @@ -490,11 +490,18 @@ static bool_t stdvga_mem_accept(const struct
> hvm_io_handle
> {
> struct hvm_hw_stdvga *s = ¤t->domain->arch.hvm_domain.stdvga;
>
> +/*
> + * The range chec
On Sat, 2015-07-11 at 20:25 +0200, Julien Grall wrote:
> Hi,
>
> On 10/07/2015 17:10, Ian Campbell wrote:
> > Extra space after the &.
> >> @@ -694,6 +755,14 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v,
> >> mmio_info_t *info)
> >> *r = ((ncpus - 1) << GICD_TYPE_CPUS_SHIFT |
>
Razvan Cojocaru reported a hypervisor deadlock with the following stack:
(XEN)[] _spin_lock+0x31/0x54
(XEN)[] stdvga_mem_accept+0x3b/0x125
(XEN)[] hvm_find_io_handler+0x68/0x8a
(XEN)[] hvm_mmio_internal+0x37/0x67
(XEN)[] __hvm_copy+0xe9/0x37d
(XEN)[] hvm_copy_from_guest_phy
> -Original Message-
> From: Jan Beulich [mailto:jbeul...@suse.com]
> Sent: 13 July 2015 10:28
> To: Paul Durrant
> Cc: Razvan Cojocaru; Andrew Cooper; xen-devel@lists.xen.org; Keir
> (Xen.org)
> Subject: RE: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation
>
> >>> On 13.07.15 at
>>> On 13.07.15 at 11:08, wrote:
> On Mon, 2015-07-13 at 09:45 +0100, Jan Beulich wrote:
>> >>> On 10.07.15 at 18:24, wrote:
>> > On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote:
>> >> Log first 10 active grants of a domain. This function is going to be used
>> >> for soft reset,
+}else if ( !strcmp(optkey, "rdm_policy") ) {
+if ( !strcmp(tok, "strict") ) {
+pcidev->rdm_policy = LIBXL_RDM_RESERVE_POLICY_STRICT;
+} else if ( !strcmp(tok, "relaxed") ) {
+pcidev->rdm_policy
"Jan Beulich" writes:
On 13.07.15 at 11:08, wrote:
>> On Mon, 2015-07-13 at 09:45 +0100, Jan Beulich wrote:
>>> >>> On 10.07.15 at 18:24, wrote:
>>> > On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote:
>>> >> Log first 10 active grants of a domain. This function is going to
On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote:
> I still can't understand what I'm missing here after compared to other
> contexts inside xlu_pci_parse_bdf().
Perhaps comparing to the CODING_STYLE document would help?
> So I have to paste this entirely,
>
> }else if (
>>> On 13.07.15 at 11:30, wrote:
>> -Original Message-
>> From: Jan Beulich [mailto:jbeul...@suse.com]
>> Sent: 13 July 2015 10:28
>> To: Paul Durrant
>> Cc: Razvan Cojocaru; Andrew Cooper; xen-devel@lists.xen.org; Keir
>> (Xen.org)
>> Subject: RE: [Xen-devel] Deadlock in stdvga_mem_accep
On 07/13/2015 12:05 PM, Paul Durrant wrote:
>> -Original Message-
>> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com]
>> Sent: 13 July 2015 10:03
>> To: Paul Durrant; Andrew Cooper; xen-devel@lists.xen.org
>> Cc: Keir (Xen.org); Jan Beulich
>> Subject: Re: [Xen-devel] Deadlock in st
On Sat, 2015-07-11 at 02:03 +0530, Abhinav Gupta wrote:
> Hi everyone,
>
Hey, :-)
> I'm sorry for the late update. Actually I had another project going
> on in parallel, didn't want to distribute efforts.
>
Sure, no problem.
> I went through the implementation approach of powerclamp, it contro
This approach looks like it should work, and I think given the point in
the release it would be acceptable for 4.6.
However long term I think it might make sense to try and reuse one of
the existing libxl__arch hooks, i.e.
libxl__arch_domain_init_hw_description or
libxl__arch_domain_finalise_hw_d
flight 59477 linux-3.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59477/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail in 58831 REGR. vs. 30511
Tests which are failing
On Mon, 2015-07-13 at 10:28 +0100, Ian Campbell wrote:
> On Sat, 2015-07-11 at 20:25 +0200, Julien Grall wrote:
> > Hi,
> >
> > On 10/07/2015 17:10, Ian Campbell wrote:
> > > Extra space after the &.
> > >> @@ -694,6 +755,14 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v,
> > >> mmio_info_t
On Mon, Jul 13, 2015 at 09:55:39AM +0100, Jan Beulich wrote:
> >>> On 13.07.15 at 05:36, wrote:
> > phys_proc_id is invalidated in remove_siblinginfo() which gets called
> > before cpu_smpboot_free(). This means calling cpu_to_socket(cpu) in
> > cpu_smpboot_free() is not possible to be correct.
>
On 2015/7/13 17:40, Ian Campbell wrote:
On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote:
I still can't understand what I'm missing here after compared to other
contexts inside xlu_pci_parse_bdf().
Perhaps comparing to the CODING_STYLE document would help?
Looks the whole xlu_pci_parse_
Note: This patch is based on original work of Arianna's internship for
GNOME's Outreach Program for Women.
Only one hardware queue is used now, so there is no performance change.
The legacy non-mq code is deleted completely which is the same as other
drivers like virtio, mtip, and nvme.
Also dro
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
I rather dislike subjects of the form "fix $function", since it gives
very little clue to someone reading the shortlog what is going on.
In this case I think "libxl: make libxl__abs_path correctly handle a
NULL argument" would be an accurate descr
On Mon, Jul 13, 2015 at 10:57:32AM +0100, Ian Campbell wrote:
> On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
>
> I rather dislike subjects of the form "fix $function", since it gives
> very little clue to someone reading the shortlog what is going on.
>
> In this case I think "libxl: make li
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> One is to combine malloc + libxl__alloc_failed. The other is to avoid
> dereferencing NULL pointer in case of malloc failure.
The non-use of a gc for the latter in particular looks a bit suspicious
to me, but nonetheless this is an improvement:
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu
Acked-by: Ian Campbell
It occurs to me that since libxl__strdup can never return NULL due to
allocation failure we could consider make libxl__strdup(gc, NULL) be
well defined as returning NULL.
> ---
> tools/libxl/libx
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> Add libxl_dominfo_dispose to one return path that doesn't have it.
>
> Signed-off-by: Wei Liu
That return is a bit at odds with the generally correct error handling
in that function, but this improves things at least a little and I can
sort of
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu
Would an "if (rc) libxl_cpupoolinfo_dispose(info)" on the exit path be a
more robust alternative? Might require the addition of a
libxl_cpupoolinfo_init() somewhere before any possible error.
> ---
> tools/libxl/libxl.c
On 06/25/2015 12:07 PM, Chunyan Liu wrote:
Add code to support pvusb in domain config file. One could specify
usbctrl and usb in domain's configuration file and create domain,
then usb controllers will be created and usb device would be attached
to guest automatically.
One could specify usb cont
On 06/25/2015 12:07 PM, Chunyan Liu wrote:
This patch series is to add pvusb toolstack work, supporting hot add|remove
USB device to|from guest and specify USB device in domain configuration file.
Patches 1-6:
Tested-by: Juergen Gross
Juergen
Changes to v4:
* use DEFINE_DEVICE_ADD and DE
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu
Acked-by: Ian Campbell
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu
Acked-by: Ian Campbell
(although the only actual reason for a failure today is a memory
allocation failure, which ought to abort really).
> ---
> tools/libxl/libxl_qmp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> dif
> -Original Message-
> From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com]
> Sent: 13 July 2015 10:42
> To: Paul Durrant; Andrew Cooper; xen-devel@lists.xen.org
> Cc: Keir (Xen.org); Jan Beulich
> Subject: Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation
>
> On 07/13/201
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> Don't dereference extra_config if it's NULL. Don't leak extra_config in
> the end.
Subject should be more descriptive. "xl: correct handling of
extra_config in main_cpupoolcreate" perhaps? (It's a lot easier to write
non-vague messages for patche
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> Don't dereference NULL.
Subject: xl: correctly handle null extra config in main_config_update
>
> Signed-off-by: Wei Liu
> ---
> tools/libxl/xl_cmdimpl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/xl
On Mon, 2015-07-13 at 17:47 +0800, Chen, Tiejun wrote:
> > This approach looks like it should work, and I think given the point in
> > the release it would be acceptable for 4.6.
> >
> > However long term I think it might make sense to try and reuse one of
> > the existing libxl__arch hooks, i.e.
>
Eric Shelton writes ("[PATCH V2 1/1] libxl: set stub domain size based on VRAM
size"):
> Allocate additional memory to the stub domain for qemu-traditional if
> more than 4 MB is assigned to the video adapter to avoid out of memory
> condition for QEMU.
Acked-by: Ian Jackson
This is IMO a bugfi
On Mon, 2015-07-13 at 17:55 +0800, Chen, Tiejun wrote:
> On 2015/7/13 17:40, Ian Campbell wrote:
> > On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote:
> >> I still can't understand what I'm missing here after compared to other
> >> contexts inside xlu_pci_parse_bdf().
> >
> > Perhaps comparing
>>> On 13.07.15 at 03:43, wrote:
> flight 59472 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/59472/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-
Ian Jackson writes ("Re: [PATCH V2 1/1] libxl: set stub domain size based on
VRAM size"):
> Eric Shelton writes ("[PATCH V2 1/1] libxl: set stub domain size based on
> VRAM size"):
> > Allocate additional memory to the stub domain for qemu-traditional if
> > more than 4 MB is assigned to the vide
From: Eric Shelton
Allocate additional memory to the stub domain for qemu-traditional if
more than 4 MB is assigned to the video adapter to avoid out of memory
condition for QEMU.
Signed-off-by: Eric Shelton
Signed-off-by: Ian Jackson
---
v3: Use max_t() instead
v2: Use max()
---
tools/libxl/
On Sat, 2015-07-11 at 15:33 +0100, Wei Liu wrote:
> Hi Chong
>
> This series is marked as "for 4.6", but we just hit feature freeze
> yesterday.
>
Yeah, I wanted to reply myself about this, but Wei beat me... Good job
as release manager, I would say. :-)
> Given the status of this series (missin
On Mon, 2015-07-13 at 11:22 +0100, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH V2 1/1] libxl: set stub domain size based on
> VRAM size"):
> > Eric Shelton writes ("[PATCH V2 1/1] libxl: set stub domain size based on
> > VRAM size"):
> > > Allocate additional memory to the stub domain fo
phys_proc_id is invalidated in remove_siblinginfo() which gets called
before cpu_smpboot_free(). This means calling cpu_to_socket(cpu) in
cpu_smpboot_free() is not possible to be correct.
This patch moves the invalidating of phys_proc_id from
remove_siblinginfo() to cpu_smpboot_free() so that cpu_
On Mon, Jul 13, 2015 at 06:55:30AM +, Wu, Feng wrote:
> Hi maintainers,
>
> We would like to request an extension for freeze exception for VT-d
> posted-interrupts patch-set.
>
> 1. clarify the state of patch series / feature.
> [v3 01/15] Vt-d Posted-interrupt (PI) design
> Reviewed-by: Kev
On Fri, 2015-07-10 at 16:39 +0100, Jan Beulich wrote:
> >>> On 10.07.15 at 17:29, wrote:
> > Add tools/tests/xen-acess to the supported list under VM EVENT/MEM ACCESS.
> > Also, changing my e-mail to the preferred one, as it is in many of the
> > headers
> > already.
> >
> > Signed-off-by: Tamas
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
> Introduce _$TOOLSTACK_check_for_command function and use it to check
> save / restore functionality.
The _$TOOLSTACK_ prefix is not necessary IMHO, this is already within a
Perl module named $TOOLSTACK.pm (which you can think of as a class in
the
flight 59483 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59483/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 11 guest-saverestore fail REGR.
vs. 59059
test-amd6
Ian Campbell writes ("Re: [PATCH V2 1/1] libxl: set stub domain size based on
VRAM size"):
> On Mon, 2015-07-13 at 11:22 +0100, Ian Jackson wrote:
> > In a moment I am going to send a v3 which uses max_t and uint64_t
> > (which is the type of the memkb fields and also obviously correct).
>
> Eric
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
> @@ -300,7 +300,9 @@ proc run-job/test-pair {} {
> }
>
> proc test-guest-migr {g} {
> -if {[catch { run-ts . = ts-migrate-support-check + host $g }]} return
> +set to_reap [spawn-ts . = ts-migrate-support-check + host $g]
Most other us
On Mon, Jul 13, 2015 at 2:52 PM, Ian Campbell wrote:
> On Sat, 2015-07-11 at 20:19 +0530, Vijay Kilari wrote:
>> >> +int vgic_its_process_cmd(struct vcpu *v, struct vgic_its *vits)
>> >> +{
>> >> +its_cmd_block virt_cmd;
>> >> +
>> >> +ASSERT(spin_is_locked(&vits->lock));
>> >> +
>> >> +
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
> @@ -23,5 +23,9 @@ use Osstest::TestSupport;
> tsreadconfig();
>
> our $ho = selecthost($ARGV[0]);
> +# $ARGV[1] is guest name, $ARG[2] indicates whether it is checking for
> +# local migration or remote migration
> +# Mode should be either 1 (
One thing that was missed in previous is how much time we have to apply
patch series that has been granted a freeze exception.
Given the fact that freeze exception would only be granted to patch
series that is very close to completion, I expect any patch series with
that status be applied within o
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
> Since we've introduced different checks for save / restore and local
> migration, it's possible to run save / restore tests without running
> local migration tests.
>
> Signed-off-by: Wei Liu
> Cc: Ian Campbell
> Cc: Ian Jackson
> ---
> sg-ru
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
Perhaps the libvirt part of the check_for_command stuff ought to be
moved here? Otherwise we are claiming support before the code is
actually willing to try to do so.
> Signed-off-by: Wei Liu
> Cc: Ian Campbell
> Cc: Ian Jackson
> Acked-by: Ian
1 - 100 of 292 matches
Mail list logo