Re: [Xen-devel] [PATCH v6 04/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

2015-03-26 Thread Yijing Wang
>>> Is there an git tree with this so I can just try it out? >> >> git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git >> pci/enumeration-yw6 has similar code (it exports the single > > I presume now it is bjorn/pci/enumeration-yw8 ? Going to test this out > this week. Hi Konrad, I fixe

Re: [Xen-devel] [PATCH v2] tools/mkrpm: improve version.release handling

2015-03-26 Thread Olaf Hering
On Wed, Mar 25, George Dunlap wrote: > Reviewed-by: George Dunlap > Tested-by: George Dunlap Thanks. Whoever is in charge, please backport to staging-4.5 as well. Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/1] hvm.c: Prevent gcc uninitialised var warning

2015-03-26 Thread Jan Beulich
>>> On 25.03.15 at 21:03, wrote: > On 03/25/15 11:48, Jan Beulich wrote: > On 25.03.15 at 16:02, wrote: >>> As an aside, the compiler is in a very easy position to spot this. The >>> error means that GCC has positively identified a basic block which does >>> use bufioreq_pfn before it has be

Re: [Xen-devel] [PATCH v3 1/2] x86: simplify non‑atomic bitops

2015-03-26 Thread Jan Beulich
>>> On 25.03.15 at 18:49, wrote: > On 20/03/15 14:53, Jan Beulich wrote: >> - being non-atomic, their pointer arguments shouldn't be volatile- >>qualified >> - their (half fake) memory operands can be a single "+m" instead of >>being both an output and an input >> >> Signed-off-by: Jan Beu

Re: [Xen-devel] [PATCH] x86: don't change affinity with interrupt unmasked

2015-03-26 Thread Jan Beulich
>>> On 25.03.15 at 19:12, wrote: >> Changing the affinity of non-maskable MSI IRQs seems bogus too > > Agreed. Their affinity can clearly only be changed safely by a device > driver which can guarantee that an interrupt will not be generated > during the vulnerable period. > > This further im

Re: [Xen-devel] [PATCH] sysctl: Don't overwrite array size variable when it is set on error earlier

2015-03-26 Thread Jan Beulich
>>> On 25.03.15 at 18:12, wrote: > On 25/03/15 17:09, Boris Ostrovsky wrote: >> When querying CPU topology, if caller-provided array size is smaller than >> number of online CPUs then, in addition to returning -ENOBUFS, sysctl is >> expected to provide back this number. However, this value, stored

[Xen-devel] [linux-linus test] 36746: tolerable FAIL - PUSHED

2015-03-26 Thread xen . org
flight 36746 linux-linus real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36746/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-rumpuserxen-amd64 11 rumpuserxen-demo-xenstorels/xenstorels fail REGR. vs. 35883 test-amd64

[Xen-devel] [PATCH v2 1/3] libxl: check whether vcpu affinity and vnuma info match

2015-03-26 Thread Dario Faggioli
More specifically, vcpus are assigned to a vnode, which in turn is associated with a pnode. If a vcpu also has, in its (hard or soft) affinity, some pcpus that are not part of the said pnode, print a warning to the user. Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano

[Xen-devel] [PATCH v2 2/3] libxl: automatically set soft affinity after vnuma info

2015-03-26 Thread Dario Faggioli
More specifically, vcpus are assigned to a vnode, which in turn is associated with a pnode. If a vcpu does not have any soft affinity, automatically build up one, matching the pcpus of the said pnode. Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei

[Xen-devel] [PATCH v2 0/3] Automatically derive soft affinity from vnuma information

2015-03-26 Thread Dario Faggioli
Round 2. All patches have Wei's Ack. Wei, I modified the comment of libxl__vnuma_config_check() and added your ack on patch 1, as you said during review. This is available as a git branch here: git://xenbits.xen.org/people/dariof/xen.git rel/numa/vnuma/softaffinity-v2 Regards, Dario --- Dari

[Xen-devel] [PATCH v2 3/3] libxl: cleanup some misuse of 'cpumap' as parameter

2015-03-26 Thread Dario Faggioli
in favour of the more generic 'bitmap', which is better since these are generic libxl_bitmap_* functions. Also fix a typo, and remove a stale (and wrong) comment. No functional change intended. Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu

Re: [Xen-devel] ARM: KVM/XEN: how should we support virt-what?

2015-03-26 Thread Andrew Jones
On Wed, Mar 25, 2015 at 10:44:42AM +0100, Andrew Jones wrote: > Hello ARM virt maintainers, > > I'd like to start a discussion about supporting virt-what[1]. virt-what > allows userspace to determine if the system it's running on is running > in a guest, and of what type (KVM, Xen, etc.). Despite

Re: [Xen-devel] [xen-unstable test] 36728: regressions - FAIL

2015-03-26 Thread Jan Beulich
>>> On 26.03.15 at 05:36, wrote: > flight 36728 xen-unstable real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/36728/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-xl-credit2 12 guest-localmigrat

[Xen-devel] [PATCH v3 4/4] sched: credit2: consider per-vcpu soft affinity

2015-03-26 Thread Justin T. Weaver
when making decisions for vcpus (run queue assignment, run queue migration, cpu assignment, and cpu tickling). Added soft affinity balancing loops to... * get_fallback_cpu * runq_tickle (one for idle, but not tickled; one for non-idle, and not tickled) * choose_cpu choose_cpu now tries to f

[Xen-devel] [PATCH v3 2/4] sched: factor out per-vcpu affinity related code to common header file

2015-03-26 Thread Justin T. Weaver
Move affinity balancing related functions and defines from sched_credit.c to sched-if.h so other schedulers can use them. Change name prefixes from csched to sched since they are no longer specific to the credit scheduler. Signed-off-by: Justin T. Weaver --- Changes in v3: First introduced in pat

[Xen-devel] [PATCH v3 0/4] sched: credit2: introduce per-vcpu hard and soft affinity

2015-03-26 Thread Justin T. Weaver
Hello, The credit2 vcpu scheduler currently ignores per-vcpu hard and soft affinity masks. The first patch updates the scheduler to ensure that vcpus only run on pcpus on which they are allowed to run (hard affinity). I tested it using xl vcpu-pin and xl vcpu-list. I changed the affinity in diffe

[Xen-devel] [PATCH v3 3/4] sched: credit2: indent code sections to make review of patch 4/4 easier

2015-03-26 Thread Justin T. Weaver
Functions runq_tickle and choose_cpu both have code sections that get turned into loops in patch 4 v3, soft affinity. Do the indenting here to make the patch 4 diff section easier to read. This patch does not have any changes other than the addition of one four-space indent per line. Signed-off-by

[Xen-devel] [PATCH v3 1/4] sched: credit2: respect per-vcpu hard affinity

2015-03-26 Thread Justin T. Weaver
by making sure that vcpus only run on the pcpu(s) they are allowed to run on based on their hard affinity cpu masks. Signed-off-by: Justin T. Weaver --- Changes in v3: (all v3 changes are based on v2 review comments) * Renamed cpumask to scratch_mask * Renamed function get_safe_pcpu to get_fall

[Xen-devel] [PATCH] VT-d: improve fault info logging

2015-03-26 Thread Jan Beulich
I got repeatedly annoyed by there not getting anything logged by default on VT-d faults (and hence having to tell people to add extra command line options), and hence I think it is time to redo this code: Log basic fault information at guest-warning level (rate limited by default), and show the pag

Re: [Xen-devel] [PATCH v3 1/2] x86: simplify non‑atomic bitops

2015-03-26 Thread Andrew Cooper
On 26/03/15 08:00, Jan Beulich wrote: On 25.03.15 at 18:49, wrote: On 20/03/15 14:53, Jan Beulich wrote: - being non-atomic, their pointer arguments shouldn't be volatile- qualified - their (half fake) memory operands can be a single "+m" instead of being both an output and an input S

Re: [Xen-devel] [PATCH v3 7/7] libxl/vcpu-set - allow to decrease vcpu count on overcommitted guests (v3)

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 14:42 -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 24, 2015 at 03:41:46PM +, Ian Campbell wrote: > > On Mon, 2015-03-23 at 14:21 -0400, Konrad Rzeszutek Wilk wrote: > > > We have a check to warn the user if they are overcommitting. > > > But the check only checks the

Re: [Xen-devel] [PATCH v3 3/7] libxl: In libxl_set_vcpuonline check for maximum number of VCPUs against the cpumap.

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 14:44 -0400, Konrad Rzeszutek Wilk wrote: > +if (type == LIBXL_DOMAIN_TYPE_HVM || type == LIBXL_DOMAIN_TYPE_PV) { I think just do the libxl_domain_info unconditionally and handle the error if it doesn't work. Otherwise looked good, but please try and const-ify the info

Re: [Xen-devel] [PATCH OSSTEST 04/12] toolstack: distinguish local and remote migration support

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 15:18 -0600, Jim Fehlig wrote: > Ian Campbell wrote: > > On Mon, 2015-02-09 at 11:09 +, Wei Liu wrote: > > > >> Libvirt supports migrating a guest to remote host but not local host. > >> > > > > Jim, is that right? > > > > Opps, I missed this mail. Sorry for t

Re: [Xen-devel] [PATCH 2/3] xen: arm: correctly handle continuations for 64-bit guests

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 22:39 +, Julien Grall wrote: > Hi Ian, > > On 25/03/2015 15:34, Ian Campbell wrote: > > The 64-bit ABI is different to 32-bit: > > > > - uses x16 as the op register rather than r12. > > - arguments in x0..x5 and not r0..r5. Using rN here potentially > > truncates.

Re: [Xen-devel] [PATCH 3/3] xen: arm: handle thumb mode guest in continuations

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 23:33 +, Julien Grall wrote: > Hi Ian, > > On 25/03/2015 15:34, Ian Campbell wrote: > > PC only needs adjusting by 2, otherwise we rerun the instruction prior > > to the hvc as well. > > I don't understand why you have to adjust PC by 2 for thumb. > The spec encodes the

Re: [Xen-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-26 Thread Ian Campbell
On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: > > Hrm, OK. I suppose we can live with autodetect and igd both meaning igd > > and whoever adds a new type will have to remember to add a check for > > qemu-trad then. > > > > When we really have to introduce a new type, this means we probabl

Re: [Xen-devel] [PATCH] VT-d: improve fault info logging

2015-03-26 Thread Andrew Cooper
On 26/03/15 09:55, Jan Beulich wrote: I got repeatedly annoyed by there not getting anything logged by default on VT-d faults (and hence having to tell people to add extra command line options), and hence I think it is time to redo this code: Log basic fault information at guest-warning level (ra

Re: [Xen-devel] [PATCH 02/11] VMX: implement suppress #VE.

2015-03-26 Thread Tim Deegan
At 10:30 -0700 on 25 Mar (1427279417), Ed White wrote: > On 01/15/2015 10:46 AM, Ed White wrote: > > On 01/15/2015 08:25 AM, Tim Deegan wrote: > >> Hi, > >> > >> At 13:26 -0800 on 09 Jan (1420806392), Ed White wrote: > >>> static inline bool_t is_epte_valid(ept_entry_t *e) > >>> { > >>> -retu

Re: [Xen-devel] [PATCH V7 01/12] xen/mem_event: Cleanup of mem_event structures

2015-03-26 Thread Jan Beulich
>>> On 12.03.15 at 18:58, wrote: > The public mem_event structures used to communicate with helper applications > via > shared rings have been used in different settings. However, the variable > names > within this structure have not reflected this fact, resulting in the reuse > of > variables

Re: [Xen-devel] [PATCH V7 06/12] x86/hvm: factor out and rename vm_event related functions

2015-03-26 Thread Jan Beulich
>>> On 12.03.15 at 18:58, wrote: > To avoid growing hvm.c these functions can be stored separately. Minor style > changes are applied to the logic in the file. > > Signed-off-by: Tamas K Lengyel > Acked-by: Kevin Tian > Acked-by: Tim Deegan Acked-by: Jan Beulich ___

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-03-26 Thread Tim Deegan
At 10:41 -0700 on 25 Mar (1427280115), Ed White wrote: > >> > >> The second thing is how similar some of this is to nested p2m code, > >> making me wonder whether it could share more code with that. It's not > >> as much duplication as I had feared, but e.g. altp2m_write_p2m_entry() > >> is _ident

Re: [Xen-devel] [PATCH 05/11] x86/altp2m: basic data structures and support routines.

2015-03-26 Thread Tim Deegan
At 13:59 -0700 on 25 Mar (1427291983), Ed White wrote: > >>> diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c > >>> index abf3d7a..8fe0650 100644 > >>> --- a/xen/arch/x86/mm/hap/hap.c > >>> +++ b/xen/arch/x86/mm/hap/hap.c > >>> @@ -439,7 +439,7 @@ void hap_domain_init(struct domai

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Jan Beulich
>>> On 12.03.15 at 18:58, wrote: > @@ -91,41 +88,55 @@ static int hvm_event_traps(uint64_t parameters, > vm_event_request_t *req) > return 1; > } > > -static void hvm_event_cr(uint32_t reason, unsigned long value, > - unsigned long old, uint64_t parameters) > +stat

Re: [Xen-devel] [PATCH V13 5/7] xen/arm: Instruction prefetch abort (X) mem_event handling

2015-03-26 Thread Ian Campbell
On Tue, 2015-03-24 at 14:06 +0100, Tamas K Lengyel wrote: > according to the ARM ARM v8 split TLB is possible, see section TLB > matching (page 1826): "In some cases, the TLB can hold two mappings > for the same address". In fact, it seems like some hardware can even > detect such cases and cause

[Xen-devel] [PATCH v2] xen: arm: correctly handle continuations for 64-bit guests

2015-03-26 Thread Ian Campbell
The 64-bit ABI is different to 32-bit: - uses x16 as the op register rather than r12. - arguments in x0..x5 and not r0..r5. Using rN here potentially truncates. - return value goes in x0, not r0. Hypercalls can only be made directly from kernel space, so checking the domain's size is suffic

Re: [Xen-devel] [PATCH V7 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-03-26 Thread Jan Beulich
>>> On 12.03.15 at 18:58, wrote: > --- a/xen/include/public/memory.h > +++ b/xen/include/public/memory.h > @@ -385,11 +385,10 @@ typedef struct xen_mem_paging_op xen_mem_paging_op_t; > DEFINE_XEN_GUEST_HANDLE(xen_mem_paging_op_t); > > #define XENMEM_access_op21 > -#define X

Re: [Xen-devel] [PATCH 02/12] xen: arm: handle accesses to CNTP_CVAL_EL0

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 18:32 +, Julien Grall wrote: > On 25/03/15 14:22, Ian Campbell wrote: > > +static int vtimer_cntp_cval(struct cpu_user_regs *regs, uint64_t *r, int > > read) > > +{ > > +struct vcpu *v = current; > > + > > +if ( psr_mode_is_user(regs) && > > + !(READ_SYSRE

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Tamas K Lengyel
On Thu, Mar 26, 2015 at 11:50 AM, Jan Beulich wrote: On 12.03.15 at 18:58, wrote: >> @@ -91,41 +88,55 @@ static int hvm_event_traps(uint64_t parameters, >> vm_event_request_t *req) >> return 1; >> } >> >> -static void hvm_event_cr(uint32_t reason, unsigned long value, >> -

Re: [Xen-devel] [PATCH 06/12] xen: arm: correctly handle vtimer traps from userspace

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 18:41 +, Julien Grall wrote: > Hi Ian, > > On 25/03/15 14:22, Ian Campbell wrote: > > -static void vtimer_cntp_tval(struct cpu_user_regs *regs, uint32_t *r, int > > read) > > +static int vtimer_cntp_tval(struct cpu_user_regs *regs, uint32_t *r, int > > read) > > { > >

[Xen-devel] Nested EPT flushes on p2m change?

2015-03-26 Thread Tim Deegan
Hi, VMX maintainers, I was looking at the nested EPT code while following up on Ed's email about altp2m design, and I can't see where nested-EPT entries get removed when a host EPT entry is removed/changed. On nested NPT, this is handled in hap_write_p2m_entry(), which detects that the domain has

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Tim Deegan
At 12:08 +0100 on 26 Mar (1427371713), Tamas K Lengyel wrote: > Thanks, I'll be sending v8 of the series today. Are there any plans to > merge the early parts of the series that have been acked while these > patches at the end receive final touch-ups? Yes, I'm going to apply 0-6 now. Cheers, Tim

[Xen-devel] [PATCH] xen-netfront: transmit fully GSO-sized packets

2015-03-26 Thread Jonathan Davies
xen-netfront limits transmitted skbs to be at most 44 segments in size. However, GSO permits up to 65536 bytes, which means a maximum of 45 segments of 1448 bytes each. This slight reduction in the size of packets means a slight loss in efficiency. Since c/s 9ecd1a75d, xen-netfront sets gso_max_si

Re: [Xen-devel] [PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Roger Pau Monné
Hello, El 25/03/15 a les 11.02, Bob Liu ha escrit: > + gnttab_unmap_refs_async(&unmap_data); > + wait_for_completion(&unmap_completion); I think David had a comment about putting this into some kind of common helper since it's used widely (at least in blkback). Could you l

Re: [Xen-devel] [PATCH 07/12] xen: arm: Handle CP15 register traps from userspace

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 18:59 +, Julien Grall wrote: > Hi Ian, > > On 25/03/15 14:22, Ian Campbell wrote: > > Previously userspace access to PM* would have been incorrectly (but > > benignly) implemented as RAZ/WI when running on a 32-bit kernel and > > would cause a hypervisor exception (host c

Re: [Xen-devel] [PATCH v2 2/2] iommu: add rmrr Xen command line option for misc rmrrs

2015-03-26 Thread Jan Beulich
>>> On 24.03.15 at 17:08, wrote: > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -1170,6 +1170,14 @@ Specify the host reboot method. > 'efi' instructs Xen to reboot using the EFI reboot call (in EFI mode by > default it will use that method first). >

Re: [Xen-devel] [PATCH 1/1] hvm.c: Prevent gcc uninitialised var warning

2015-03-26 Thread Ian Murray
- Original Message - > From: Jan Beulich > To: Don Slutz > Cc: Ian Murray ; Andrew Cooper > ; Keir Fraser ; Ian Campbell > ; xen-devel@lists.xen.org > Sent: Thursday, 26 March 2015, 7:48 > Subject: Re: [Xen-devel] [PATCH 1/1] hvm.c: Prevent gcc uninitialised var > warning > >>

Re: [Xen-devel] [PATCH] xen-blkback: enlarge the array size of blkback name

2015-03-26 Thread Roger Pau Monné
El 13/03/15 a les 16.52, Tao Chen ha escrit: > The blkback name is like blkback.domid.xvd[a-z], if domid has three digits > (means larger than 100), then the backmost xvd wouldn't be fully shown. > > Define a BLKBACK_NAME_LEN macro which is (TASK_COMM_LEN * 2), enlarge the > array size of blkback

Re: [Xen-devel] [PATCH V13 5/7] xen/arm: Instruction prefetch abort (X) mem_event handling

2015-03-26 Thread Tamas K Lengyel
On Thu, Mar 26, 2015 at 11:50 AM, Ian Campbell wrote: > On Tue, 2015-03-24 at 14:06 +0100, Tamas K Lengyel wrote: > >> according to the ARM ARM v8 split TLB is possible, see section TLB >> matching (page 1826): "In some cases, the TLB can hold two mappings >> for the same address". In fact, it see

Re: [Xen-devel] [PATCH V7 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-03-26 Thread Tamas K Lengyel
On Thu, Mar 26, 2015 at 11:56 AM, Jan Beulich wrote: On 12.03.15 at 18:58, wrote: >> --- a/xen/include/public/memory.h >> +++ b/xen/include/public/memory.h >> @@ -385,11 +385,10 @@ typedef struct xen_mem_paging_op xen_mem_paging_op_t; >> DEFINE_XEN_GUEST_HANDLE(xen_mem_paging_op_t); >> >>

Re: [Xen-devel] [PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Bob Liu
On 03/26/2015 07:15 PM, Roger Pau Monné wrote: > Hello, > > El 25/03/15 a les 11.02, Bob Liu ha escrit: >> +gnttab_unmap_refs_async(&unmap_data); >> +wait_for_completion(&unmap_completion); > > I think David had a comment about putting this into some kind of common > help

Re: [Xen-devel] [PATCH 09/12] xen: arm: correctly handle sysreg accesses from userspace

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 19:22 +, Julien Grall wrote: > Do you have a paragraph on the spec which clearly explain the > behavior? Not clearly enough :-( I think to be on the safe side I'm going to make most of these occurrences in this series inject a trap to EL1, unless I can find a non-ambiguo

Re: [Xen-devel] [PATCH V7 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-03-26 Thread Jan Beulich
>>> On 26.03.15 at 12:29, wrote: > On Thu, Mar 26, 2015 at 11:56 AM, Jan Beulich wrote: > On 12.03.15 at 18:58, wrote: >>> --- a/xen/include/public/memory.h >>> +++ b/xen/include/public/memory.h >>> @@ -385,11 +385,10 @@ typedef struct xen_mem_paging_op xen_mem_paging_op_t; >>> DEFINE_XEN_G

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Tim Deegan
At 11:13 + on 26 Mar (1427368409), Tim Deegan wrote: > At 12:08 +0100 on 26 Mar (1427371713), Tamas K Lengyel wrote: > > Thanks, I'll be sending v8 of the series today. Are there any plans to > > merge the early parts of the series that have been acked while these > > patches at the end receive

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Tamas Lengyel
On Thu, Mar 26, 2015 at 12:44 PM, Tim Deegan wrote: > At 11:13 + on 26 Mar (1427368409), Tim Deegan wrote: > > At 12:08 +0100 on 26 Mar (1427371713), Tamas K Lengyel wrote: > > > Thanks, I'll be sending v8 of the series today. Are there any plans to > > > merge the early parts of the series t

Re: [Xen-devel] [PATCH V7 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-03-26 Thread Andrew Cooper
On 26/03/15 11:45, Jan Beulich wrote: On 26.03.15 at 12:29, wrote: On Thu, Mar 26, 2015 at 11:56 AM, Jan Beulich wrote: On 12.03.15 at 18:58, wrote: --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -385,11 +385,10 @@ typedef struct xen_mem_paging_op xen_mem_paging_op_t

Re: [Xen-devel] [PATCH V7 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-03-26 Thread Tim Deegan
At 11:45 + on 26 Mar (1427370322), Jan Beulich wrote: > >>> On 26.03.15 at 12:29, wrote: > > On Thu, Mar 26, 2015 at 11:56 AM, Jan Beulich wrote: > > On 12.03.15 at 18:58, wrote: > >>> --- a/xen/include/public/memory.h > >>> +++ b/xen/include/public/memory.h > >>> @@ -385,11 +385,10 @@ t

Re: [Xen-devel] [PATCH V13 5/7] xen/arm: Instruction prefetch abort (X) mem_event handling

2015-03-26 Thread Ian Campbell
On Thu, 2015-03-26 at 12:24 +0100, Tamas K Lengyel wrote: > >> I looked at the KVM code and they seem to query HPFAR_EL2 if the > >> fault is during s1ptw, but otherwise they do exactly what we do here. > > > > Yes, reading their comment there lead me to the bit of the ARM ARM and I > > think the

Re: [Xen-devel] [PATCH v2] xen: arm: correctly handle continuations for 64-bit guests

2015-03-26 Thread Julien Grall
Hi Ian, On 26/03/2015 10:54, Ian Campbell wrote: The 64-bit ABI is different to 32-bit: - uses x16 as the op register rather than r12. - arguments in x0..x5 and not r0..r5. Using rN here potentially truncates. - return value goes in x0, not r0. Hypercalls can only be made directly fr

Re: [Xen-devel] [PATCH] xen-netfront: transmit fully GSO-sized packets

2015-03-26 Thread Eric Dumazet
On Thu, 2015-03-26 at 11:13 +, Jonathan Davies wrote: > xen-netfront limits transmitted skbs to be at most 44 segments in size. > However, > GSO permits up to 65536 bytes, which means a maximum of 45 segments of 1448 > bytes each. This slight reduction in the size of packets means a slight los

Re: [Xen-devel] [xen-4.3-testing test] 36695: regressions - FAIL

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 15:52 +, Jan Beulich wrote: > >>> On 25.03.15 at 10:27, wrote: > > On Wed, 2015-03-25 at 08:33 +, xen.org wrote: > >> flight 36695 xen-4.3-testing real [real] > >> http://www.chiark.greenend.org.uk/~xensrcts/logs/36695/ > >> > >> Regressions :-( > >> > >> Tests whi

[Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-03-26 Thread Bob Liu
There are several place using gnttab async unmap and wait for completion, so move the common code to a function gnttab_unmap_refs_async_wait_completion(). Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 31 +++ drivers/xen/gntdev.c| 28

[Xen-devel] [PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Bob Liu
Commit c43cf3ea8385 ("xen-blkback: safely unmap grants in case they are still in use") use gnttab_unmap_refs_async() to wait until the mapped pages are no longer in use before unmapping them, but that commit missed the persistent case. Purge persistent pages can't be unmapped either unless no longe

[Xen-devel] [PATCH] x86_emulate: split the {reg, mem} union in struct operand.

2015-03-26 Thread Tim Deegan
In the hopes of making any future errors along the lines of XSA-123 into clean crashes instead of memory corruption bugs. Signed-off-by: Tim Deegan CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper --- xen/arch/x86/x86_emulate/x86_emulate.c | 8 +--- 1 file changed, 5 insertions(+), 3 del

Re: [Xen-devel] [PATCH] x86_emulate: split the {reg, mem} union in struct operand.

2015-03-26 Thread Andrew Cooper
On 26/03/15 12:16, Tim Deegan wrote: In the hopes of making any future errors along the lines of XSA-123 into clean crashes instead of memory corruption bugs. Signed-off-by: Tim Deegan CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper I am very much in favour of this change. Does REG_POIS

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Tamas K Lengyel
On Thu, Mar 26, 2015 at 11:50 AM, Jan Beulich wrote: On 12.03.15 at 18:58, wrote: >> @@ -91,41 +88,55 @@ static int hvm_event_traps(uint64_t parameters, >> vm_event_request_t *req) >> return 1; >> } >> >> -static void hvm_event_cr(uint32_t reason, unsigned long value, >> -

[Xen-devel] [linux-next test] 36749: regressions - FAIL

2015-03-26 Thread xen . org
flight 36749 linux-next real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36749/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-win7-amd64 5 xen-boot fail REGR. vs. 36691 test-amd64-i386-xl-qem

Re: [Xen-devel] [PATCH] x86_emulate: split the {reg, mem} union in struct operand.

2015-03-26 Thread Tim Deegan
At 12:25 + on 26 Mar (1427372755), Andrew Cooper wrote: > On 26/03/15 12:16, Tim Deegan wrote: > > In the hopes of making any future errors along the lines of XSA-123 > > into clean crashes instead of memory corruption bugs. > > > > Signed-off-by: Tim Deegan > > CC: Keir Fraser > > CC: Jan Be

[Xen-devel] [PATCH v3 2/8] x86: improve psr scheduling code

2015-03-26 Thread Chao Peng
Switching RMID from previous vcpu to next vcpu only needs to write MSR_IA32_PSR_ASSOC once. Write it with the value of next vcpu is enough, no need to write '0' first. Idle domain has RMID set to 0 and because MSR is already updated lazily, so just switch it as it does. Also move the initializatio

[Xen-devel] [PATCH v3 3/8] x86: detect and initialize Intel CAT feature

2015-03-26 Thread Chao Peng
Detect Intel Cache Allocation Technology(CAT) feature and store the cpuid information for later use. Currently only L3 cache allocation is supported. The L3 CAT features may vary among sockets so per-socket feature information is stored. The initialization can happen either at boot time or when CPU

[Xen-devel] [PATCH v3 0/8] enable Cache Allocation Technology (CAT) for VMs

2015-03-26 Thread Chao Peng
Changes in v3: * Address comments from Jan and Ian(Detail in patch). * Add xl sample output in cover letter. Changes in v2: * Address comments from Konrad and Jan(Detail in patch): * Make all cat unrelated changes into the preparation patches. This patch serial enable the new Cache Allocation Tec

[Xen-devel] [PATCH v3 4/8] x86: add support for COS/CBM manangement

2015-03-26 Thread Chao Peng
CAT introduces a mechanism for software to enable cache allocation based on application priority or Class of Service(COS). Each COS can be configured using capacity bitmasks(CBM) to represent cache capacity and indicate the degree of overlap and isolation between COSs. In XEN implementation, the c

[Xen-devel] [PATCH v3 5/8] x86: add scheduling support for Intel CAT

2015-03-26 Thread Chao Peng
On context switch, write the the domain's Class of Service(COS) to MSR IA32_PQR_ASSOC, to notify hardware to use the new COS. For performance reason, the socket number and COS mask for current cpu is also cached in the local per-CPU variable. Signed-off-by: Chao Peng --- Changes in v2: * merge c

[Xen-devel] [PATCH v3 1/8] x86: clean up psr boot parameter parsing

2015-03-26 Thread Chao Peng
Change type of opt_psr from bool to int so more psr features can fit. Introduce a new routine to parse bool parameter so that both cmt and future psr features like cat can use it. Signed-off-by: Chao Peng --- Changes in v3: * Set "off" value explicity if requested. --- xen/arch/x86/psr.c | 40 +

[Xen-devel] [PATCH v3 6/8] xsm: add CAT related xsm policies

2015-03-26 Thread Chao Peng
Add xsm policies for Cache Allocation Technology(CAT) related hypercalls to restrict the functions visibility to control domain only. Signed-off-by: Chao Peng Acked-by: Daniel De Graaf --- tools/flask/policy/policy/modules/xen/xen.if | 2 +- tools/flask/policy/policy/modules/xen/xen.te | 4 +++

[Xen-devel] [PATCH v3 8/8] tools: add tools support for Intel CAT

2015-03-26 Thread Chao Peng
This is the xc/xl changes to support Intel Cache Allocation Technology(CAT). Two commands are introduced: - xl psr-cat-cbm-set [-s socket] Set cache capacity bitmasks(CBM) for a domain. - xl psr-cat-show Show Cache Allocation Technology information. Signed-off-by: Chao Peng --- Changes in

[Xen-devel] [PATCH v3 7/8] tools/libxl: introduce libxl_count_physical_sockets

2015-03-26 Thread Chao Peng
Introduce a util function libxl_count_physical_sockets() to get physical socket count. Replaced CMT code with the new function in xl. Signed-off-by: Chao Peng --- tools/libxl/libxl_utils.c | 17 + tools/libxl/libxl_utils.h | 2 ++ tools/libxl/xl_cmdimpl.c | 11 +++ 3 fi

[Xen-devel] [PATCH v2] x86_emulate: split the {reg, mem} union in struct operand.

2015-03-26 Thread Tim Deegan
In the hopes of making any future errors along the lines of XSA-123 into clean crashes instead of memory corruption bugs. Signed-off-by: Tim Deegan CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper --- v2: tweak poison values (Andrew Cooper) --- xen/arch/x86/x86_emulate/x86_emulate.c | 12 +++

Re: [Xen-devel] [PATCH v2] x86_emulate: split the {reg, mem} union in struct operand.

2015-03-26 Thread Andrew Cooper
On 26/03/15 12:40, Tim Deegan wrote: In the hopes of making any future errors along the lines of XSA-123 into clean crashes instead of memory corruption bugs. Signed-off-by: Tim Deegan CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Reviewed-by: Andrew Cooper --- v2: tweak poison valu

[Xen-devel] [PATCH RFC 1/4] build: Reorganize and briefly document "external repo" template in tools/Makefile

2015-03-26 Thread George Dunlap
No functional changes. Signed-off-by: George Dunlap --- CC: Ian Campbell CC: Ian Jackson CC: Wei Liu CC: Dave Scott CC: Jonathan Ludlam CC: Wen Congyang CC: Yang Hongyang --- tools/Makefile | 52 1 file changed, 44 insertions(+), 8 dele

[Xen-devel] [PATCH RFC 3/4] libxl: Use XenServer's blktap2.5

2015-03-26 Thread George Dunlap
Switch to installing blktap2.5 and not building or installing in-tree blktap2. Port libxl to run on the newest blktap2.5. tap_ctl_find() has gone away, so in some cases we use tap_ctl_find_minor(), and in other cases we use a locally-reimplemented version of tap_ctl_find(). tap_ctl_create() has

[Xen-devel] [PATCH RFC 0/4] tools: Upstream blktap "2.5" as an external repo

2015-03-26 Thread George Dunlap
For some time, the blktap2 in-tree has bitrotted. Many years ago the XenServer team at Citrix forked the code into a separate repository; several attempts have been made to upstream those changes back into Xen, to no avail. The blktap code at the moment is the only source of performant vhd format

[Xen-devel] [PATCH RFC 2/4] build: Download and build extnernal blktap2.5 repo

2015-03-26 Thread George Dunlap
Download and build XenServer's blktap as an external tree, similar to qemu-xen. As of this patch we just download and build it, but don't install or use it. Signed-off-by: George Dunlap --- FIXME: Directly use the XenServer github repo for now, while we're discussing things. If we decide to ta

[Xen-devel] [PATCH RFC 4/4] tools: Remove in-tree blktap2

2015-03-26 Thread George Dunlap
This patch is pure removal; the switch to using upstream blktap happened in a previous patch. Signed-off-by: George Dunlap --- CC: Ian Campbell CC: Ian Jackson CC: Wei Liu CC: Dave Scott CC: Jonathan Ludlam CC: Wen Congyang CC: Yang Hongyang --- tools/blktap2/Makefile

Re: [Xen-devel] [PATCH V7 12/12] xen/vm_event: Add RESUME option to vm_event_op domctl

2015-03-26 Thread Jan Beulich
>>> On 26.03.15 at 12:48, wrote: > On 26/03/15 11:45, Jan Beulich wrote: > On 26.03.15 at 12:29, wrote: >>> On Thu, Mar 26, 2015 at 11:56 AM, Jan Beulich wrote: >>> On 12.03.15 at 18:58, wrote: > --- a/xen/include/public/memory.h > +++ b/xen/include/public/memory.h > @@ -385

Re: [Xen-devel] [PATCH RFC 2/4] build: Download and build extnernal blktap2.5 repo

2015-03-26 Thread Ian Campbell
On Thu, 2015-03-26 at 12:46 +, George Dunlap wrote: Typo in $subject. > FIXME: Directly use the XenServer github repo for now, while we're > discussing things. If we decide to take this series, we'll have to > clone the tree on xenbits and remove the FIXME line. We would also need to decide

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Jan Beulich
>>> On 26.03.15 at 13:30, wrote: > On Thu, Mar 26, 2015 at 11:50 AM, Jan Beulich wrote: > On 12.03.15 at 18:58, wrote: >>> @@ -91,41 +88,55 @@ static int hvm_event_traps(uint64_t parameters, >>> vm_event_request_t *req) >>> return 1; >>> } >>> >>> -static void hvm_event_cr(uint32_t re

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-26 Thread Olaf Hering
On Fri, Mar 13, Ian Campbell wrote: > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > > > > +("feature_host", bool), > > > > > What is this feature thing? What does !host imply? > > > > This enables raw SCSI command passthrough in xenlinux. If the flag is > > > > off th

Re: [Xen-devel] Redhat 6 VM crash on Xen when cpu number reaches 64

2015-03-26 Thread Vitaly Kuznetsov
"Ouyang Zhaowei (Charles)" writes: > Hi all: > > Now a days, we tested Redhat 6.2(6.4) on Xen(version 4.1.2). > If we config the cpu number more than 32, it'll show 32 in > the VM, and if we config it 64 cpus, the VM will crash and > the log is list below. > > Can someone tell us why is this happ

[Xen-devel] osstest going live in new test colo

2015-03-26 Thread Ian Jackson
Based on our commissioning tests, the new facility now has greater capacity and better reliability than the existing setup in the Citrix Cambridge office. I'm therefore going to set the new system going in production mode, and shut down the old one. There are a few loose ends to get the cron jobs

Re: [Xen-devel] [PATCH 2/2] x86: Replace this_cpu_sp0 with current_top_of_stack and fix it on x86_32

2015-03-26 Thread Boris Ostrovsky
On 03/06/2015 08:50 PM, Andy Lutomirski wrote: I broke 32-bit kernels. The implementation of sp0 was correct as far as I can tell, but sp0 was much weirder on x86_32 than I realized. It has the following issues: - Init's sp0 is inconsistent with everything else's: non-init tasks are offs

Re: [Xen-devel] [Wg-test-framework] osstest going live in new test colo

2015-03-26 Thread Chris Shepherd
And thanks Ian for your vision and dogged persistence on this. Great to have this up and running! -Original Message- From: wg-test-framework-boun...@lists.xenproject.org [mailto:wg-test-framework-boun...@lists.xenproject.org] On Behalf Of Ian Jackson Sent: 26 March 2015 13:25 To: wg-tes

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-26 Thread Ian Campbell
On Thu, 2015-03-26 at 13:55 +0100, Olaf Hering wrote: > On Fri, Mar 13, Ian Campbell wrote: > > > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > > > > > +("feature_host", bool), > > > > > > What is this feature thing? What does !host imply? > > > > > This enables raw S

Re: [Xen-devel] [PATCH RFC 0/4] tools: Upstream blktap "2.5" as an external repo

2015-03-26 Thread George Dunlap
On Thu, Mar 26, 2015 at 12:46 PM, George Dunlap wrote: > For some time, the blktap2 in-tree has bitrotted. Many years ago the > XenServer team at Citrix forked the code into a separate repository; > several attempts have been made to upstream those changes back into > Xen, to no avail. > > The bl

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Tamas Lengyel
On Thu, Mar 26, 2015 at 1:55 PM, Jan Beulich wrote: > >>> On 26.03.15 at 13:30, wrote: > > On Thu, Mar 26, 2015 at 11:50 AM, Jan Beulich wrote: > > On 12.03.15 at 18:58, wrote: > >>> @@ -91,41 +88,55 @@ static int hvm_event_traps(uint64_t parameters, > vm_event_request_t *req) > >>> r

Re: [Xen-devel] [PATCH RFC 2/4] build: Download and build extnernal blktap2.5 repo

2015-03-26 Thread George Dunlap
On Thu, Mar 26, 2015 at 12:55 PM, Ian Campbell wrote: > On Thu, 2015-03-26 at 12:46 +, George Dunlap wrote: > > Typo in $subject. > >> FIXME: Directly use the XenServer github repo for now, while we're >> discussing things. If we decide to take this series, we'll have to >> clone the tree on

Re: [Xen-devel] [PATCH] xen-netfront: transmit fully GSO-sized packets

2015-03-26 Thread Sergei Shtylyov
Hello. On 3/26/2015 2:13 PM, Jonathan Davies wrote: xen-netfront limits transmitted skbs to be at most 44 segments in size. However, GSO permits up to 65536 bytes, which means a maximum of 45 segments of 1448 bytes each. This slight reduction in the size of packets means a slight loss in effici

Re: [Xen-devel] [PATCH V7 07/12] xen: Introduce monitor_op domctl

2015-03-26 Thread Tamas K Lengyel
On Thu, Mar 26, 2015 at 12:44 PM, Tim Deegan wrote: > At 11:13 + on 26 Mar (1427368409), Tim Deegan wrote: >> At 12:08 +0100 on 26 Mar (1427371713), Tamas K Lengyel wrote: >> > Thanks, I'll be sending v8 of the series today. Are there any plans to >> > merge the early parts of the series that

Re: [Xen-devel] [PATCH] xen-netfront: transmit fully GSO-sized packets

2015-03-26 Thread Jonathan Davies
On 26/03/15 12:05, Eric Dumazet wrote: On Thu, 2015-03-26 at 11:13 +, Jonathan Davies wrote: xen-netfront limits transmitted skbs to be at most 44 segments in size. However, GSO permits up to 65536 bytes, which means a maximum of 45 segments of 1448 bytes each. This slight reduction in the

Re: [Xen-devel] [PATCH 3/3] libxl: drop virDomainObj lock when destroying a domain

2015-03-26 Thread Ian Campbell
On Wed, 2015-03-25 at 14:08 -0600, Jim Fehlig wrote: > A destroy operation can take considerable time on large memory > domains due to scrubbing the domain' memory. The operation is > running in the context of a job, so unlocking the domain and > allowing query operations is safe. > > Signed-off-

Re: [Xen-devel] [PATCH v3 6/6] tools/libxl: Adjust datacopiers POLLHUP handling when the fd is also readable

2015-03-26 Thread Roger Pau Monné
El 16/03/15 a les 14.29, Ross Lagerwall ha escrit: > From: Andrew Cooper > > POLLHUP|POLLIN is a valid revent to receive when there is readable data in a > pipe, but the writable fd has been closed. This occurs in migration v2 when > the legacy conversion process (which transforms the data inlin

  1   2   3   >