Re: [Xen-devel] net: Detect drivers that reschedule NAPI and exhaust budget

2014-12-20 Thread Eric Dumazet
On Sat, 2014-12-20 at 17:55 +1100, Herbert Xu wrote: > -- >8 -- > The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less > interrupt masking in NAPI) required drivers to leave poll_list > empty if the entire budget is consumed. > > We have already had two broken drivers so let's add a che

Re: [Xen-devel] net: Detect drivers that reschedule NAPI and exhaust budget

2014-12-19 Thread Herbert Xu
On Fri, Dec 19, 2014 at 09:40:00PM -0500, David Miller wrote: > From: Eric Dumazet > Date: Fri, 19 Dec 2014 17:34:48 -0800 > > >> @@ -4620,7 +4620,11 @@ static void net_rx_action(struct softirq_action *h) > >> */ > >>napi_gro

Re: [Xen-devel] net: Detect drivers that reschedule NAPI and exhaust budget

2014-12-19 Thread David Miller
From: Eric Dumazet Date: Fri, 19 Dec 2014 17:34:48 -0800 >> @@ -4620,7 +4620,11 @@ static void net_rx_action(struct softirq_action *h) >> */ >> napi_gro_flush(n, HZ >= 1000); >> } >> -

Re: [Xen-devel] net: Detect drivers that reschedule NAPI and exhaust budget

2014-12-19 Thread Eric Dumazet
On Sat, 2014-12-20 at 11:36 +1100, Herbert Xu wrote: > On Sat, Dec 20, 2014 at 11:23:27AM +1100, Herbert Xu wrote: > > > > A similar bug exists in virtio_net. > > In order to detect other drivers doing this we should add something > like this. > > -- >8 -- > The commit d75b1ade567ffab085e8adbbdac