I'm not only suggesting changing the layout of the patches; I'm
Sorry for this misunderstanding.
suggesting modifying the functionality.
In patch 12 you add a new command-line parameter to xl; so that you have
to type something like this:
# xl pci-attach ubuntu01 01:00.1,msitranslate=1 relax
This is trying to covert LIBXL_XXX to XEN_XXX passed this policy as a
hypercall, so I still think this is better to live here. Instead, the
previous patch is just defining something.
The entire rest of this patch is about xl. It doesn't make any sense at
all for the previous patch to modify lib
On 07/01/2015 02:30 AM, Chen, Tiejun wrote:
> On 2015/7/1 0:11, George Dunlap wrote:
>> On Tue, Jun 23, 2015 at 10:57 AM, Tiejun Chen
>> wrote:
>>> This patch passes our rdm reservation policy inside libxl
>>> when we assign a device or attach a device.
>>
>> Actually, it looks like what you need
On 07/01/2015 02:23 AM, Chen, Tiejun wrote:
>>> @@ -988,6 +988,14 @@ static int do_pci_add(libxl__gc *gc, uint32_t
>>> domid, libxl_device_pci *pcidev, i
>>>
>>> out:
>>> if (!libxl_is_stubdom(ctx, domid, NULL)) {
>>> +if (pcidev->rdm_reserve == LIBXL_RDM_RESERVE_FLAG_RELAXED) {
>>>
On 2015/7/1 0:11, George Dunlap wrote:
On Tue, Jun 23, 2015 at 10:57 AM, Tiejun Chen wrote:
This patch passes our rdm reservation policy inside libxl
when we assign a device or attach a device.
Actually, it looks like what you need to do here, both for this patch
and the previous one is to ad
@@ -988,6 +988,14 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid,
libxl_device_pci *pcidev, i
out:
if (!libxl_is_stubdom(ctx, domid, NULL)) {
+if (pcidev->rdm_reserve == LIBXL_RDM_RESERVE_FLAG_RELAXED) {
+flag = XEN_DOMCTL_DEV_RDM_RELAXED;
+} else if (
On Tue, Jun 23, 2015 at 10:57 AM, Tiejun Chen wrote:
> This patch passes our rdm reservation policy inside libxl
> when we assign a device or attach a device.
Actually, it looks like what you need to do here, both for this patch
and the previous one is to add "rdm_reserve" to libxlu_pci.c, so tha
On Tue, Jun 23, 2015 at 10:57 AM, Tiejun Chen wrote:
> This patch passes our rdm reservation policy inside libxl
> when we assign a device or attach a device.
>
> CC: Ian Jackson
> CC: Stefano Stabellini
> CC: Ian Campbell
> CC: Wei Liu
> Signed-off-by: Tiejun Chen
> ---
> v4:
>
> * Fix one t
+B is about how to handle conflict between reserving reserved device
+memory and guest address space. "strict" means an unsolved conflict leads to
+immediate VM crash, while "relaxed" allows VM moving forward with a warning
+message thrown out. Here "strict" is default.
Surely it would be better
I will delete this last sentence and add this,
Please refer "reserve" option to the rdm option in xl.cfg.5.txt.
Say "xl.cfg(5)" which is a neutral reference to the manpage in any form.
I'm trying to follow an existing example here, so
This is same as "reserve" option to the rdm option, plea
On Fri, 2015-06-26 at 16:53 +0800, Chen, Tiejun wrote:
> >> B is the PCI Bus/Device/Function of the physical device to
> >> pass-through.
> >> +B is about how to handle conflict between reserving reserved
> >> device
> >
> > s/is about/specifies/
>
> Okay.
>
> and I think s/between/while/
> >
B is the PCI Bus/Device/Function of the physical device to pass-through.
+B is about how to handle conflict between reserving reserved device
s/is about/specifies/
Okay.
and I think s/between/while/
+memory and guest address space. "strict" means an unsolved conflict leads to
I think y
Tiejun Chen writes ("[v4][PATCH 12/19] tools/libxl: passes rdm reservation
policy"):
> This patch passes our rdm reservation policy inside libxl
> when we assign a device or attach a device.
...
> diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
> index 4eb929d..c5c4809 100644
> --- a/docs/man/x
On Tue, 2015-06-23 at 17:57 +0800, Tiejun Chen wrote:
> This patch passes our rdm reservation policy inside libxl
> when we assign a device or attach a device.
>
> CC: Ian Jackson
> CC: Stefano Stabellini
> CC: Ian Campbell
> CC: Wei Liu
> Signed-off-by: Tiejun Chen
> ---
> v4:
>
> * Fix one
On Tue, Jun 23, 2015 at 05:57:23PM +0800, Tiejun Chen wrote:
> This patch passes our rdm reservation policy inside libxl
> when we assign a device or attach a device.
>
> CC: Ian Jackson
> CC: Stefano Stabellini
> CC: Ian Campbell
> CC: Wei Liu
> Signed-off-by: Tiejun Chen
The code looks goo
15 matches
Mail list logo
