Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-19 Thread Julien Grall
Hi, On 19/10/17 17:37, Volodymyr Babchuk wrote: On Thu, Oct 19, 2017 at 05:12:17PM +0100, Julien Grall wrote: Hi Julien, +if ( rc < 0 ) +{ +gprintk(XENLOG_INFO, "OP-TEE: Can't map static shm for Dom0: %d", rc); gprintk already dump the domid. So no need to say Dom0. I just

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-19 Thread Volodymyr Babchuk
On Thu, Oct 19, 2017 at 05:12:17PM +0100, Julien Grall wrote: Hi Julien, > >>>+if ( rc < 0 ) > >>>+{ > >>>+gprintk(XENLOG_INFO, "OP-TEE: Can't map static shm for Dom0: > >>>%d", rc); > >> > >>gprintk already dump the domid. So no need to say Dom0. > >I

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-19 Thread Julien Grall
Hi Volodymyr, On 19/10/17 16:33, Volodymyr Babchuk wrote: On Thu, Oct 19, 2017 at 03:01:28PM +0100, Julien Grall wrote: My request is to move the set_user_reg(...) calls outside of call_forward. So this would make clear the mediator needs to examine the result values. Ah, I see. You suggest to

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-19 Thread Volodymyr Babchuk
On Thu, Oct 19, 2017 at 03:01:28PM +0100, Julien Grall wrote: > Hi Volodymyr, Hi Julien, [...] >>+} >>+ >>+static bool forward_call(struct cpu_user_regs *regs) >>+{ >>+register_t resp[4]; >>+ >>+call_smccc_smc(get_user_reg(regs, 0), >>+ ge

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-19 Thread Julien Grall
Hi Volodymyr, On 17/10/17 19:57, Volodymyr Babchuk wrote: On Tue, Oct 17, 2017 at 06:30:13PM +0100, Julien Grall wrote: On 11/10/17 20:01, Volodymyr Babchuk wrote: Add basic OP-TEE mediator as an example how TEE mediator framework works. Currently it support only calls from Dom0. Calls from

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-17 Thread Volodymyr Babchuk
On Tue, Oct 17, 2017 at 06:30:13PM +0100, Julien Grall wrote: > >>On 11/10/17 20:01, Volodymyr Babchuk wrote: > >>>Add basic OP-TEE mediator as an example how TEE mediator framework > >>>works. > >>> > >>>Currently it support only calls from Dom0. Calls from other guests > >>>will be declined. It

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-17 Thread Julien Grall
On 17/10/17 18:08, Volodymyr Babchuk wrote: On Mon, Oct 16, 2017 at 03:36:38PM +0100, Julien Grall wrote: Hi Volodymyr, Hi Julien, On 11/10/17 20:01, Volodymyr Babchuk wrote: Add basic OP-TEE mediator as an example how TEE mediator framework works. Currently it support only calls from Dom

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-17 Thread Volodymyr Babchuk
On Mon, Oct 16, 2017 at 03:36:38PM +0100, Julien Grall wrote: > Hi Volodymyr, Hi Julien, > On 11/10/17 20:01, Volodymyr Babchuk wrote: > >Add basic OP-TEE mediator as an example how TEE mediator framework > >works. > > > >Currently it support only calls from Dom0. Calls from other guests > >will b

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-16 Thread Julien Grall
Hi Volodymyr, On 11/10/17 20:01, Volodymyr Babchuk wrote: Add basic OP-TEE mediator as an example how TEE mediator framework works. Currently it support only calls from Dom0. Calls from other guests will be declined. It maps OP-TEE static shared memory region into Dom0 address space, so Dom0 is