Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-21 Thread Stefano Stabellini
On Fri, 21 Aug 2015, David Vrabel wrote: > On 21/08/15 17:05, Konrad Rzeszutek Wilk wrote: > > > > I have to concur with that. We can't mandate that ARM 64k page MUST use > > indirect descriptors. > > Then it has to be fixed in the block layer to allow < PAGE_SIZE segments > and to get the block

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-21 Thread Konrad Rzeszutek Wilk
On Thu, Aug 20, 2015 at 06:30:17PM -0700, Julien Grall wrote: > > > On 20/08/2015 10:42, David Vrabel wrote: > >>When using 64KB page, a Linux block request (struct *request) may > >>contain up to 64KB of data. This is because the block segment size > >>must at least be the size of a Linux page.

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-21 Thread David Vrabel
On 21/08/15 17:05, Konrad Rzeszutek Wilk wrote: > > I have to concur with that. We can't mandate that ARM 64k page MUST use > indirect descriptors. Then it has to be fixed in the block layer to allow < PAGE_SIZE segments and to get the block layer to split requests for blkfront. David _

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-21 Thread Konrad Rzeszutek Wilk
On Thu, Aug 20, 2015 at 06:23:16PM +0100, Stefano Stabellini wrote: > On Thu, 20 Aug 2015, David Vrabel wrote: > > On 20/08/15 09:31, Roger Pau Monné wrote: > > > El 20/08/15 a les 1.44, Stefano Stabellini ha escrit: > > >> On Wed, 19 Aug 2015, Roger Pau Monné wrote: > > >>> My opinion is that we h

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-20 Thread Julien Grall
On 20/08/2015 10:42, David Vrabel wrote: When using 64KB page, a Linux block request (struct *request) may contain up to 64KB of data. This is because the block segment size must at least be the size of a Linux page. You should ensure you configure the request queue with the limits that are c

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-20 Thread David Vrabel
On 18/08/15 07:29, Julien Grall wrote: > Hi, > > Firstly, this patch is not ready at all and mostly here for > collecting comment about the way to do it. It's not clean so no need > to complain about the coding style. > > The qdisk backend in QEMU is not supporting indirect grant, this is > means

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-20 Thread Stefano Stabellini
On Thu, 20 Aug 2015, David Vrabel wrote: > On 20/08/15 09:31, Roger Pau Monné wrote: > > El 20/08/15 a les 1.44, Stefano Stabellini ha escrit: > >> On Wed, 19 Aug 2015, Roger Pau Monné wrote: > >>> My opinion is that we have already merged quite a lot of this mess in > >>> order to support guests w

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-20 Thread Julien Grall
On 20/08/2015 02:43, David Vrabel wrote: On 20/08/15 09:31, Roger Pau Monné wrote: El 20/08/15 a les 1.44, Stefano Stabellini ha escrit: On Wed, 19 Aug 2015, Roger Pau Monné wrote: My opinion is that we have already merged quite a lot of this mess in order to support guests with different pa

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-20 Thread David Vrabel
On 20/08/15 09:31, Roger Pau Monné wrote: > El 20/08/15 a les 1.44, Stefano Stabellini ha escrit: >> On Wed, 19 Aug 2015, Roger Pau Monné wrote: >>> My opinion is that we have already merged quite a lot of this mess in >>> order to support guests with different page sizes. And in this case, the >>>

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-20 Thread Jan Beulich
>>> On 20.08.15 at 01:44, wrote: > On Wed, 19 Aug 2015, Roger Pau Monné wrote: >> My opinion is that we have already merged quite a lot of this mess in >> order to support guests with different page sizes. And in this case, the >> addition of code can be done to a userspace component, which is muc

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-20 Thread Roger Pau Monné
El 20/08/15 a les 1.44, Stefano Stabellini ha escrit: > On Wed, 19 Aug 2015, Roger Pau Monné wrote: >> My opinion is that we have already merged quite a lot of this mess in >> order to support guests with different page sizes. And in this case, the >> addition of code can be done to a userspace com

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-19 Thread Stefano Stabellini
On Wed, 19 Aug 2015, Roger Pau Monné wrote: > My opinion is that we have already merged quite a lot of this mess in > order to support guests with different page sizes. And in this case, the > addition of code can be done to a userspace component, which is much > less risky than adding it to blkfro

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-19 Thread Julien Grall
On 19/08/2015 08:17, Roger Pau Monné wrote: Hello, El 19/08/15 a les 16.54, Julien Grall ha escrit: On 19/08/2015 01:50, Roger Pau Monné wrote: Why can this be fixed in the Qemu side and the fix backported to 4.6.1? And what about any other backend not supporting indirect grant? The only

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-19 Thread Julien Grall
On 19/08/2015 01:58, Jan Beulich wrote: On 18.08.15 at 20:45, wrote: Hi Roger, On 18/08/2015 00:09, Roger Pau Monné wrote: Hello, El 18/08/15 a les 8.29, Julien Grall ha escrit: Hi, Firstly, this patch is not ready at all and mostly here for collecting comment about the way to do it. It's

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-19 Thread Roger Pau Monné
Hello, El 19/08/15 a les 16.54, Julien Grall ha escrit: > On 19/08/2015 01:50, Roger Pau Monné wrote: >> Why can this be fixed in the Qemu side and the fix backported to 4.6.1? > > And what about any other backend not supporting indirect grant? The only other backend I know of is tapdisk/blktap,

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-19 Thread Julien Grall
On 19/08/2015 01:50, Roger Pau Monné wrote: El 18/08/15 a les 20.45, Julien Grall ha escrit: Hi Roger, On 18/08/2015 00:09, Roger Pau Monné wrote: Hello, El 18/08/15 a les 8.29, Julien Grall ha escrit: Hi, Firstly, this patch is not ready at all and mostly here for collecting comment abou

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-19 Thread Jan Beulich
>>> On 18.08.15 at 20:45, wrote: > Hi Roger, > > On 18/08/2015 00:09, Roger Pau Monné wrote: >> Hello, >> >> El 18/08/15 a les 8.29, Julien Grall ha escrit: >>> Hi, >>> >>> Firstly, this patch is not ready at all and mostly here for collecting > comment about the way to do it. It's not clean so

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-19 Thread Roger Pau Monné
El 18/08/15 a les 20.45, Julien Grall ha escrit: > Hi Roger, > > On 18/08/2015 00:09, Roger Pau Monné wrote: >> Hello, >> >> El 18/08/15 a les 8.29, Julien Grall ha escrit: >>> Hi, >>> >>> Firstly, this patch is not ready at all and mostly here for >>> collecting comment about the way to do it. It

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-18 Thread Julien Grall
Hi Roger, On 18/08/2015 00:09, Roger Pau Monné wrote: Hello, El 18/08/15 a les 8.29, Julien Grall ha escrit: Hi, Firstly, this patch is not ready at all and mostly here for collecting comment about the way to do it. It's not clean so no need to complain about the coding style. The qdisk ba

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-18 Thread Jan Beulich
>>> On 18.08.15 at 09:09, wrote: > Hello, > > El 18/08/15 a les 8.29, Julien Grall ha escrit: >> Hi, >> >> Firstly, this patch is not ready at all and mostly here for collecting > comment about the way to do it. It's not clean so no need to complain about > the coding style. >> >> The qdisk b

Re: [Xen-devel] [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-18 Thread Roger Pau Monné
Hello, El 18/08/15 a les 8.29, Julien Grall ha escrit: > Hi, > > Firstly, this patch is not ready at all and mostly here for collecting > comment about the way to do it. It's not clean so no need to complain about > the coding style. > > The qdisk backend in QEMU is not supporting indirect gra