On 20/02/15 12:05, Manish Jaggi wrote:
> On 20/02/15 5:23 pm, Jan Beulich wrote:
>> All of these #ifdef-s call for better abstraction. And in no case is it
>> acceptable to replace blank lines with #ifdef-s like you do.
> Good observation. I will take care for the blank lines.
> A lot of code exist
On 20/02/15 5:23 pm, Jan Beulich wrote:
On 20.02.15 at 12:47, wrote:
@@ -287,6 +289,7 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg,
u8 bus, u8 devfn)
if ( pci_find_cap_offset(pseg->nr, bus, PCI_SLOT(devfn),
PCI_FUNC(devfn),
PCI_CAP_ID_MSIX) )
>>> On 20.02.15 at 12:47, wrote:
> @@ -287,6 +289,7 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg,
> u8 bus, u8 devfn)
> if ( pci_find_cap_offset(pseg->nr, bus, PCI_SLOT(devfn),
> PCI_FUNC(devfn),
>PCI_CAP_ID_MSIX) )
> {
> +#ifndef CONFIG_A