Re: [Xen-devel] [PATCH v9 10/15] tools/libxc: x86 HVM save code

2015-04-15 Thread Ian Campbell
On Fri, 2015-04-10 at 18:16 +0100, Andrew Cooper wrote: > Save the x86 HVM specific parts of the domain. This is considerably simpler > than an x86 PV domain. Only the HVM_CONTEXT and HVM_PARAMS records are > needed. > > There is no need for any page normalisation. > > Signed-off-by: Andrew Coo

Re: [Xen-devel] [PATCH v9 10/15] tools/libxc: x86 HVM save code

2015-04-15 Thread Ian Campbell
On Mon, 2015-04-13 at 14:21 +0100, Andrew Cooper wrote: > >> +static int write_hvm_params(struct xc_sr_context *ctx) > >> +{ > >> +static const unsigned int params[] = { [...] > > While reviewing my 'soft reset' series Ian C raised a question about the > > unsafeness of sequential get/set of HV

Re: [Xen-devel] [PATCH v9 10/15] tools/libxc: x86 HVM save code

2015-04-13 Thread Andrew Cooper
On 13/04/15 13:28, Vitaly Kuznetsov wrote: > Andrew Cooper writes: > >> +/* >> + * Query for a range of HVM parameters and write an HVM_PARAMS record into >> the >> + * stream. >> + */ >> +static int write_hvm_params(struct xc_sr_context *ctx) >> +{ >> +static const unsigned int params[] = {

Re: [Xen-devel] [PATCH v9 10/15] tools/libxc: x86 HVM save code

2015-04-13 Thread Vitaly Kuznetsov
Andrew Cooper writes: > Save the x86 HVM specific parts of the domain. This is considerably simpler > than an x86 PV domain. Only the HVM_CONTEXT and HVM_PARAMS records are > needed. > > There is no need for any page normalisation. > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian