Re: [Xen-devel] [PATCH v8 20/24] x86: L2 CAT: implement set value flow.

2017-03-01 Thread Dario Faggioli
On Wed, 2017-03-01 at 14:59 +0800, Yi Sun wrote: > On 17-02-28 15:25:39, Roger Pau Monn� wrote: > > The logic of this function is kind of weird IMHO, you seem to be > > able to return > > an error, and also a parameter that indicates success ("found"). > > Can't this be > > simplified to simply ret

Re: [Xen-devel] [PATCH v8 20/24] x86: L2 CAT: implement set value flow.

2017-02-28 Thread Yi Sun
On 17-02-28 15:25:39, Roger Pau Monn� wrote: > On Wed, Feb 15, 2017 at 04:49:35PM +0800, Yi Sun wrote: > > +static int l2_cat_compare_val(const uint64_t val[], > > + const struct feat_node *feat, > > + unsigned int cos, bool *found) > > +{ >

Re: [Xen-devel] [PATCH v8 20/24] x86: L2 CAT: implement set value flow.

2017-02-28 Thread Roger Pau Monné
On Wed, Feb 15, 2017 at 04:49:35PM +0800, Yi Sun wrote: > This patch implements L2 CAT set value related callback functions > and domctl interface. > > Signed-off-by: Yi Sun > --- > v8: > - modify 'l2_cat_write_msr' to 'void'. > --- > xen/arch/x86/domctl.c | 6 +++ > xen/arch/x86/