Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 18:29, wrote: > On Fri, Jun 24, 2016 at 5:24 AM, Jan Beulich wrote: > On 24.06.16 at 13:20, wrote: From: Tamas K Lengyel [mailto:ta...@tklengyel.com] + * rc < error, fall-through to exit_and_crash + */ +i

Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-24 Thread Razvan Cojocaru
On 06/24/16 21:48, Tamas K Lengyel wrote: >>> { >>> @@ -635,22 +661,22 @@ int main(int argc, char *argv[]) >>> rsp.u.mem_access = req.u.mem_access; >>> break; >>> case VM_EVENT_REASON_SOFTWARE_BREAKPOINT: >>> -printf("Break

Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-24 Thread Tamas K Lengyel
>> { >> @@ -635,22 +661,22 @@ int main(int argc, char *argv[]) >> rsp.u.mem_access = req.u.mem_access; >> break; >> case VM_EVENT_REASON_SOFTWARE_BREAKPOINT: >> -printf("Breakpoint: rip=%016"PRIx64", gfn=%"PRIx64" (vcpu >>

Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-24 Thread Tamas K Lengyel
On Fri, Jun 24, 2016 at 5:24 AM, Jan Beulich wrote: On 24.06.16 at 13:20, wrote: >>> From: Tamas K Lengyel [mailto:ta...@tklengyel.com] >>> Sent: Friday, June 24, 2016 1:07 AM >>> >>> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c >>> index 03fcba7..4b69ca6 100644 >>>

Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-24 Thread Jan Beulich
>>> On 24.06.16 at 13:20, wrote: >> From: Tamas K Lengyel [mailto:ta...@tklengyel.com] >> Sent: Friday, June 24, 2016 1:07 AM >> >> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c >> index 03fcba7..4b69ca6 100644 >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/

Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-24 Thread Tian, Kevin
> From: Tamas K Lengyel [mailto:ta...@tklengyel.com] > Sent: Friday, June 24, 2016 1:07 AM > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > index 03fcba7..4b69ca6 100644 > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -3373,10 +3373,39 @@ void v

Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-24 Thread Razvan Cojocaru
On 06/23/2016 08:07 PM, Tamas K Lengyel wrote: > Since in-guest debug exceptions are now unconditionally trapped to Xen, adding > a hook for vm_event subscribers to tap into this new always-on guest event. We > rename along the way hvm_event_breakpoint_type to hvm_event_type to better > match the v

Re: [Xen-devel] [PATCH v6 5/5] x86/vm_event: Add HVM debug exception vm_events

2016-06-24 Thread Jan Beulich
>>> On 23.06.16 at 19:07, wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -3373,10 +3373,39 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > HVMTRACE_1D(TRAP_DEBUG, exit_qualification); > write_debugreg(6, exit_qualification | DR_