On 06/07/17 12:18, Sergej Proskurin wrote:
Hi Julien,
On 07/04/2017 07:06 PM, Julien Grall wrote:
Hi Sergej,
+/*
+ * According to to ARM DDI 0487B.a J1-5927, we return an error
if the found
+ * PTE is invalid or holds a reserved entry (PTE<1:0> == x0)) or
if the PTE
+ * ma
Hi Julien,
On 07/04/2017 07:06 PM, Julien Grall wrote:
> Hi Sergej,
>
>
>> +/*
>> + * According to to ARM DDI 0487B.a J1-5927, we return an error
>> if the found
>> + * PTE is invalid or holds a reserved entry (PTE<1:0> == x0)) or
>> if the PTE
>> + * maps a memory block at level
On 05/07/17 15:37, Sergej Proskurin wrote:
Hi Julien,
Hi Sergej,
[...]
+/* Access the guest's memory to read only one PTE. */
+ret = vgic_access_guest_memory(d, paddr, &pte,
sizeof(lpae_t), false);
It really doesn't make sense to call a function vgic_* in guest page
tab
Hi Julien,
[...]
>> +/* Access the guest's memory to read only one PTE. */
>> +ret = vgic_access_guest_memory(d, paddr, &pte,
>> sizeof(lpae_t), false);
>
> It really doesn't make sense to call a function vgic_* in guest page
> table walk code. I wasn't expected that I needed to
Hi Sergej,
On 06/27/2017 12:52 PM, Sergej Proskurin wrote:
Also, create a macro CHECK_BASE_SIZE which simply reduces the code
size and simplifies readability.
No, it makes more confusing because you have the return within the
macro. It is not that bad too have an helper checking the
