Re: [Xen-devel] [PATCH v5 06/13] x86/domctl: Handle ACPI access from domctl

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 15:45, wrote: > On 12/20/2016 08:24 AM, Jan Beulich wrote: >> >>> -static int acpi_access_common(struct domain *d, >>> +static int acpi_access_common(struct domain *d, bool is_guest_access, >> Why? I thought the domctl is needed only for updating the CPU >> map? Or maybe it woul

Re: [Xen-devel] [PATCH v5 06/13] x86/domctl: Handle ACPI access from domctl

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 08:24 AM, Jan Beulich wrote: > >> -static int acpi_access_common(struct domain *d, >> +static int acpi_access_common(struct domain *d, bool is_guest_access, > Why? I thought the domctl is needed only for updating the CPU > map? Or maybe it would help if the patch had a non-empty > des

Re: [Xen-devel] [PATCH v5 06/13] x86/domctl: Handle ACPI access from domctl

2016-12-20 Thread Jan Beulich
>>> On 17.12.16 at 00:18, wrote: > @@ -32,14 +34,15 @@ static int acpi_cpumap_access_common(struct domain *d, > memcpy(val, (uint8_t *)d->avail_vcpus + first_byte, > min(bytes, ((d->max_vcpus + 7) / 8) - first_byte)); > } > -else > +else if ( !is_guest