Re: [Xen-devel] [PATCH v4 4/4] libxl: fix cd-eject

2016-02-17 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v4 4/4] libxl: fix cd-eject"): > Should we allow the PHY backend to handle empty files? > (pdev_path == NULL || pdev_path == ""). Yes. That is how it is supposed to work. I think this was broken in in 97ee1f5d "libxl: add support for image files for NetBSD" in

Re: [Xen-devel] [PATCH v4 4/4] libxl: fix cd-eject

2016-02-17 Thread Ian Campbell
On Wed, 2016-02-17 at 12:20 +0100, Roger Pau Monné wrote: > El 16/2/16 a les 18:58, Ian Jackson ha escrit: > > Roger Pau Monne writes ("[PATCH v4 4/4] libxl: fix cd-eject"): > > > Current libxl__device_disk_set_backend implementation tried to guess > > > the > > > backend of devices with format LIB

Re: [Xen-devel] [PATCH v4 4/4] libxl: fix cd-eject

2016-02-17 Thread Roger Pau Monné
El 16/2/16 a les 18:58, Ian Jackson ha escrit: > Roger Pau Monne writes ("[PATCH v4 4/4] libxl: fix cd-eject"): >> Current libxl__device_disk_set_backend implementation tried to guess the >> backend of devices with format LIBXL_DISK_FORMAT_EMPTY, which is of course >> doomed to fail since the disk

Re: [Xen-devel] [PATCH v4 4/4] libxl: fix cd-eject

2016-02-16 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v4 4/4] libxl: fix cd-eject"): > Current libxl__device_disk_set_backend implementation tried to guess the > backend of devices with format LIBXL_DISK_FORMAT_EMPTY, which is of course > doomed to fail since the disk is empty. Instead just return early from the > funct