Re: [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread Paulina Szubarczyk
On 08/04/2016 11:38 AM, Wei Liu wrote: The code looks ok. I have two minor suggestions below. I would suggest changing the subject line to: libs/gnttab: introduce grant copy interface On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: In a linux part an ioctl(gntdev, IOCTL

Re: [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread David Vrabel
On 03/08/16 15:36, David Vrabel wrote: > On 02/08/16 15:06, Paulina Szubarczyk wrote: >> >> +/** >> + * Copy memory from or to grant references. The information of each >> operations >> + * are contained in 'xengnttab_grant_copy_segment_t'. The @flag value >> indicate >> + * the direction of an o

Re: [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread Wei Liu
The code looks ok. I have two minor suggestions below. I would suggest changing the subject line to: libs/gnttab: introduce grant copy interface On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: > In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) > system call is

Re: [Xen-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-03 Thread David Vrabel
On 02/08/16 15:06, Paulina Szubarczyk wrote: > > +/** > + * Copy memory from or to grant references. The information of each > operations > + * are contained in 'xengnttab_grant_copy_segment_t'. The @flag value > indicate > + * the direction of an operation (GNTCOPY_source_gref\GNTCOPY_dest_gref