Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 07:16 -0700, Jan Beulich wrote: > > > > On 25.01.16 at 15:05, wrote: > > On Mon, 2016-01-25 at 06:54 -0700, Jan Beulich wrote: > > > > > > On 25.01.16 at 13:16, wrote: > > > > On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich wrote: > > > > > +#define MAP_MMIO_MAX_ITER 64 /* pr

Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Jan Beulich
>>> On 25.01.16 at 15:05, wrote: > On Mon, 2016-01-25 at 06:54 -0700, Jan Beulich wrote: >> > > > On 25.01.16 at 13:16, wrote: >> > On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich wrote: >> > > +#define MAP_MMIO_MAX_ITER 64 /* pretty arbitrary */ >> > > + >> > >> > I suppose no existing in-tree c

Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Ian Campbell
On Mon, 2016-01-25 at 06:54 -0700, Jan Beulich wrote: > > > > On 25.01.16 at 13:16, wrote: > > On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich wrote: > > > +#define MAP_MMIO_MAX_ITER 64 /* pretty arbitrary */ > > > + > > > > I suppose no existing in-tree code exceeds that (or there'd be more > > p

Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Jan Beulich
>>> On 25.01.16 at 13:16, wrote: > On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich wrote: >> +#define MAP_MMIO_MAX_ITER 64 /* pretty arbitrary */ >> + > > I suppose no existing in-tree code exceeds that (or there'd be more patch > here). There simply is no in-tree user other than the domctl on x8

Re: [Xen-devel] [PATCH v4] x86/p2m: use large pages for MMIO mappings

2016-01-25 Thread Ian Campbell
On Fri, 2016-01-22 at 08:42 -0700, Jan Beulich wrote: > When mapping large BARs (e.g. the frame buffer of a graphics card) the > overhead of establishing such mappings using only 4k pages has, > particularly after the XSA-125 fix, become unacceptable. Alter the > XEN_DOMCTL_memory_mapping semantics