Re: [Xen-devel] [PATCH v3 3/3] libxl: info: Display build_id of the hypervisor.

2016-01-13 Thread Konrad Rzeszutek Wilk
> > +info->build_id = strdup(""); > > I guess you're following existing strdup examples in this function. /me nods. > > Since now there is a GC in scope, you can use libxl__strdup. Presumably > you can also change other instances to use libxl__strdup. Would you be OK if I did it in anot

Re: [Xen-devel] [PATCH v3 3/3] libxl: info: Display build_id of the hypervisor.

2016-01-11 Thread Wei Liu
On Thu, Jan 07, 2016 at 09:25:20PM -0500, Konrad Rzeszutek Wilk wrote: > If the hypervisor is built with we will display it. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > v2: Include HAVE_*, use libxl_zalloc, s/rc/ret/ > --- > tools/libxl/libxl.c | 24 > tools