Re: [Xen-devel] [PATCH v3 2/3] Introduce migration precopy policy

2017-09-26 Thread Jennifer Herbert
On 26/09/17 12:02, Andrew Cooper wrote: On 25/09/17 19:55, Jennifer Herbert wrote: @@ -46,7 +60,22 @@ struct save_callbacks { */ int (*suspend)(void* data); -/* Called after the guest's dirty pages have been +/* + * Called before and after every batch of page data s

Re: [Xen-devel] [PATCH v3 2/3] Introduce migration precopy policy

2017-09-26 Thread Jennifer Herbert
On 26/09/17 11:58, Andrew Cooper wrote: On 25/09/17 19:55, Jennifer Herbert wrote: +/* + * A precopy_policy callback may not be running in the same address + * space as libxc an so precopy_stats is passed by value. + */ Please take a step back and thing about what is written here... As I've sa

Re: [Xen-devel] [PATCH v3 2/3] Introduce migration precopy policy

2017-09-26 Thread Andrew Cooper
On 25/09/17 19:55, Jennifer Herbert wrote: > @@ -46,7 +60,22 @@ struct save_callbacks { > */ > int (*suspend)(void* data); > > -/* Called after the guest's dirty pages have been > +/* > + * Called before and after every batch of page data sent during > + * the precopy p

Re: [Xen-devel] [PATCH v3 2/3] Introduce migration precopy policy

2017-09-26 Thread Andrew Cooper
On 25/09/17 19:55, Jennifer Herbert wrote: > +/* > + * A precopy_policy callback may not be running in the same address > + * space as libxc an so precopy_stats is passed by value. > + */ Please take a step back and thing about what is written here... As I've said repeatedly, the structure vs poi

Re: [Xen-devel] [PATCH v3 2/3] Introduce migration precopy policy

2017-09-26 Thread Wei Liu
On Mon, Sep 25, 2017 at 07:55:34PM +0100, Jennifer Herbert wrote: > This Patch allows a migration precopy policy to be specified. > > The precopy phase of the xc_domain_save() live migration algorithm has > historically been implemented to run until either a) (almost) no pages > are dirty or b) so