Re: [Xen-devel] [PATCH v3 19/28] tools/libxl: Convert a legacy stream if needed

2015-07-13 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v3 19/28] tools/libxl: Convert a legacy stream if needed"): > On 13/07/15 15:51, Ian Jackson wrote: > > This would be more obviously correct (or at least more obviously never > > leak a carefd) if you set v2_carefd to NULL here, and asserted its > > NULLness at th

Re: [Xen-devel] [PATCH v3 19/28] tools/libxl: Convert a legacy stream if needed

2015-07-13 Thread Andrew Cooper
On 13/07/15 15:51, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH v3 19/28] tools/libxl: Convert a legacy stream > if needed"): >> For backwards compatibility, a legacy stream needs converting before >> it can be read by the v2 stream logic. >> >> This causes the v2 stream logic to need to jug

Re: [Xen-devel] [PATCH v3 19/28] tools/libxl: Convert a legacy stream if needed

2015-07-13 Thread Ian Jackson
Andrew Cooper writes ("[PATCH v3 19/28] tools/libxl: Convert a legacy stream if needed"): > For backwards compatibility, a legacy stream needs converting before > it can be read by the v2 stream logic. > > This causes the v2 stream logic to need to juggle two parallel tasks. > check_all_finished(