Re: [Xen-devel] [PATCH v3 16/28] x86/cpu: Rework AMD masking MSR setup

2016-03-21 Thread Andrew Cooper
On 21/03/16 16:51, Jan Beulich wrote: On 15.03.16 at 16:35, wrote: >> +/* Fast-forward bits - Must be set. */ >> +if (ecx & cpufeat_mask(X86_FEATURE_XSAVE)) >> +ecx |= cpufeat_mask(X86_FEATURE_OSXSAVE); > Wouldn't you think it would be better to als

Re: [Xen-devel] [PATCH v3 16/28] x86/cpu: Rework AMD masking MSR setup

2016-03-21 Thread Jan Beulich
>>> On 15.03.16 at 16:35, wrote: > + /* Fast-forward bits - Must be set. */ > + if (ecx & cpufeat_mask(X86_FEATURE_XSAVE)) > + ecx |= cpufeat_mask(X86_FEATURE_OSXSAVE); Wouldn't you think it would be better to also handle PKU/OSPKE here, just in case AM