Re: [Xen-devel] [PATCH v3 1/4] sched: credit2: respect per-vcpu hard affinity

2015-05-06 Thread Dario Faggioli
On Wed, 2015-03-25 at 23:48 -1000, Justin T. Weaver wrote: > by making sure that vcpus only run on the pcpu(s) they are allowed to > run on based on their hard affinity cpu masks. > And here I am again... reviewing this is really taking _ages_... Sorry! :-( > Signed-off-by: Justin T. Weaver > --

Re: [Xen-devel] [PATCH v3 1/4] sched: credit2: respect per-vcpu hard affinity

2015-04-23 Thread Dario Faggioli
On Tue, 2015-03-31 at 15:37 +0100, George Dunlap wrote: > On 03/26/2015 09:48 AM, Justin T. Weaver wrote: > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -194,6 +195,12 @@ int opt_overload_balance_tolerance=-3; > > integer_param("credit2_balance_over", opt_overlo

Re: [Xen-devel] [PATCH v3 1/4] sched: credit2: respect per-vcpu hard affinity

2015-03-31 Thread George Dunlap
On 03/31/2015 06:14 PM, Dario Faggioli wrote: >>> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c >>> index 7581731..af716e4 100644 >>> --- a/xen/common/sched_credit2.c >>> +++ b/xen/common/sched_credit2.c > >>> @@ -2024,6 +2096,13 @@ csched2_alloc_pdata(const struct scheduler

Re: [Xen-devel] [PATCH v3 1/4] sched: credit2: respect per-vcpu hard affinity

2015-03-31 Thread Dario Faggioli
On Tue, 2015-03-31 at 15:37 +0100, George Dunlap wrote: > On 03/26/2015 09:48 AM, Justin T. Weaver wrote: > > by making sure that vcpus only run on the pcpu(s) they are allowed to > > run on based on their hard affinity cpu masks. > > > > Signed-off-by: Justin T. Weaver > > Hey Justin! Getting

Re: [Xen-devel] [PATCH v3 1/4] sched: credit2: respect per-vcpu hard affinity

2015-03-31 Thread George Dunlap
On 03/26/2015 09:48 AM, Justin T. Weaver wrote: > by making sure that vcpus only run on the pcpu(s) they are allowed to > run on based on their hard affinity cpu masks. > > Signed-off-by: Justin T. Weaver Hey Justin! Getting close. A couple of comments: > diff --git a/xen/common/sched_credit2