Re: [Xen-devel] [PATCH v3 08/16] x86: add multiboot2 protocol support

2016-05-27 Thread Jan Beulich
>>> On 27.05.16 at 10:13, wrote: > On 27/05/16 09:08, Jan Beulich wrote: > On 26.05.16 at 12:28, wrote: >> @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER >>> / >> .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS) >> multiboot1_head

Re: [Xen-devel] [PATCH v3 08/16] x86: add multiboot2 protocol support

2016-05-27 Thread Andrew Cooper
On 27/05/16 09:08, Jan Beulich wrote: On 26.05.16 at 12:28, wrote: > @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER >> / > .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS) > multiboot1_header_end: > > +/*** MULTIBOOT2 HEAD

Re: [Xen-devel] [PATCH v3 08/16] x86: add multiboot2 protocol support

2016-05-27 Thread Jan Beulich
>>> On 25.05.16 at 18:34, wrote: > On Tue, May 24, 2016 at 09:46:13AM -0600, Jan Beulich wrote: >> >>> On 15.04.16 at 14:33, wrote: >> > @@ -19,6 +20,28 @@ >> > #define BOOT_PSEUDORM_CS 0x0020 >> > #define BOOT_PSEUDORM_DS 0x0028 >> > >> > +#define MB2_HT(name) (MULTIBOOT2_HEADER_TAG_##nam

Re: [Xen-devel] [PATCH v3 08/16] x86: add multiboot2 protocol support

2016-05-27 Thread Jan Beulich
>>> On 26.05.16 at 12:28, wrote: @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER > / .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS) multiboot1_header_end: +/*** MULTIBOOT2 HEADER / +/* Some ideas are taken from

Re: [Xen-devel] [PATCH v3 08/16] x86: add multiboot2 protocol support

2016-05-26 Thread Andrew Cooper
>>> @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER >>> / >>> .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS) >>> multiboot1_header_end: >>> >>> +/*** MULTIBOOT2 HEADER / >>> +/* Some ideas are taken from grub-2.00/grub-core/tests/boot/kernel-

Re: [Xen-devel] [PATCH v3 08/16] x86: add multiboot2 protocol support

2016-05-25 Thread Daniel Kiper
On Tue, May 24, 2016 at 09:46:13AM -0600, Jan Beulich wrote: > >>> On 15.04.16 at 14:33, wrote: > > @@ -19,6 +20,28 @@ > > #define BOOT_PSEUDORM_CS 0x0020 > > #define BOOT_PSEUDORM_DS 0x0028 > > > > +#define MB2_HT(name) (MULTIBOOT2_HEADER_TAG_##name) > > +#define MB2_TT(name) (MULTIBO

Re: [Xen-devel] [PATCH v3 08/16] x86: add multiboot2 protocol support

2016-05-24 Thread Jan Beulich
>>> On 15.04.16 at 14:33, wrote: > @@ -19,6 +20,28 @@ > #define BOOT_PSEUDORM_CS 0x0020 > #define BOOT_PSEUDORM_DS 0x0028 > > +#define MB2_HT(name) (MULTIBOOT2_HEADER_TAG_##name) > +#define MB2_TT(name) (MULTIBOOT2_TAG_TYPE_##name) > + > +.macro mb2ht_args arg, args:vararg >