Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-28 Thread Dario Faggioli
On Wed, 2016-12-28 at 09:02 +, George Dunlap wrote: > On 17/12/16 01:46, Dario Faggioli wrote: > > On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote: > > > Signed-off-by: Praveen Kumar > > > Acked-by: Dario Faggioli > > > > > Better than before. But still, if I: > >  - save this mail as

Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-28 Thread George Dunlap
On 17/12/16 01:46, Dario Faggioli wrote: > On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote: >> The patch gets rid of a redundant check in csched_vcpu_acct. In fact, >> the function is only called from csched_tick, which already checks >> that current is not the idle vcpu. The patch also adds

Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-20 Thread Dario Faggioli
On Tue, 2016-12-20 at 14:34 +0530, Praveen Kumar wrote: > Hi Dario, > > I tried with 'git am' to apply the patch after downloading the mbox > file, that worked fine. Do let me know if that is ok. > Well, if you tried and it works, I'm sure it is. I don't really use `git am` as part of my workload

Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-20 Thread Praveen Kumar
Hi Dario, I tried with 'git am' to apply the patch after downloading the mbox file, that worked fine. Do let me know if that is ok. Regards, ~Praveen. On Sat, Dec 17, 2016 at 1:44 PM, Praveen Kumar wrote: > Hi, > > On Sat, Dec 17, 2016 at 7:16 AM, Dario Faggioli > wrote: > >> On Sat, 2016-12

Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-17 Thread Praveen Kumar
Hi, On Sat, Dec 17, 2016 at 7:16 AM, Dario Faggioli wrote: > On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote: > > The patch gets rid of a redundant check in csched_vcpu_acct. In fact, > > the function is only called from csched_tick, which already checks > > that current is not the idle v

Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-16 Thread Dario Faggioli
On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote: > The patch gets rid of a redundant check in csched_vcpu_acct. In fact, > the function is only called from csched_tick, which already checks > that current is not the idle vcpu. The patch also adds an ASSERT to > the same effect, in order to m