Re: [Xen-devel] [PATCH v3] xen/keyhandler: Rework keyhandler infrastructure

2015-09-24 Thread Jan Beulich
>>> On 24.09.15 at 14:09, wrote: > This appears to work for me. Looks okay with ... > --- a/xen/common/keyhandler.c > +++ b/xen/common/keyhandler.c > @@ -43,10 +43,10 @@ > } key_table[128] __read_mostly = > { > #define KEYHANDLER(k, f, desc, diag)\ > -[k] = { .fn = (f), desc,

Re: [Xen-devel] [PATCH v3] xen/keyhandler: Rework keyhandler infrastructure

2015-09-24 Thread Andrew Cooper
On 24/09/15 12:58, Jan Beulich wrote: On 24.09.15 at 13:47, wrote: >> On 24/09/15 12:46, Jan Beulich wrote: >> On 24.09.15 at 13:05, wrote: +static struct keyhandler { +union { +keyhandler_fn_t *fn; +irq_keyhandler_fn_t *irq_fn; +}; +

Re: [Xen-devel] [PATCH v3] xen/keyhandler: Rework keyhandler infrastructure

2015-09-24 Thread Jan Beulich
>>> On 24.09.15 at 13:47, wrote: > On 24/09/15 12:46, Jan Beulich wrote: > On 24.09.15 at 13:05, wrote: >>> +static struct keyhandler { >>> +union { >>> +keyhandler_fn_t *fn; >>> +irq_keyhandler_fn_t *irq_fn; >>> +}; >>> + >>> +const char *desc;/* Description f

Re: [Xen-devel] [PATCH v3] xen/keyhandler: Rework keyhandler infrastructure

2015-09-24 Thread Andrew Cooper
On 24/09/15 12:46, Jan Beulich wrote: On 24.09.15 at 13:05, wrote: >> +static struct keyhandler { >> +union { >> +keyhandler_fn_t *fn; >> +irq_keyhandler_fn_t *irq_fn; >> +}; >> + >> +const char *desc;/* Description for help message. */ >> +

Re: [Xen-devel] [PATCH v3] xen/keyhandler: Rework keyhandler infrastructure

2015-09-24 Thread Jan Beulich
>>> On 24.09.15 at 13:05, wrote: > +static struct keyhandler { > +union { > +keyhandler_fn_t *fn; > +irq_keyhandler_fn_t *irq_fn; > +}; > + > +const char *desc;/* Description for help message. */ > +bool_t irq_callback, /* Call in irq context? if