Re: [Xen-devel] [PATCH v3] libxl/libxl_qmp.c: fix error handling in qmp_open

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 10:08 +, Wei Liu wrote: > On Thu, Mar 19, 2015 at 12:55:12PM +, PRAMOD DEVENDRA wrote: > > From: Pramod Devendra > > > > 1. Make sure sun_path does not overflow > > 2. Close qmp_fd on error > > 3. Use goto out for error handling > > > > Signed-off-by: Pramod Devendr

Re: [Xen-devel] [PATCH v3] libxl/libxl_qmp.c: fix error handling in qmp_open

2015-03-20 Thread Wei Liu
On Thu, Mar 19, 2015 at 12:55:12PM +, PRAMOD DEVENDRA wrote: > From: Pramod Devendra > > 1. Make sure sun_path does not overflow > 2. Close qmp_fd on error > 3. Use goto out for error handling > > Signed-off-by: Pramod Devendra > CC: Ian Jackson > CC: Stefano Stabellini > CC: Ian Campbell