Re: [Xen-devel] [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT

2016-04-07 Thread Jan Beulich
>>> On 07.04.16 at 23:17, wrote: >> > The main >>> difference I see between both would be the base system time: >>> read_platform_stime >>> uses stime_platform_stamp as base, and computes a difference from the >>> read_counter (i.e. rdtsc() ) with previously saved platform-wide stamp >>> (platfor

Re: [Xen-devel] [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT

2016-04-07 Thread Joao Martins
>> The main >> difference I see between both would be the base system time: >> read_platform_stime >> uses stime_platform_stamp as base, and computes a difference from the >> read_counter (i.e. rdtsc() ) with previously saved platform-wide stamp >> (platform_timer_stamp). get_s_time uses the stime

Re: [Xen-devel] [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT

2016-04-07 Thread Jan Beulich
>>> On 05.04.16 at 23:34, wrote: > On 04/05/2016 01:22 PM, Jan Beulich wrote: > On 29.03.16 at 15:44, wrote: >> But >> I'm opposed to this: For one, the variable being static here >> means there is nothing that actually suppresses CPU hotplug >> to happen. >> And then I think this can, for al

Re: [Xen-devel] [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT

2016-04-05 Thread Joao Martins
On 04/05/2016 01:22 PM, Jan Beulich wrote: On 29.03.16 at 15:44, wrote: >> --- a/xen/arch/x86/time.c >> +++ b/xen/arch/x86/time.c >> @@ -43,6 +43,10 @@ >> static char __initdata opt_clocksource[10]; >> string_param("clocksource", opt_clocksource); >> >> +/* opt_nocpuhotplug: Set if CPU ho

Re: [Xen-devel] [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT

2016-04-05 Thread Jan Beulich
>>> On 29.03.16 at 15:44, wrote: > --- a/xen/arch/x86/time.c > +++ b/xen/arch/x86/time.c > @@ -43,6 +43,10 @@ > static char __initdata opt_clocksource[10]; > string_param("clocksource", opt_clocksource); > > +/* opt_nocpuhotplug: Set if CPU hotplug isn't meant to be used */ > +static bool_t __