Re: [Xen-devel] [PATCH v2 18/30] x86/cpu: Rework AMD masking MSR setup

2016-02-17 Thread Andrew Cooper
On 17/02/16 07:40, Jan Beulich wrote: > >> +if ((rdmsr_amd_safe(msr, &lo, &hi) == 0) && >> +(wrmsr_amd_safe(msr, lo, hi) == 0)) >> +levelling_caps |= caps; >> + >> +*msr_val = ((uint64_t)hi << 32) | lo; >> +} > Why can't this function, currently returning void, simply re

Re: [Xen-devel] [PATCH v2 18/30] x86/cpu: Rework AMD masking MSR setup

2016-02-16 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > @@ -126,126 +133,189 @@ static const struct cpuidmask *__init noinline > get_cpuidmask(const char *opt) > } > > /* > + * Sets caps in expected_levelling_cap, probes for the specified mask MSR, > and > + * set caps in levelling_caps if it is found. Processo