Re: [Xen-devel] [PATCH v2 04/16] xen/x86: p2m-pod: Fix coding style

2017-10-04 Thread Julien Grall
On 04/10/17 06:38, Jan Beulich wrote: Julien Grall 09/28/17 9:30 PM >>> On 09/22/2017 10:15 AM, Jan Beulich wrote: On 21.09.17 at 14:40, wrote: Also take the opportunity to: - move from 1 << * to 1UL << *. - use unsigned when possible - move from unsigned int -> unsigned

Re: [Xen-devel] [PATCH v2 04/16] xen/x86: p2m-pod: Fix coding style

2017-10-03 Thread Jan Beulich
>>> Julien Grall 09/28/17 9:30 PM >>> >On 09/22/2017 10:15 AM, Jan Beulich wrote: > On 21.09.17 at 14:40, wrote: >>> Also take the opportunity to: >>> - move from 1 << * to 1UL << *. >>> - use unsigned when possible >>> - move from unsigned int -> unsigned long for some inducti

Re: [Xen-devel] [PATCH v2 04/16] xen/x86: p2m-pod: Fix coding style

2017-09-28 Thread Julien Grall
Hi Jan, On 09/22/2017 10:15 AM, Jan Beulich wrote: On 21.09.17 at 14:40, wrote: Also take the opportunity to: - move from 1 << * to 1UL << *. - use unsigned when possible - move from unsigned int -> unsigned long for some induction variables I don't understand this last p

Re: [Xen-devel] [PATCH v2 04/16] xen/x86: p2m-pod: Fix coding style

2017-09-22 Thread Jan Beulich
>>> On 21.09.17 at 14:40, wrote: > Also take the opportunity to: > - move from 1 << * to 1UL << *. > - use unsigned when possible > - move from unsigned int -> unsigned long for some induction > variables I don't understand this last point, btw - the largest order page the code ne

Re: [Xen-devel] [PATCH v2 04/16] xen/x86: p2m-pod: Fix coding style

2017-09-21 Thread George Dunlap
On 09/21/2017 01:40 PM, Julien Grall wrote: > Also take the opportunity to: > - move from 1 << * to 1UL << *. > - use unsigned when possible > - move from unsigned int -> unsigned long for some induction > variables > > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper Revie

Re: [Xen-devel] [PATCH v2 04/16] xen/x86: p2m-pod: Fix coding style

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:23PM +0100, Julien Grall wrote: > Also take the opportunity to: > - move from 1 << * to 1UL << *. > - use unsigned when possible > - move from unsigned int -> unsigned long for some induction > variables > > Signed-off-by: Julien Grall > Acked-by: And