Re: [Xen-devel] [PATCH v2] xl: initialise rc before using it in vcpuset

2015-11-04 Thread Dario Faggioli
On Wed, 2015-11-04 at 11:47 +, Ian Campbell wrote: > On Wed, 2015-11-04 at 12:38 +0100, Dario Faggioli wrote: > > On Wed, 2015-11-04 at 11:32 +, Wei Liu wrote: > > > > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > > > index 2756d2f..9b6b42c 100644 > > > --- a/tools/l

Re: [Xen-devel] [PATCH v2] xl: initialise rc before using it in vcpuset

2015-11-04 Thread Ian Campbell
On Wed, 2015-11-04 at 12:38 +0100, Dario Faggioli wrote: > On Wed, 2015-11-04 at 11:32 +, Wei Liu wrote: > > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > > index 2756d2f..9b6b42c 100644 > > --- a/tools/libxl/xl_cmdimpl.c > > +++ b/tools/libxl/xl_cmdimpl.c > > @@ -5473,7

Re: [Xen-devel] [PATCH v2] xl: initialise rc before using it in vcpuset

2015-11-04 Thread Ian Campbell
On Wed, 2015-11-04 at 11:32 +, Wei Liu wrote: > In 5b725e56 (xl: improve return and exit codes of vcpu related > functions), the return value of libxl_cpu_bitmap_alloc was not stored in > rc anymore. Yet the subsequent fprintf still used that. > > Reinstate the original implementation, that is

Re: [Xen-devel] [PATCH v2] xl: initialise rc before using it in vcpuset

2015-11-04 Thread Dario Faggioli
On Wed, 2015-11-04 at 11:32 +, Wei Liu wrote: > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 2756d2f..9b6b42c 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -5473,7 +5473,8 @@ static int vcpuset(uint32_t domid, const char* > nr_vcpus,