Re: [Xen-devel] [PATCH v2] xen/blkfront: remove redundant flush_op

2014-12-10 Thread Konrad Rzeszutek Wilk
On Tue, Dec 09, 2014 at 03:56:46PM -0500, Boris Ostrovsky wrote: > On 12/09/2014 09:25 AM, Vitaly Kuznetsov wrote: > >flush_op is unambiguously defined by feature_flush: > > REQ_FUA | REQ_FLUSH -> BLKIF_OP_WRITE_BARRIER > > REQ_FLUSH -> BLKIF_OP_FLUSH_DISKCACHE > > 0 -> 0 > >and thus ca

Re: [Xen-devel] [PATCH v2] xen/blkfront: remove redundant flush_op

2014-12-09 Thread Boris Ostrovsky
On 12/09/2014 09:25 AM, Vitaly Kuznetsov wrote: flush_op is unambiguously defined by feature_flush: REQ_FUA | REQ_FLUSH -> BLKIF_OP_WRITE_BARRIER REQ_FLUSH -> BLKIF_OP_FLUSH_DISKCACHE 0 -> 0 and thus can be removed. This is just a cleanup. The patch was suggested by Boris Ostrovsk