Re: [Xen-devel] [PATCH v2] fix potential int overflow in efi/boot

2016-12-12 Thread Jan Beulich
>>> On 09.12.16 at 20:52, wrote: > HorizontalResolution and VerticalResolution are 32bit, while size is > 64bit. As it stands multiplications are evaluated with 32bit arithmetic, > which could overflow. Cast HorizontalResolution to 64bit to avoid that. > > Coverity-ID: 1381858 > > Signed-off-by:

Re: [Xen-devel] [PATCH v2] fix potential int overflow in efi/boot

2016-12-09 Thread Stefano Stabellini
Forgot to CC Jan again. On Fri, 9 Dec 2016, Stefano Stabellini wrote: > HorizontalResolution and VerticalResolution are 32bit, while size is > 64bit. As it stands multiplications are evaluated with 32bit arithmetic, > which could overflow. Cast HorizontalResolution to 64bit to avoid that. > > Cov