Re: [Xen-devel] [PATCH for-4.7] sched/rt: Fix memory leak in rt_init()

2016-05-10 Thread Andrew Cooper
On 10/05/16 15:18, Wei Liu wrote: > On Tue, May 10, 2016 at 02:38:48PM +0100, Andrew Cooper wrote: >> c/s 2656bc7b0 "xen: adopt .deinit_pdata and improve timer handling" >> introduced a error path into rt_init() which leaked prv if the >> allocation of prv->repl_timer failed. >> >> Introduce an err

Re: [Xen-devel] [PATCH for-4.7] sched/rt: Fix memory leak in rt_init()

2016-05-10 Thread Wei Liu
On Tue, May 10, 2016 at 02:38:48PM +0100, Andrew Cooper wrote: > c/s 2656bc7b0 "xen: adopt .deinit_pdata and improve timer handling" > introduced a error path into rt_init() which leaked prv if the > allocation of prv->repl_timer failed. > > Introduce an error cleanup path. > > Spotted by Coverit

Re: [Xen-devel] [PATCH for-4.7] sched/rt: Fix memory leak in rt_init()

2016-05-10 Thread Andrew Cooper
On 10/05/16 14:52, Meng Xu wrote: > On Tue, May 10, 2016 at 9:38 AM, Andrew Cooper > wrote: >> c/s 2656bc7b0 "xen: adopt .deinit_pdata and improve timer handling" >> introduced a error path into rt_init() which leaked prv if the >> allocation of prv->repl_timer failed. >> >> Introduce an error cle

Re: [Xen-devel] [PATCH for-4.7] sched/rt: Fix memory leak in rt_init()

2016-05-10 Thread Meng Xu
On Tue, May 10, 2016 at 9:38 AM, Andrew Cooper wrote: > c/s 2656bc7b0 "xen: adopt .deinit_pdata and improve timer handling" > introduced a error path into rt_init() which leaked prv if the > allocation of prv->repl_timer failed. > > Introduce an error cleanup path. > > Spotted by Coverity. I'm cu