Re: [Xen-devel] [PATCH XTF 3/3] xtf-runner: regularise runner exit code

2016-07-26 Thread Wei Liu
on Mon, Jul 25, 2016 at 06:05:21PM +0100, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH XTF 3/3] xtf-runner: regularise runner exit > code"): > > On 25/07/16 12:25, Ian Jackson wrote: > > > In particular, Error might mask a failure. > > > > Indeed it could. Either should cause a prompt

Re: [Xen-devel] [PATCH XTF 3/3] xtf-runner: regularise runner exit code

2016-07-25 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH XTF 3/3] xtf-runner: regularise runner exit code"): > On 25/07/16 12:25, Ian Jackson wrote: > > In particular, Error might mask a failure. > > Indeed it could. Either should cause a prompt investigation and effort > to resolve the issues, but one must be more se

Re: [Xen-devel] [PATCH XTF 3/3] xtf-runner: regularise runner exit code

2016-07-25 Thread Andrew Cooper
On 25/07/16 12:25, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH XTF 3/3] xtf-runner: regularise runner exit > code"): >> On 22/07/16 10:29, Wei Liu wrote: >>> This would cause a FAILURE to overwrite previous ERROR result. Is that >>> what you want? >> When running more than one test, the

Re: [Xen-devel] [PATCH XTF 3/3] xtf-runner: regularise runner exit code

2016-07-25 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH XTF 3/3] xtf-runner: regularise runner exit code"): > On 22/07/16 10:29, Wei Liu wrote: > > This would cause a FAILURE to overwrite previous ERROR result. Is that > > what you want? > > When running more than one test, the overall result should be the most > sev

Re: [Xen-devel] [PATCH XTF 3/3] xtf-runner: regularise runner exit code

2016-07-22 Thread Andrew Cooper
On 22/07/16 10:29, Wei Liu wrote: On Thu, Jul 21, 2016 at 08:04:59PM +0100, Andrew Cooper wrote: On 21/07/2016 16:44, Wei Liu wrote: Report the first "ERROR" and "FAILURE" if found, otherwise report "SKIP" if found. Eventually if everything is ok the exit code will be 0. See runner code for n

Re: [Xen-devel] [PATCH XTF 3/3] xtf-runner: regularise runner exit code

2016-07-22 Thread Wei Liu
On Thu, Jul 21, 2016 at 08:04:59PM +0100, Andrew Cooper wrote: > On 21/07/2016 16:44, Wei Liu wrote: > > Report the first "ERROR" and "FAILURE" if found, otherwise report "SKIP" > > if found. Eventually if everything is ok the exit code will be 0. > > > > See runner code for numeric exit code space

Re: [Xen-devel] [PATCH XTF 3/3] xtf-runner: regularise runner exit code

2016-07-21 Thread Andrew Cooper
On 21/07/2016 16:44, Wei Liu wrote: > Report the first "ERROR" and "FAILURE" if found, otherwise report "SKIP" > if found. Eventually if everything is ok the exit code will be 0. > > See runner code for numeric exit code space. > > Signed-off-by: Wei Liu > --- > xtf-runner | 12 +--- > 1