Re: [Xen-devel] [PATCH V12 3/5] libxl: add pvusb API

2016-01-14 Thread George Dunlap
On Thu, Jan 14, 2016 at 5:41 AM, Chun Yan Liu wrote: >> > +static int sysfs_write_intf(libxl__gc *gc, const char *intf, const char >> *path) >> > +{ >> >> What is `intf' here ? Maybe `interface' ? But there is nothing usb >> specific about this function. Looking for similar code elsewhere this

Re: [Xen-devel] [PATCH V12 3/5] libxl: add pvusb API

2016-01-14 Thread Ian Campbell
On Tue, 2016-01-12 at 18:31 +, Ian Jackson wrote: >  > > +static char *usb_interface_xenstore_encode(libxl__gc *gc, const char > > *busid) > > +{ > > +char *str = libxl__strdup(gc, busid); > > +int i, len = strlen(str); > > + > > +for (i = 0; i < len; i++) { > > +if (str[i]

Re: [Xen-devel] [PATCH V12 3/5] libxl: add pvusb API

2016-01-13 Thread Chun Yan Liu
>>> On 1/13/2016 at 02:31 AM, in message <22165.18064.452737.543...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V12 3/5] libxl: add pvusb API"): > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach u

Re: [Xen-devel] [PATCH V12 3/5] libxl: add pvusb API

2016-01-12 Thread Ian Jackson
Chunyan Liu writes ("[PATCH V12 3/5] libxl: add pvusb API"): > Add pvusb APIs, including: > - attach/detach (create/destroy) virtual usb controller. > - attach/detach usb device > - list usb controller and usb devices > - some other helper functions > > Signed-off-by: Chunyan Liu > Signed-off