Re: [Xen-devel] [PATCH RFC 5/4] x86: #PF error code adjustments

2015-11-12 Thread Jan Beulich
>>> On 11.11.15 at 17:30, wrote: > On 11/11/15 08:33, Jan Beulich wrote: >> RFC because I noticed that nothing seems to ever set PFEC_page_paged, >> so I wonder whether we really need that flag. > > It is set in hap_p2m_ga_to_gfn() for frames with types of P2M_PAGING_TYPES > > Did you miss this,

Re: [Xen-devel] [PATCH RFC 5/4] x86: #PF error code adjustments

2015-11-11 Thread Andrew Cooper
On 11/11/15 08:33, Jan Beulich wrote: > Add a definition for the (for now unused) protection key related error > code bit, moving our own custom ones out of the way. In the course of > checking the uses of the latter I realized that while right now they > can only get set on their own, callers woul