Re: [Xen-devel] [PATCH RFC 1/7] xen/mem_event: Cleanup of mem_event structures

2014-11-17 Thread Tamas K Lengyel
On Mon, Nov 17, 2014 at 5:44 PM, Jan Beulich wrote: > >>> On 12.11.14 at 16:31, wrote: > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > Leaving aside the general reservation I just voiced in reply to 0/7, I > wonder whether - considering that you mostly replace the code > th

Re: [Xen-devel] [PATCH RFC 1/7] xen/mem_event: Cleanup of mem_event structures

2014-11-17 Thread Jan Beulich
>>> On 12.11.14 at 16:31, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c Leaving aside the general reservation I just voiced in reply to 0/7, I wonder whether - considering that you mostly replace the code that gets changed in this file - it wouldn't be a nice opportunity to

Re: [Xen-devel] [PATCH RFC 1/7] xen/mem_event: Cleanup of mem_event structures

2014-11-13 Thread Tamas K Lengyel
On Wed, Nov 12, 2014 at 4:58 PM, Andrew Cooper wrote: > On 12/11/14 15:31, Tamas K Lengyel wrote: > > diff --git a/xen/include/public/mem_event.h > b/xen/include/public/mem_event.h > > index 599f9e8..c0e9394 100644 > > --- a/xen/include/public/mem_event.h > > +++ b/xen/include/public/mem_event.h

Re: [Xen-devel] [PATCH RFC 1/7] xen/mem_event: Cleanup of mem_event structures

2014-11-12 Thread Andrew Cooper
On 12/11/14 15:31, Tamas K Lengyel wrote: > diff --git a/xen/include/public/mem_event.h b/xen/include/public/mem_event.h > index 599f9e8..c0e9394 100644 > --- a/xen/include/public/mem_event.h > +++ b/xen/include/public/mem_event.h > @@ -49,15 +49,19 @@ > #define MEM_EVENT_FLAG_EMULATE_NOWRITE (1 <