Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

2016-11-01 Thread Eduardo Habkost
On Tue, Nov 01, 2016 at 05:12:37PM +, Wei Liu wrote: > On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote: > > On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: > > [...] > > > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, > > > int running, > > >

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

2016-11-01 Thread Wei Liu
On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote: > On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: > [...] > > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int > > running, > > > > static int xen_init(MachineState *ms) > > { > > +PCMachin

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

2016-11-01 Thread Eduardo Habkost
On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: [...] > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int > running, > > static int xen_init(MachineState *ms) > { > +PCMachineState *pcms = PC_MACHINE(ms); > + > +/* Disable ACPI build because Xen handl

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

2016-11-01 Thread Wei Liu
On Tue, Nov 01, 2016 at 02:59:25PM -0200, Eduardo Habkost wrote: > On Tue, Nov 01, 2016 at 04:53:17PM +, Wei Liu wrote: > > On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: > > [...] > > > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error > > > > **errp) > > >

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

2016-11-01 Thread Eduardo Habkost
On Tue, Nov 01, 2016 at 04:53:17PM +, Wei Liu wrote: > On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: > [...] > > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp) > > > { > > > PCMachineState *pcms = PC_MACHINE(obj); > > > @@ -2159,6 +2173,8 @@

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

2016-11-01 Thread Wei Liu
On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: [...] > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp) > > { > > PCMachineState *pcms = PC_MACHINE(obj); > > @@ -2159,6 +2173,8 @@ static void pc_machine_initfn(Object *obj) > > pcms->vmport = O

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

2016-11-01 Thread Eduardo Habkost
On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: > Introduce this field to control whether ACPI build is enabled by a > particular machine or accelerator. > > It defaults to true so that PC machine has ACPI build by default. Xen > accelerator will disable it because Xen is in charge of bui