Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-09 Thread Oleksandr Andrushchenko
On 02/09/2017 02:48 PM, Konrad Rzeszutek Wilk wrote: On February 9, 2017 3:46:10 AM EST, Oleksandr Andrushchenko wrote: On 02/08/2017 05:29 PM, Konrad Rzeszutek Wilk wrote: . snip.. Reviewed-by: Konrad Rzeszutek Wilk Couple of issues I found in sndif while preparing displif for review: 1.

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-09 Thread Konrad Rzeszutek Wilk
On February 9, 2017 3:46:10 AM EST, Oleksandr Andrushchenko wrote: > > >On 02/08/2017 05:29 PM, Konrad Rzeszutek Wilk wrote: >> . snip.. Reviewed-by: Konrad Rzeszutek Wilk >>> >Couple of issues I found in sndif while preparing displif for review: >1. missing string constants >+#define XENSN

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-09 Thread Oleksandr Andrushchenko
On 02/08/2017 05:29 PM, Konrad Rzeszutek Wilk wrote: . snip.. Reviewed-by: Konrad Rzeszutek Wilk Couple of issues I found in sndif while preparing displif for review: 1. missing string constants +#define XENSND_FIELD_BE_VERSIONS"versions" +#define XENSND_FIELD_FE_VERSION "v

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-08 Thread Oleksandr Andrushchenko
On 02/08/2017 05:29 PM, Konrad Rzeszutek Wilk wrote: . snip.. Reviewed-by: Konrad Rzeszutek Wilk Do you want me to send v18 with the changes requested? Please wait a week for other folks to get a chance to look at this patch. May I put your "Reviewed-by: Konrad Rzeszutek Wilk" in v18? Of c

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-08 Thread Konrad Rzeszutek Wilk
. snip.. > > Reviewed-by: Konrad Rzeszutek Wilk > Do you want me to send v18 with the changes requested? Please wait a week for other folks to get a chance to look at this patch. > May I put your "Reviewed-by: Konrad Rzeszutek Wilk" in v18? Of course! Do please put my Reviewed-by on the patch a

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-08 Thread Oleksandr Andrushchenko
On 02/08/2017 05:16 PM, Konrad Rzeszutek Wilk wrote: On Wed, Feb 08, 2017 at 10:48:45AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Add ABI for the two halves of a para-virtualized sound driver to communicate with each other. The ABI allows implementing audio playbac

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-08 Thread Konrad Rzeszutek Wilk
On Wed, Feb 08, 2017 at 10:48:45AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Add ABI for the two halves of a para-virtualized > sound driver to communicate with each other. > > The ABI allows implementing audio playback and capture as > well as volume control and