Re: [Xen-devel] [PATCH 4/8] libxl: Move check for local access to a funciton

2016-03-21 Thread George Dunlap
On 17/03/16 18:11, Ian Jackson wrote: > George Dunlap writes ("[PATCH 4/8] libxl: Move check for local access to a > funciton"): >> +static char * libxl__device_disk_find_local_path(libxl__gc *gc, >> + const libxl_device_disk >> *disk) { > ... >> +

Re: [Xen-devel] [PATCH 4/8] libxl: Move check for local access to a funciton

2016-03-19 Thread Ian Jackson
George Dunlap writes ("[PATCH 4/8] libxl: Move check for local access to a funciton"): > +static char * libxl__device_disk_find_local_path(libxl__gc *gc, > + const libxl_device_disk > *disk) { ... > +if (disk->format == LIBXL_DISK_FORMAT_RAW >

Re: [Xen-devel] [PATCH 4/8] libxl: Move check for local access to a funciton

2016-03-19 Thread Ian Jackson
George Dunlap writes ("[PATCH 4/8] libxl: Move check for local access to a funciton"): > From: George Dunlap > > Move pygrub checks for local access ability into a separate function. > > Also reorganize libxl__device_disk_local_initiate_attach so that we > don't initialize dls->disk unless we a

Re: [Xen-devel] [PATCH 4/8] libxl: Move check for local access to a funciton

2016-03-18 Thread George Dunlap
On 16/03/16 16:58, Ian Jackson wrote: > George Dunlap writes ("[PATCH 4/8] libxl: Move check for local access to a > funciton"): >> From: George Dunlap >> >> Move pygrub checks for local access ability into a separate function. >> >> Also reorganize libxl__device_disk_local_initiate_attach so tha