Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-15 Thread Juergen Gross
On 07/15/2015 04:54 PM, Dario Faggioli wrote: On Thu, 2015-07-09 at 12:45 +0200, Juergen Gross wrote: On 07/09/2015 12:24 PM, Dario Faggioli wrote: On Wed, 2015-07-08 at 17:13 +0200, Dario Faggioli wrote: On Tue, 2015-07-07 at 13:16 +0200, Juergen Gross wrote: +/* + *

Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-15 Thread Dario Faggioli
On Thu, 2015-07-09 at 12:45 +0200, Juergen Gross wrote: > On 07/09/2015 12:24 PM, Dario Faggioli wrote: > > On Wed, 2015-07-08 at 17:13 +0200, Dario Faggioli wrote: > >> On Tue, 2015-07-07 at 13:16 +0200, Juergen Gross wrote: > +/* > + * In case of shutdown/suspend

Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-09 Thread Juergen Gross
On 07/09/2015 12:24 PM, Dario Faggioli wrote: Hey, 1 thing... On Wed, 2015-07-08 at 17:13 +0200, Dario Faggioli wrote: On Tue, 2015-07-07 at 13:16 +0200, Juergen Gross wrote: @@ -645,25 +675,72 @@ int cpu_disable_scheduler(unsigned int cpu) cpumask_setall(v->cpu_hard_affi

Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-09 Thread George Dunlap
On 07/08/2015 05:37 PM, Dario Faggioli wrote: > On Wed, 2015-07-08 at 17:01 +0100, George Dunlap wrote: >> On Fri, Jul 3, 2015 at 4:49 PM, Dario Faggioli > >>> --- a/xen/common/schedule.c >>> +++ b/xen/common/schedule.c >>> @@ -455,8 +455,8 @@ void vcpu_unblock(struct vcpu *v) >>> * Do the actua

Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-09 Thread Dario Faggioli
Hey, 1 thing... On Wed, 2015-07-08 at 17:13 +0200, Dario Faggioli wrote: > On Tue, 2015-07-07 at 13:16 +0200, Juergen Gross wrote: > > > @@ -645,25 +675,72 @@ int cpu_disable_scheduler(unsigned int cpu) > > > cpumask_setall(v->cpu_hard_affinity); > > > } > > > > >

Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-08 Thread Dario Faggioli
On Wed, 2015-07-08 at 17:01 +0100, George Dunlap wrote: > On Fri, Jul 3, 2015 at 4:49 PM, Dario Faggioli > > --- a/xen/common/schedule.c > > +++ b/xen/common/schedule.c > > @@ -455,8 +455,8 @@ void vcpu_unblock(struct vcpu *v) > > * Do the actual movemet of a vcpu from old to new CPU. Locks for

Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-08 Thread George Dunlap
On Fri, Jul 3, 2015 at 4:49 PM, Dario Faggioli wrote: > The function is called both when we want to remove a cpu > from a cpupool, and during cpu teardown, for suspend or > shutdown. If, however, the boot cpu (cpu 0, most of the > times) is not present in the default cpupool, during > suspend or s

Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-08 Thread Dario Faggioli
On Tue, 2015-07-07 at 13:16 +0200, Juergen Gross wrote: > On 07/03/2015 05:49 PM, Dario Faggioli wrote: > > Solution is to distinguish, inside cpu_disable_scheduler(), > > the two cases of cpupool manipulation and teardown. For > > cpupool manipulation, it is correct to ask the scheduler to > > ta

Re: [Xen-devel] [PATCH 3/4] xen: sched: reorganize cpu_disable_scheduler()

2015-07-07 Thread Juergen Gross
On 07/03/2015 05:49 PM, Dario Faggioli wrote: The function is called both when we want to remove a cpu from a cpupool, and during cpu teardown, for suspend or shutdown. If, however, the boot cpu (cpu 0, most of the times) is not present in the default cpupool, during suspend or shutdown, Xen cras