Re: [Xen-devel] [PATCH 3/2] xen-pciback: drop rom_init()

2016-06-06 Thread Boris Ostrovsky
On 06/06/2016 09:54 AM, Jan Beulich wrote: On 06.06.16 at 15:09, wrote: >> On 06/06/2016 04:47 AM, Jan Beulich wrote: >>> It's identical to bar_init() now. >>> >>> Signed-off-by: Jan Beulich >>> --- >>> I'm sorry for this 3/2 - I only now noticed that this additional >>> simplification is no

Re: [Xen-devel] [PATCH 3/2] xen-pciback: drop rom_init()

2016-06-06 Thread Jan Beulich
>>> On 06.06.16 at 15:09, wrote: > On 06/06/2016 04:47 AM, Jan Beulich wrote: >> It's identical to bar_init() now. >> >> Signed-off-by: Jan Beulich >> --- >> I'm sorry for this 3/2 - I only now noticed that this additional >> simplification is now possible. > > I wonder whether we should also mo

Re: [Xen-devel] [PATCH 3/2] xen-pciback: drop rom_init()

2016-06-06 Thread Boris Ostrovsky
On 06/06/2016 04:47 AM, Jan Beulich wrote: > It's identical to bar_init() now. > > Signed-off-by: Jan Beulich > --- > I'm sorry for this 3/2 - I only now noticed that this additional > simplification is now possible. I wonder whether we should also move content of read_dev_bar() into bar_init().