Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-06-08 Thread Jan Beulich
>>> On 08.06.15 at 12:02, wrote: > On 05/08/2015 07:07 PM, Jan Beulich wrote: >>> > --- a/xen/include/asm-x86/domain.h >>> > +++ b/xen/include/asm-x86/domain.h >>> > @@ -512,6 +513,7 @@ struct arch_vcpu >>> > uint32_t emulate_flags; >>> > unsigned long gpa; >>> > unsigne

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-06-08 Thread Razvan Cojocaru
On 05/08/2015 07:07 PM, Jan Beulich wrote: >> > --- a/xen/include/asm-x86/domain.h >> > +++ b/xen/include/asm-x86/domain.h >> > @@ -512,6 +513,7 @@ struct arch_vcpu >> > uint32_t emulate_flags; >> > unsigned long gpa; >> > unsigned long eip; >> > +struct vm_event_

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-05-11 Thread Jan Beulich
>>> On 09.05.15 at 08:55, wrote: > On 05/09/2015 02:34 AM, Tamas K Lengyel wrote: > @@ -193,6 +200,11 @@ struct vm_event_xsetbv { > >>> uint64_t value; > >>> }; > >>> > >>> +struct vm_event_emul_read_data { > >>> +uint32_t size; > >>> +uint8_t data[164];

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-05-11 Thread Jan Beulich
>>> On 08.05.15 at 18:49, wrote: > On 05/08/2015 07:07 PM, Jan Beulich wrote: > On 06.05.15 at 19:12, wrote: >>> @@ -193,6 +200,11 @@ struct vm_event_xsetbv { >>> uint64_t value; >>> }; >>> >>> +struct vm_event_emul_read_data { >>> +uint32_t size; >>> +uint8_t data[164]; >>

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-05-09 Thread Razvan Cojocaru
On 05/09/2015 11:33 AM, Tamas K Lengyel wrote: > Ah yes, I missed the fact that you put it into a union with regs. I > guess as long as it's the same size as regs it's fine. However, I > think the union will have to be named. Sure, I can name it. When I was working on it I was under the impression

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-05-09 Thread Tamas K Lengyel
On Sat, May 9, 2015 at 8:55 AM, Razvan Cojocaru wrote: > On 05/09/2015 02:34 AM, Tamas K Lengyel wrote: > @@ -193,6 +200,11 @@ struct vm_event_xsetbv { > >>> uint64_t value; > >>> }; > >>> > >>> +struct vm_event_emul_read_data { > >>> +uint32_t size; > >>> +

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-05-08 Thread Razvan Cojocaru
On 05/09/2015 02:34 AM, Tamas K Lengyel wrote: @@ -193,6 +200,11 @@ struct vm_event_xsetbv { >>> uint64_t value; >>> }; >>> >>> +struct vm_event_emul_read_data { >>> +uint32_t size; >>> +uint8_t data[164]; >>> >> >>> >> This number needs an explanat

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-05-08 Thread Tamas K Lengyel
On Fri, May 8, 2015 at 6:49 PM, Razvan Cojocaru wrote: > On 05/08/2015 07:07 PM, Jan Beulich wrote: > On 06.05.15 at 19:12, wrote: >>> --- a/xen/arch/x86/hvm/emulate.c >>> +++ b/xen/arch/x86/hvm/emulate.c >>> @@ -578,6 +578,25 @@ static int hvmemul_read( >>> container_of(ctxt, struct

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-05-08 Thread Razvan Cojocaru
On 05/08/2015 07:07 PM, Jan Beulich wrote: On 06.05.15 at 19:12, wrote: >> --- a/xen/arch/x86/hvm/emulate.c >> +++ b/xen/arch/x86/hvm/emulate.c >> @@ -578,6 +578,25 @@ static int hvmemul_read( >> container_of(ctxt, struct hvm_emulate_ctxt, ctxt)); >> } >> >> +static int hvmemul_re

Re: [Xen-devel] [PATCH 2/5] xen/vm_access: Support for memory-content hiding

2015-05-08 Thread Jan Beulich
>>> On 06.05.15 at 19:12, wrote: > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c > @@ -578,6 +578,25 @@ static int hvmemul_read( > container_of(ctxt, struct hvm_emulate_ctxt, ctxt)); > } > > +static int hvmemul_read_set_context( > +enum x86_segment seg, > +