Re: [Xen-devel] [PATCH 2/4] x86/pv: Introduce pv_create_exception_frame()

2017-05-10 Thread Jan Beulich
>>> On 09.05.17 at 19:09, wrote: > On 09/05/17 16:58, Jan Beulich wrote: > On 08.05.17 at 17:48, wrote: >>> +void pv_create_exception_frame(void) >>> +{ >>> +struct vcpu *curr = current; >>> +struct trap_bounce *tb = &curr->arch.pv_vcpu.trap_bounce; >> const (twice)? >> >>> +struc

Re: [Xen-devel] [PATCH 2/4] x86/pv: Introduce pv_create_exception_frame()

2017-05-09 Thread Andrew Cooper
On 09/05/17 16:58, Jan Beulich wrote: On 08.05.17 at 17:48, wrote: >> +void pv_create_exception_frame(void) >> +{ >> +struct vcpu *curr = current; >> +struct trap_bounce *tb = &curr->arch.pv_vcpu.trap_bounce; > const (twice)? > >> +struct cpu_user_regs *regs = guest_cpu_user_regs(

Re: [Xen-devel] [PATCH 2/4] x86/pv: Introduce pv_create_exception_frame()

2017-05-09 Thread Jan Beulich
>>> On 08.05.17 at 17:48, wrote: > +void pv_create_exception_frame(void) > +{ > +struct vcpu *curr = current; > +struct trap_bounce *tb = &curr->arch.pv_vcpu.trap_bounce; const (twice)? > +struct cpu_user_regs *regs = guest_cpu_user_regs(); > +const bool user_mode_frame = !guest_