Re: [Xen-devel] [PATCH 2/2] xen/mce: fix static variable 'severity_cpu'

2017-04-06 Thread Jan Beulich
>>> On 06.04.17 at 10:49, wrote: > On 04/06/17 02:06 -0600, Jan Beulich wrote: >> >>> On 06.04.17 at 06:55, wrote: >> > @@ -1774,6 +1778,7 @@ void mce_handler_init(void) >> > mce_barrier_init(&mce_severity_bar); >> > mce_barrier_init(&mce_trap_bar); >> > mce_barrier_init(&mce_handl

Re: [Xen-devel] [PATCH 2/2] xen/mce: fix static variable 'severity_cpu'

2017-04-06 Thread Haozhong Zhang
On 04/06/17 02:06 -0600, Jan Beulich wrote: > >>> On 06.04.17 at 06:55, wrote: > > 1. Distinguish 'severity_cpu' used in mcheck_cmn_handler() and > >mce_softirq(), which should be different variables. Otherwise, they > >may interfere with each other if MC# comes during mce_softirq(). > > 2

Re: [Xen-devel] [PATCH 2/2] xen/mce: fix static variable 'severity_cpu'

2017-04-06 Thread Jan Beulich
>>> On 06.04.17 at 06:55, wrote: > 1. Distinguish 'severity_cpu' used in mcheck_cmn_handler() and >mce_softirq(), which should be different variables. Otherwise, they >may interfere with each other if MC# comes during mce_softirq(). > 2. Always (re-)initialize 'severity_cpu' to clear histo