Re: [Xen-devel] [PATCH 2/2] x86emul: consolidate string insn address increments

2016-12-12 Thread Andrew Cooper
On 12/12/16 07:27, Jan Beulich wrote: On 09.12.16 at 18:11, wrote: >> On 09/12/16 15:22, Jan Beulich wrote: >>> Move the looking at EFLAGS.DF into the macro, rendering all call sites >>> more readable. >>> >>> Signed-off-by: Jan Beulich >> The net change is ok; it is certainly cleaner to rea

Re: [Xen-devel] [PATCH 2/2] x86emul: consolidate string insn address increments

2016-12-11 Thread Jan Beulich
>>> On 09.12.16 at 18:11, wrote: > On 09/12/16 15:22, Jan Beulich wrote: >> Move the looking at EFLAGS.DF into the macro, rendering all call sites >> more readable. >> >> Signed-off-by: Jan Beulich > > The net change is ok; it is certainly cleaner to read in the body of > x86_emulate(). > > How

Re: [Xen-devel] [PATCH 2/2] x86emul: consolidate string insn address increments

2016-12-09 Thread Andrew Cooper
On 09/12/16 15:22, Jan Beulich wrote: > Move the looking at EFLAGS.DF into the macro, rendering all call sites > more readable. > > Signed-off-by: Jan Beulich The net change is ok; it is certainly cleaner to read in the body of x86_emulate(). However, the naming of register_address_increment() w