Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-12 Thread Jan Beulich
>>> On 12.03.15 at 15:07, wrote: > On 12/03/15 11:44, Jan Beulich wrote: >> @@ -452,6 +464,7 @@ static struct dmi_system_id __initdata r >> >> static int __init reboot_init(void) >> { >> +default_reboot_type(); > > This still suffers from the bug Ross fixed in patch 1. If the user > prov

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-12 Thread Andrew Cooper
On 12/03/15 11:44, Jan Beulich wrote: On 11.03.15 at 19:49, wrote: >> From: Konrad Rzeszutek Wilk >> Date: Tue, 3 Feb 2015 11:18:04 -0500 >> Subject: [PATCH] efi: Allow reboot= overrides when running under EFI >> >> By default we will always use EFI reboot mechanism when >> running under EFI

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-12 Thread Konrad Rzeszutek Wilk
On March 12, 2015 7:44:58 AM EDT, Jan Beulich wrote: On 11.03.15 at 19:49, wrote: >> From: Konrad Rzeszutek Wilk >> Date: Tue, 3 Feb 2015 11:18:04 -0500 >> Subject: [PATCH] efi: Allow reboot= overrides when running under EFI >> >> By default we will always use EFI reboot mechanism when >>

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-12 Thread Jan Beulich
>>> On 11.03.15 at 19:49, wrote: > From: Konrad Rzeszutek Wilk > Date: Tue, 3 Feb 2015 11:18:04 -0500 > Subject: [PATCH] efi: Allow reboot= overrides when running under EFI > > By default we will always use EFI reboot mechanism when > running under EFI platforms. However some EFI platforms > are

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-12 Thread Konrad Rzeszutek Wilk
On Wed, Mar 11, 2015 at 02:08:37PM +, Jan Beulich wrote: > >>> On 11.03.15 at 12:44, wrote: > > On some systems, the ResetSystem EFI runtime service is broken. Follow the > > Linux (and Windows) way by preferring ACPI reboot over EFI reboot. This is > > done by making BOOT_EFI a reboot mode

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-12 Thread Jan Beulich
>>> On 11.03.15 at 12:44, wrote: > On some systems, the ResetSystem EFI runtime service is broken. Follow the > Linux (and Windows) way by preferring ACPI reboot over EFI reboot. This is > done by making BOOT_EFI a reboot mode similar to BOOT_ACPI and BOOT_KBD. No. Just because Linux and/or Win

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-11 Thread Konrad Rzeszutek Wilk
On Wed, Mar 11, 2015 at 03:19:28PM +, Jan Beulich wrote: > >>> On 11.03.15 at 15:36, wrote: > > @@ -504,10 +511,9 @@ void machine_restart(unsigned int delay_millisecs) > > tboot_shutdown(TB_SHUTDOWN_REBOOT); > > } > > > > -efi_reset_system(reboot_mode != 0); > > - > >

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-11 Thread Jan Beulich
>>> On 11.03.15 at 15:36, wrote: > @@ -504,10 +511,9 @@ void machine_restart(unsigned int delay_millisecs) > tboot_shutdown(TB_SHUTDOWN_REBOOT); > } > > -efi_reset_system(reboot_mode != 0); > - > /* Rebooting needs to touch the page at absolute address 0. */ > -*((unsi

Re: [Xen-devel] [PATCH 2/2] CA-162192: Fix rebooting on some EFI-booted systems

2015-03-11 Thread Andrew Cooper
On 11/03/15 11:44, Ross Lagerwall wrote: > On some systems, the ResetSystem EFI runtime service is broken. Follow the > Linux (and Windows) way by preferring ACPI reboot over EFI reboot. This is > done by making BOOT_EFI a reboot mode similar to BOOT_ACPI and BOOT_KBD. > > This was seen on an Int